From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cGVWLuqAjGLnSAEAbAwnHQ (envelope-from ) for ; Tue, 24 May 2022 08:53:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mMpRLeqAjGLjcAEAG6o9tA (envelope-from ) for ; Tue, 24 May 2022 08:53:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 20868A76A for ; Tue, 24 May 2022 08:53:30 +0200 (CEST) Received: from localhost ([::1]:43088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntOQ5-0008Pd-7O for larch@yhetil.org; Tue, 24 May 2022 02:53:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntONi-00075h-AP for guix-patches@gnu.org; Tue, 24 May 2022 02:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntONh-0004pC-L6 for guix-patches@gnu.org; Tue, 24 May 2022 02:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ntONh-0003x6-JL for guix-patches@gnu.org; Tue, 24 May 2022 02:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53833] [PATCH v2] gnu: Add qbe. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 May 2022 06:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53833 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(unmatched-parenthesis" , 53833@debbugs.gnu.org Received: via spool by 53833-submit@debbugs.gnu.org id=B53833.165337505115175 (code B ref 53833); Tue, 24 May 2022 06:51:01 +0000 Received: (at 53833) by debbugs.gnu.org; 24 May 2022 06:50:51 +0000 Received: from localhost ([127.0.0.1]:50801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntONX-0003wh-BS for submit@debbugs.gnu.org; Tue, 24 May 2022 02:50:51 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:40079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntONR-0003wW-R3 for 53833@debbugs.gnu.org; Tue, 24 May 2022 02:50:49 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L6lFt4gK6z1LZX3; Tue, 24 May 2022 08:50:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4L6lFt4gK6z1LZX3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653375042; bh=4DXFL0ktUzHfDye7G8rgABfS7DpoK4Mv7gs6gvIzl1w=; h=Subject:From:To:Date:In-Reply-To:References:From; b=OP8+DlqxZfYtD6MPI+ja16eJt0RZgexCw+526ERv9qh2u2BTSYcz9YEkkpKWcIsXQ pfexMQfa2Yecy3PK2YuI2eTSppSy/tGOXAppK2OCQjWfWmdHVUwdF27HCvlFvQUoxP kW3uHugATqv0Rh/f6f1BWDaax/mZHhFCZdhRltdg= Message-ID: <2b0a34e61f45a706afb7e84a5cac9aae8a9e10aa.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Tue, 24 May 2022 08:50:41 +0200 In-Reply-To: <20220508202154.9648-1-paren@disroot.org> References: <20220508202154.9648-1-paren@disroot.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653375210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4DXFL0ktUzHfDye7G8rgABfS7DpoK4Mv7gs6gvIzl1w=; b=hitOVLCBH7MuAtUbqGJo+16wGlxVoFihHa72/hBnpWjBFu9n6ked4Wwj1taXSR7KN1oQ58 l7mwguNKebdWE60zNdKJbh6YGxX0uQ5xlUPKOWsfB5RpQnn+7ECOpIEdn883/lRpGvbErp cemhFlgHKOBB550AfrffdvFtvnsAVWQRRcFeSYtXtvSI3mLfgR3Qy8Mcru5ghhoLA4rZ/Y 8+q5o0czvIc6Ib7dRjCZhajCFsMFL028I2DND/5Jw0U9fryO/6ghw2nRs2yxDNUbZSFrJK /ggcj6PBf0owdle8/eGAUK32CaS68IK81LjrzUMjbYRZq8MR3WPopgmZFC2eDQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653375210; a=rsa-sha256; cv=none; b=Mgbv1QMMOe6mGopesht6ee3Jo/1sy85u4oziZcv0TCGHXlVdKkwcgH2u+WuozAAo+QW/DI uS5bNOVHX42K8fUjCQAxs+w3imuvlyF0vPoZO6tHoqGcc5q+MSThOub79jPWF1KmaP1Aaj ngfGcvJy9CNss7vZpZ1+KnyFeiuWQFg+hmAyDpBajEi1mVSEUDqaskINr9OD5HKfGEqF6b O5nsRqUUkC0XnzlTeNzuBJhSte2iL/WW6D9XYvM+OevFf3onn9QD0FDVK/J30CrqvYaaZd 3Rk12MK77YA1tE535Hwwact+ov45y1yycXOPANx1aGZzQ6r75Mt8VAa8j4RYyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=OP8+Dlqx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=OP8+Dlqx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 20868A76A X-Spam-Score: 7.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: fWX6fZoFh3uh Hi, this is mostly a reminder for myself to push this soon. Am Sonntag, dem 08.05.2022 um 21:21 +0100 schrieb (unmatched- parenthesis: > * gnu/packages/c.scm (qbe): New variable. > > Signed-off-by: (unmatched-parenthesis Don't add sign-off headers for your own patches, those are for committers signing of other people's patches :) > [...] > +    (arguments > +     (list #:make-flags > +           #~(list (string-append "CC=" #$(cc-for-target)) > +                   (string-append "PREFIX=" #$output) > +                   ;; `GUIXTARGET` is used instead of `TARGET` to > avoid changing > +                   ;; the meaning of tools/test.sh (which uses > `TARGET` too). > +                   (string-append "GUIXTARGET=" #$(or (%current- > target-system) > +                                                      (%current- > system)))) > +           #:phases > +           #~(modify-phases %standard-phases > +               (add-after 'unpack 'allow-cross-compilation > +                 (lambda _ > +                   (substitute* "Makefile" > +                     (("`uname -m`") "$(GUIXTARGET)")))) Instead of going through the variable, why not inline it into the substitute*? > +               (add-after 'allow-cross-compilation 'use-gcc-for- > tests > +                 (lambda _ > +                   (substitute* "tools/test.sh" > +                     (("cc=\"cc -no-pie\"") > +                      (string-append "cc=\"${CC} -no-pie\""))))) > +               (delete 'configure)))) > +    (supported-systems (list "x86_64-linux" "aarch64-linux" > "riscv64-linux")) > +    (synopsis "Simple compiler backend") > +    (description "QBE is a small compiler backend using an SSA-based > intermediate > +language as input.") > +    (home-page "https://c9x.me/compile/") > +    (license license:expat)))) Otherwise LGTM. Cheers