From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SIWbMnN6+l6eXgAA0tVLHw (envelope-from ) for ; Mon, 29 Jun 2020 23:34:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uH1QLnN6+l46eQAAbx9fmQ (envelope-from ) for ; Mon, 29 Jun 2020 23:34:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D605E9401CD for ; Mon, 29 Jun 2020 23:34:10 +0000 (UTC) Received: from localhost ([::1]:43310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jq3Ht-0001jX-SI for larch@yhetil.org; Mon, 29 Jun 2020 19:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq3Hm-0001j9-Og for guix-patches@gnu.org; Mon, 29 Jun 2020 19:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jq3Hm-0006xW-Ew for guix-patches@gnu.org; Mon, 29 Jun 2020 19:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jq3Hm-00042G-AU for guix-patches@gnu.org; Mon, 29 Jun 2020 19:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41778] [PATCH 0/3] Add ppsspp Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Jun 2020 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41778 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 41778@debbugs.gnu.org Received: via spool by 41778-submit@debbugs.gnu.org id=B41778.159347364115505 (code B ref 41778); Mon, 29 Jun 2020 23:34:02 +0000 Received: (at 41778) by debbugs.gnu.org; 29 Jun 2020 23:34:01 +0000 Received: from localhost ([127.0.0.1]:49768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq3Hk-000420-S4 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 19:34:01 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:55170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq3Hh-00041o-Ep for 41778@debbugs.gnu.org; Mon, 29 Jun 2020 19:34:00 -0400 Received: from nijino.local (193-81-159-42.hdsl.highway.telekom.at [193.81.159.42]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 49wkMk1WCXz1LLyX; Tue, 30 Jun 2020 01:33:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 49wkMk1WCXz1LLyX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1593473634; bh=V/Au0gwCojTg4H2Z5kNoFug1qFncP9waG25o5WZtCc0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Hqd9nPnge2WgbTz4k0fu07hgBp5Yxrz7x2aY81ndsWg4gpD98nCsnxfue4J4BVKSt vSqbk5OM3sbV+arzUHGoOCIrNHFi79v+MOPLg86HC0+xOdFahYhi7BE3po/04gL3M+ t0xUSuqHk26PaapOvxaiK+NUzrZIFCqxUpk8qmVE= Message-ID: <2aaef91e896f56a9f06a696a8c4e75c8b4cc65bf.camel@student.tugraz.at> From: Leo Prikler Date: Tue, 30 Jun 2020 01:33:52 +0200 In-Reply-To: <87wo3pil8j.fsf@nicolasgoaziou.fr> References: <785a75894730f36908da7c0775f85058eb32787e.camel@student.tugraz.at> <0e2c18a84e232f73a72d755a692feaece0118396.camel@student.tugraz.at> <87wo3pil8j.fsf@nicolasgoaziou.fr> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=Hqd9nPng; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 9cnZmwYCq7BW Hello, Am Dienstag, den 30.06.2020, 00:02 +0200 schrieb Nicolas Goaziou: > Hello, > > Leo Prikler writes: > > > Following the release of version 1.10, I've updated my package > > descriptions. I've also been able to unbundle some sources, but > > not > > all of them. > > OOC, did you try to symlink sources instead of copying them? No, but I'd imagine it would not work out great, because the source is a git checkout in /gnu/store, which is read-only and it is compiled in- place. > Note that you don't mention what is left to unbundle. Would it make > sense to add this information? I'm looking mostly at the contents of ext/ here, which has stuff we already package, like cityhash among others. A bit of context is given in the unbundling snippet I use for glslang and spirv-cross, which I've managed to unbundle, but the rest are not pulled in as submodules, so it would require a `guix build --source` and manual analysis to sift through all that. I don't think a less vague comment could improve this understanding without risking to be invalidated at some point in the future. Perhaps I could clarify, that it's "mostly ext/", but even that is not completely true, since upstream also has ffmpeg as a toplevel submodule (which I don't pull in, instead using the flags they already provide for using system ffmpeg). > Otherwise, LGTM, barring the description of spirv-cross, where I > suggest > to drop the "NOTE:" part. It reminds me taisei package felt through > the > cracks. I'll apply it once spirv-cross is pushed. To be fair, that's where I copied it from – I think I already mentioned that. I just updated the version and added some details in the comment regarding failing tests and hence added my updated patch. I also think this description to be quite weird, but at the same time am unsure on how to better rephrase it. I will send an updated version of it once I do come up with something better than just dropping the "NOTE:" part. Regards, Leo