From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CAmELoTdh2Z7UwEAqHPOHw:P1 (envelope-from ) for ; Fri, 05 Jul 2024 11:48:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CAmELoTdh2Z7UwEAqHPOHw (envelope-from ) for ; Fri, 05 Jul 2024 13:48:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=ogbutlwU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720180100; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sOzZ2b93D4VZXqBhsn3e/q944aGQSNQZLekWzDV2n4w=; b=VSrT3xG27mp1E6oMTyqXDm4Ex3VehVcYEb3Di1sJzIGOiZzo4lfL6sQwhZH0ZI32cPJPk4 tJYQIr8x315sXNphkJtR7ZpkJQ1YCODmkpHGR2DfVWvLb42CDFVyvMgve5NLsrShNvsg+0 hwAdk3n/QhBz8mQLxXL/xlX10McKDvvlzYY+OKiZYlzduhQow5gNQ4QKMo6QGVn/xhNSKn Vk3fP79bMEppHz2i6ioGWbfdUus6dxkwzI67NcTTc51ScH+E+laFgqqGB7qWGf4N8wdJov MAzeklhBRIpyexCFOhAdjtzEHOohw3dvuQJYnU95UyEmYpPzFbGMtpOZac1QGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720180100; a=rsa-sha256; cv=none; b=XjFBlmLgex3oCnlkUuAvs86H+irfDmrytFAWfkyRhuVXDbFK6MQoa2JK4n+2wCCD/BoA4I fqqRUFE3mhq3+3fiE7Z5MVvOxSs/v0OvmlaRGsZU49gBdYQwIdr2bdhJseapoZ6WCkJuTu FMl0s/Apylo9beUeZ3xfBAnrDBVUCGxKjFnmyphiflBwqonFQOi74AriLcWOpLQR8bs/s8 KRhRXOmGYuJbYdPWVU/B+kKtV2DLIOwDZSqXoRlJUrGBPOlG2xMW9AlouDdRNDddCcxjwg mcqq/Y0Fu1YKkJKv+EVovkpl1VpbQSvG1JX+s22mYIN2tTELwnGC02ke5LD6dg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=ogbutlwU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8DCEC68825 for ; Fri, 5 Jul 2024 13:48:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPhQ2-0000Nz-3g; Fri, 05 Jul 2024 07:48:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPhQ0-0000NM-4p for guix-patches@gnu.org; Fri, 05 Jul 2024 07:48:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPhPz-00013G-S3 for guix-patches@gnu.org; Fri, 05 Jul 2024 07:47:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPhQ2-0004MG-Ek for guix-patches@gnu.org; Fri, 05 Jul 2024 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Jul 2024 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: Troy Figiel , 69074@debbugs.gnu.org Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.172018004216692 (code B ref 69074); Fri, 05 Jul 2024 11:48:02 +0000 Received: (at 69074) by debbugs.gnu.org; 5 Jul 2024 11:47:22 +0000 Received: from localhost ([127.0.0.1]:43683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPhPN-0004LA-Lw for submit@debbugs.gnu.org; Fri, 05 Jul 2024 07:47:21 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPhPL-0004L1-LV for 69074@debbugs.gnu.org; Fri, 05 Jul 2024 07:47:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=sOzZ2b93 D4VZXqBhsn3e/q944aGQSNQZLekWzDV2n4w=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=ogbutlwUsESQVDtT8jNXkPHe8te X4X98WVgNHpsmmzBZJ1X5BpKfkP96j73f9ktbzGb+qSWRZtKSHURv0SFXlYETYTqKLq56E dYI5drgX3N8CmJ4xCYJjO9U2q8KFJMOVjyhVy+1Rf3YMVn+GbdfSAVYYje8fxPq2wW5RSO 0O9I= Received: from localhost (dynamic-2a02-3102-49da-001b-e21d-4fb5-a2ea-d7fd.310.pool.telefonica.de [2a02:3102:49da:1b:e21d:4fb5:a2ea:d7fd]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 615731d9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Fri, 5 Jul 2024 13:47:14 +0200 (CEST) Date: Fri, 05 Jul 2024 13:47:09 +0200 From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <87ikxltdfu.fsf@unknown72cc92733c3c.attlocal.net> <3C16M9FD36BME.3EMO3MFHGE9NG@8pit.net> In-Reply-To: Message-Id: <2Z5WA5IA96MHL.3CMTOHDZJPPDF@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 8DCEC68825 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.29 X-Spam-Score: -5.29 X-TUID: 5iPJDTZtAqrP Hi, Thanks for your feedback! "jgart" wrote: > In addition to that, I would also say to make sure you run the linter > on all of your code to check for warnings and fix suggestions. > > That said, can you send a revision fixing the suggestions made by the > linter in the latest version of your patch set? Please add the linter fix= es > grouped to their respective logical commit. I was under the impression that I fixed the relevant linker warnings. I didn't fix the capstone warnings as I only added a patch for capstone and didn't want to refactor the existing code as part of that (i.e. the warnings are not introduced by my changes). For python-angr I only get two "line is way too long"-warnings, both caused by long not easily breakable strings (e.g. the checksum). Should I refactor the capstone package as part of this patchset? Am I missing any additional linter warnings? Best, S=C3=B6ren