From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UOxnBml7imZkSAEAqHPOHw:P1 (envelope-from ) for ; Sun, 07 Jul 2024 11:26:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id UOxnBml7imZkSAEAqHPOHw (envelope-from ) for ; Sun, 07 Jul 2024 13:26:33 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=iZJ+cULX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720351578; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=keHw6jyJR6kxQyaufT6UxLavswzsW4nsjwse1bCtwUY=; b=hOO+We00YZwW8K0hL3IpJs9+3LTHB0+9sVHq8Z2Is245R2jijoffzRJcjrd3V8NvK7Rwy2 3yyZZLhHQl0a57fhw15W54ZI/0w+SWasaE9UkaoUvjgBVieRW6W3yXOG3q/ow5GaU4FBmk 1eg92831/tM9EPIS1qitiY38dhJiBLBrhwrkQsQmwnCMj6lqQ7UhY9PV+XqiDkENR+hJz1 sVmZWFflxHyj40J/QAgCUo7s4eGARq1lYfUvSh6+iAXiUN1H3eGl5i+6gsgrAfAFs+RnF1 4fJEK+g7pHi+7XZf4AszNBKb16FrFzSaRWsf6IEO3j/ZAN11nlDQbn4cp5sABA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720351578; a=rsa-sha256; cv=none; b=B0ybxqDzpSisnfdaHLn9oQLUWWKkqqmA920L4MLnjeRDbSPpqE3us4tVDW0UiJzm4r1gy7 CAdG5OWHrc00OVDH889Ctl9D+RC9LeCvkx0Kz0Us5degSKTOLf7k7bKxmh/r6dH7SMG5N3 wTr0sY/CL8/ijND6AnGF0v4KZwRmd543uqkxnS9Z79jb5Jgm9NQysD5dRlDM4TRb0JnbLs 0BNQRmmjkPCtSiB9yMbu51MJfL2/LO1NYDv6Dzcl6KPCnzd0GipelGt+taug+7k0wy13f0 kwokrI3Oalg/AxJ1DkK4wL10un3nVw/zcnZZhVqCrvPvayETbCYmbLg8NGlv7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=iZJ+cULX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA0E81F325 for ; Sun, 7 Jul 2024 13:26:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQQ1o-0002kb-6Z; Sun, 07 Jul 2024 07:26:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQQ1m-0002jx-CF for guix-patches@gnu.org; Sun, 07 Jul 2024 07:25:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQQ1m-0003Ff-3D for guix-patches@gnu.org; Sun, 07 Jul 2024 07:25:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQQ1q-0001Me-2b for guix-patches@gnu.org; Sun, 07 Jul 2024 07:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71925] [PATCH 2/2] gnu: klee: Build with klee-uclibc support. Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Jul 2024 11:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: julien@lepiller.eu, 71925@debbugs.gnu.org Received: via spool by 71925-submit@debbugs.gnu.org id=B71925.17203515075173 (code B ref 71925); Sun, 07 Jul 2024 11:26:02 +0000 Received: (at 71925) by debbugs.gnu.org; 7 Jul 2024 11:25:07 +0000 Received: from localhost ([127.0.0.1]:47502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQQ0x-0001LM-65 for submit@debbugs.gnu.org; Sun, 07 Jul 2024 07:25:07 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:47170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQQ0u-0001L7-Pm for 71925@debbugs.gnu.org; Sun, 07 Jul 2024 07:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=keHw6jyJ R6kxQyaufT6UxLavswzsW4nsjwse1bCtwUY=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=iZJ+cULXW4lGvzbqMkLVRftU/2N iHrtZ7E3LuptDA7LRtq4zE3pPTY9eW/o64CW50+zyCzV3ocx5OVdTPMiSuA7GpGK0mc285 Dn990Vn0BkwRFJgK0cnwgxVwBZqRXU0fWnk+fu11ube8KjZ7BALp1QWrH+tLG82j2FHHqk NvL0= Received: from localhost (dynamic-2a02-3102-49da-001b-8090-663c-294a-426c.310.pool.telefonica.de [2a02:3102:49da:1b:8090:663c:294a:426c]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 71de436a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 7 Jul 2024 13:24:57 +0200 (CEST) Date: Sun, 07 Jul 2024 13:24:53 +0200 From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <50e13182dab9f13a90c63a670a286eb447133e44.1720033365.git.soeren@soeren-tempel.net> In-Reply-To: Message-Id: <2XB2CJ5QYV5K9.2OYVJ6R77DM9T@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: DA0E81F325 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.29 X-Spam-Score: -5.29 X-TUID: OHLShHLRuHXo Hi Liliana, Thanks a lot for the quick feedback, responses below. Liliana Marie Prikler wrote: > The leading colon is pointless here, since you're doing an "=3D" assign. Good catch! I can fix this in a patch revision. > More importantly, can we make this a search path? I don't think so as it's not a colon separated search path, it can only point to a single directory; hence, I assumed that wrap-program is more appropriate here. > Can we use search-input-file for this and dirname our way up? The input file that we are looking for here is called libc.a, I am not sure what the benefit of using search-input-file is, but I personally think something along the lines of `(dirname (search-input-file %build-inputs "/lib/libc.a"))` is less readable then `#$klee-uclibc` but I can definitely change this if you want me to :) > Is this only distributed as an .a file or could we make a .so out of > it? This is only distributed as a .a, not as a shared object. In fact, KLEE also doesn't not link against this library at all and instead converts it to an LLVM .bca file (shipped in /lib/klee/runtime/klee-uclibc.bca) during build. This file is then used directly by KLEE's symbolic LLVM interpreter to execute code utilizing libc functions. Hence, klee-uclibc is also not a propagated input for the klee package. Let me know if I should send a revision, would love to get this merged. Greetings S=C3=B6ren