From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qD7GG8ZmjWZhNgAAqHPOHw:P1 (envelope-from ) for ; Tue, 09 Jul 2024 16:35:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qD7GG8ZmjWZhNgAAqHPOHw (envelope-from ) for ; Tue, 09 Jul 2024 18:35:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=mepV6SfV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720542918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5UmqvniX0+ptrNegJVpcSypnEbWVKQ8qh9iBwKOrdRE=; b=CHSntNTApcp2wtbFKs36bs4czKsmEWO/FsXoPPZlGCBs1RrcdvX0Xdbn/ujLzFFtlJW7eV dV9+GntsIWSlw8nqlUjEErPpztyrcT6P2MbraCP/VMnaV2WOFaLZgcfEGjhc5msD9QcOPe /pflbL1r6VoQA9CbFdvqxrz+AgM84UDzqgzl2AR+WcX+t70hCkhR6gPRwbYQvhMX4V0RtT xB0YoZAWbUGPyaI2WluXVSDhRUk6NGaKEecXhVZeV20u86enonM4EgzurKSjXx4FbWHs0p N0rd68HNY5E42t5c6Xt0OhjNG55rgCV5oilq7b6Xh4KJgIHBTQWMKnY4K8F3uA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=mepV6SfV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720542918; a=rsa-sha256; cv=none; b=sp/pSCSptJMSe9KJriRYBApiOXeozLIuNcIvRb990SSEeLIsGkd5r7HrSWyfG1VVGtpygj Ns24Yp4BNDR0G0WpZ3pDDRXlrORCzhg0Zpcy/R+v0b5F69A9SLO9cEeSlvsl8E3NplTWCh ChnICnhV0ilWACawszCAUl8xSiNe+AN8BlUtIEjdvZ10vDu04Er86qc8XbK8p0uHcuwstd FP0L2T4U+swZuvNIvLgJ6sKdYPgh1jNpA45wkOgX/01adxPXUgT88GzzUtzlT1/JibG5Eo d4M+z3Ay5NaLvSizFD4COhg3wZ982AAKNtfhdLlzOXjF56JE6cHQNURUFtxhyQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0667A64A1F for ; Tue, 9 Jul 2024 18:35:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRDnv-0004yA-Lj; Tue, 09 Jul 2024 12:34:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRDnt-0004w5-6O for guix-patches@gnu.org; Tue, 09 Jul 2024 12:34:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRDns-0002XR-UI for guix-patches@gnu.org; Tue, 09 Jul 2024 12:34:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRDny-00080Q-D7 for guix-patches@gnu.org; Tue, 09 Jul 2024 12:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jul 2024 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: Troy Figiel , 69074@debbugs.gnu.org Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.172054289030748 (code B ref 69074); Tue, 09 Jul 2024 16:35:02 +0000 Received: (at 69074) by debbugs.gnu.org; 9 Jul 2024 16:34:50 +0000 Received: from localhost ([127.0.0.1]:53960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRDnm-0007zr-Bd for submit@debbugs.gnu.org; Tue, 09 Jul 2024 12:34:50 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRDnk-0007zi-A3 for 69074@debbugs.gnu.org; Tue, 09 Jul 2024 12:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=5UmqvniX 0+ptrNegJVpcSypnEbWVKQ8qh9iBwKOrdRE=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=mepV6SfV6d63LhRoOXfbqR/49Hz jXnJA782PrdMQr8xpGBr629y8ldPpnx4zYh1FSMeKUxkv6Bp0MpExRzTr/76R+qNw9XAyQ qceRK8R3Y905tQYLkatyrpkk3Qb6btZ73hLKQRny/1ZOrL8Si2LX0XkuR+1HoZrOU4uUQi 02/0= Received: from localhost (dynamic-2a02-3102-49da-001b-167b-bb16-88d3-7747.310.pool.telefonica.de [2a02:3102:49da:1b:167b:bb16:88d3:7747]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 5efeac56 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Tue, 9 Jul 2024 18:34:40 +0200 (CEST) Date: Tue, 09 Jul 2024 18:35:43 +0200 From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <87sewjwp27.fsf@dismail.de> In-Reply-To: <87sewjwp27.fsf@dismail.de> Message-Id: <2LMPJ6YV17207.3P4OUCL84XQ6O@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 0667A64A1F X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.80 X-Spam-Score: -3.80 X-TUID: 46NAwWES9680 Thanks for taking the time to look at the patchset in greater detail! I really appreciate your feedback and have been learning a lot :) jgart wrote: > Could you send just the capstone package in a separate new ticket and CC = me? Sure, see #72015. I can also submit each new package separately if that easier to review for you, just let me know. > My time is limited and I think that this will allow us to progress on > this issue. Sorry, I don't intend to waste your time. I thought this patchset was in a good state already given that I already incorporated a lot of good feedback from Troy, fixed all the linter warnings, made it pass on the CI and also have been using this Guix package for a long time myself. I am definitely committed and interested in improving it further. > Notice that I changed the package name. The upstream is called > *demangler and not *demangle. I also added a note as to why we are not > using the PyPI source. If not using the PyPI source we should add a > comment as to why not. We prefer PyPI whenever possible for `guix > import` tool reasons. Thanks for pointing this out! I can add more comments. In most cases, the PyPI source is missing files required to run the test suite. > Can you send a v2 without python-itanium-demangler in a new patch > series? Yes, will do so after the capstone patch from above is merged so that I can also exclude that patch from the v2 of this patchset. > I applied python-itanium-demangler in this commit: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D789c4037947d59a71= 43999269791bf75436fdccd Thanks! > Another thing I noticed is that we have this ticket open for pwntools: > > https://issues.guix.gnu.org/61431 > > -;; python-pwntools requires a -rc release of unicorn > > The above line was removed but this patch series leaves pwntools broken. python-pwntools does not build right now. Therefore, pwntools is already in a broken state. As such, my patchset doesn't change the status quo in this regard. My initial goal was to keep this patchset simple(r) by focusing on angr and not including unrelated changes; hence, I didn't touch pwntools here. > Also, if there are versions of Python packages that are specifically > needed for angr and no other packages depend on them then I think it > would be better practice to call them python-foo-for-angr instead of > leaving a comment and using the package name python-claripy. For > example, python-claripy-for-python-angr. We have similar packages in the > guix package collection that follow such a pattern. The latest version > of python-claripy is 9.2.109 and you're packaging 9.2.46 with the > top-level variable name. claripy and the other packages added here can be used without angr (and there is free software out there which does so), it's just that the version needs to be in sync with python-angr. I would personally prefer to stick to the PyPI name. Sincerely, S=C3=B6ren