unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: rennes <rennes@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26582@debbugs.gnu.org
Subject: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Fri, 21 Apr 2017 21:40:03 -0500	[thread overview]
Message-ID: <2ExjL3FnTH2ActBCbOgZRN@lTC1VtRxjDOEtGzP2P9M4> (raw)
In-Reply-To: <874lxilqgu.fsf@gnu.org> (from ludo@gnu.org on Thu Apr 20 16:27:29 2017)

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Hello,

On 04/20/2017 04:27:29 PM, Ludovic Courtès wrote:
> >
> > I moved zlib and readline to 'native-inputs'.
> 
> Are you sure they need to be native inputs?  Both are libraries, so I
> imagine they’re used at run time, not at build time; they should be
> inputs, in this case.
> 
I added system types: "--build=" and "--host=" to 'configure'. Now  
detects correctly the inputs.

Built successfully on Linux x86_64, GNU/Hurd and cross-compiling with  
target 'i586-pc-gnu'.
Thanks for the guide

[-- Attachment #2: 0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch --]
[-- Type: text/x-patch, Size: 3805 bytes --]

From 05f159e343173708b85c5e45b6cfe64e3939c68d Mon Sep 17 00:00:00 2001
From: rennes <rennes@openmailbox.org>
Date: Fri, 21 Apr 2017 21:22:08 -0500
Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.

* gnu/packages/pcre.scm (pcre)[arguments]: Add "--disable-stack-for-recursion".	
---
 gnu/packages/pcre.scm | 43 ++++++++++++++++++++++++++++++++++---------
 1 file changed, 34 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/pcre.scm b/gnu/packages/pcre.scm
index 1946f5229..ca51ff7ec 100644
--- a/gnu/packages/pcre.scm
+++ b/gnu/packages/pcre.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2017 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2017 Rene Saavedra <rennes@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,6 +25,7 @@
 (define-module (gnu packages pcre)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages hurd)  
   #:use-module (gnu packages readline)
   #:use-module (gnu packages)
   #:use-module (guix packages)
@@ -54,15 +56,38 @@
              ("readline" ,readline)
              ("zlib" ,zlib)))
    (arguments
-    '(#:disallowed-references ("doc")
-      #:configure-flags '("--enable-utf"
-                          "--enable-pcregrep-libz"
-                          "--enable-pcregrep-libbz2"
-                          "--enable-pcretest-libreadline"
-                          "--enable-unicode-properties"
-                          "--enable-pcre16"
-                          "--enable-pcre32"
-                          "--enable-jit")))
+    `(#:disallowed-references ("doc")
+      #:phases
+      (modify-phases %standard-phases
+        (replace 'configure
+                 (lambda* (#:key outputs build target #:allow-other-keys)
+                   (let* ((out (assoc-ref outputs "out"))
+                          (bin (assoc-ref outputs "bin"))
+                          (doc (assoc-ref outputs "doc")))
+                     (setenv "CONFIG_SHELL" (which "bash"))
+                     (zero?
+                      (system* "./configure"
+                               (string-append "--prefix=" out)
+                               (string-append "--bindir=" bin)
+                               (string-append "--docdir=" doc)
+                               (string-append "--build=" build)
+                               (string-append "--host=" (or target build))
+                               "--enable-utf"
+                               "--enable-pcregrep-libz"
+                               "--enable-pcregrep-libbz2"
+                               "--enable-pcretest-libreadline"
+                               "--enable-unicode-properties"
+                               "--enable-pcre16"
+                               "--enable-pcre32"
+                               "--enable-jit"
+                               ;; On GNU/Hurd systems FAIL 'RunTest' with 'segmentation
+                               ;; fault' in Check phase, to pass the test we can disable
+                               ;; "--enable-jit" or set "--disable-stack-for-recursion"
+                               ;; argument.
+                               ,@(if (hurd-triplet? (or (%current-system)
+                                                        ( %current-target-system)))
+                                     '("--disable-stack-for-recursion")
+                                     '())))))))))
    (synopsis "Perl Compatible Regular Expressions")
    (description
     "The PCRE library is a set of functions that implement regular expression
-- 
2.12.0


  parent reply	other threads:[~2017-04-22  2:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  5:12 bug#26575: [PATCH] gnu: pcre: Fix Check for Hurd systems rennes
2017-04-20 14:08 ` Manolis Ragkousis
2017-04-20 19:31   ` bug#26582: " rennes
2017-04-20 21:27     ` Ludovic Courtès
2017-04-21  2:38       ` rennes
2017-04-22  2:40       ` rennes [this message]
2017-04-22 22:13         ` Ludovic Courtès
2017-04-29 22:25           ` rennes
2017-05-01 13:34             ` rennes
2019-02-13 11:58     ` Manolis Ragkousis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ExjL3FnTH2ActBCbOgZRN@lTC1VtRxjDOEtGzP2P9M4 \
    --to=rennes@openmailbox.org \
    --cc=26582@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).