From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNg6z-0002pQ-Bp for guix-patches@gnu.org; Mon, 06 May 2019 12:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNg6x-0001y2-MW for guix-patches@gnu.org; Mon, 06 May 2019 12:05:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNg6x-0001xA-3t for guix-patches@gnu.org; Mon, 06 May 2019 12:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hNg6w-0002dq-JD for guix-patches@gnu.org; Mon, 06 May 2019 12:05:02 -0400 Subject: [bug#35318] [PATCH] Update cargo-build-system to expand package inputs Resent-Message-ID: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Ivan Petkov In-Reply-To: <87ftpsnhal.fsf@gnu.org> Date: Mon, 6 May 2019 09:04:32 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <2C03880B-F90E-4949-9637-DC918B6D40A0@gmail.com> References: <87ftpsnhal.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35318@debbugs.gnu.org, Chris Marusich Hi Ludo, > On May 6, 2019, at 1:00 AM, Ludovic Court=C3=A8s wrote: >=20 > There=E2=80=99s nothing written in terms of =E2=80=9Cdependencies=E2=80=9D= ; instead everything > is written in terms of =E2=80=9Cinputs=E2=80=9D, so I=E2=80=99d like = to remain consistent here. I admit, I wasn=E2=80=99t feeling very inspired with coming up with a = name, but I wanted to avoid confusing it with the existing package-transitive-inputs = procedure. > If we need something more specific, I=E2=80=99d rather see it as a = private > procedure in (guix build-system cargo-build-system). I wanted to reuse the core traversal/memoization that was defined in the=20= original package-transitive-inputs procedure, but I can fork the = implementation as a private procedure in the cargo-build-system for now. > I=E2=80=99m not sure I want to know the details :-), but it seems to = be what > =E2=80=98package-transitive-inputs=E2=80=99 does, no? package-transitive-inputs captures all transitive propagated-inputs, but = the cargo-build-system needs all transitive propagated-inputs and regular = inputs as well (modeling cargo dependencies as propagated-inputs does not seem appropriate). Thanks, =E2=80=94Ivan=