From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54228) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoQAK-0001HD-AG for guix-patches@gnu.org; Fri, 19 Jul 2019 06:31:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoQAI-0001Be-P6 for guix-patches@gnu.org; Fri, 19 Jul 2019 06:31:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hoQAI-0001Ap-6v for guix-patches@gnu.org; Fri, 19 Jul 2019 06:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hoQAH-0008BW-W2 for guix-patches@gnu.org; Fri, 19 Jul 2019 06:31:02 -0400 Subject: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme. Resent-Message-ID: Message-ID: <29622ca8a83facccb8744c132c2b413eb63515ab.camel@autistici.org> From: Tino il Cotechino Date: Fri, 19 Jul 2019 12:30:23 +0200 In-Reply-To: <87blxsbx7x.fsf@gnu.org> References: <20190715092818.2490-1-goodoldpaul@autistici.org> <87blxsbx7x.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-Ums9xZls+T/TUANLzgBH" Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 36658@debbugs.gnu.org --=-Ums9xZls+T/TUANLzgBH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello, I'm not sure why but I was convinced that guix import would run guix lint on the generated package, so I didn't even try to run it. I'll pay more attention next time. The attached patch should fix all previous problems. Thank you for your review! Giacomo On Wed, 2019-07-17 at 15:35 +0200, Ludovic Courtès wrote: > Hello, > > Giacomo Leidi skribis: > > > * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable. > > Thanks for this patch! Below are a couple of suggestions. > > > +(define-public emacs-zerodark-theme > > + (package > > + (name "emacs-zerodark-theme") > > ^ > The indentation is off here (you can do M-q to fix it if you use > paredit). > > > + (version "20190528.923") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "https://melpa.org/packages/zerodark-theme-" > > + version > > + ".el")) > > This URL is unstable: the file will be modified in place regularly. > Consequently, could you instead use the upstream Git repository URL > along with the ‘git-fetch’ method? > > > + (synopsis > > + "A dark, medium contrast theme for Emacs") > > ^ > Please remove “A”, as suggested by ‘guix lint’. > > > + (description > > + "A dark theme inspired from One Dark and Niflheim. > > Please write a full sentence (info "(guix) Synopses and > Descriptions"). > > > +An optional mode-line format can be enabled with 'zerodark-setup- > > modeline-format'.") > > ^ > Please use @code as suggested by ‘guix lint’. > > Could you send an updated patch? > > Thanks! > > Ludo’. --=-Ums9xZls+T/TUANLzgBH Content-Disposition: attachment; filename="0001-gnu-Add-emacs-zerodark-theme.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-emacs-zerodark-theme.patch"; charset="UTF-8" RnJvbSAzOTJiM2E3YzM0MTk4ZjQ3ZjE5ZmI2YjY3ODY2Mjk3MWFhOGEzNzFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2ku b3JnPgpEYXRlOiBNb24sIDE1IEp1bCAyMDE5IDExOjIxOjI0ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgZW1hY3MtemVyb2RhcmstdGhlbWUuCgoqIGdudS9wYWNrYWdlcy9lbWFjcy14 eXouc2NtIChlbWFjcy16ZXJvZGFyay10aGVtZSk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFj a2FnZXMvZW1hY3MteHl6LnNjbSB8IDI3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv ZW1hY3MteHl6LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IDQ3ZWRiYWVl YjYuLmZlNGMzYTZjZDQgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisr KyBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC00OSw2ICs0OSw3IEBACiA7OzsgQ29w eXJpZ2h0IMKpIDIwMTkgTGFGcmVuaWVyZSwgSm9zZXBoIDxqb3NlcGhAbGFmcmVuaWVyZS54eXo+ CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgQW1hciBTaW5naCA8bmx5QGRpc3Jvb3Qub3JnPgogOzs7 IENvcHlyaWdodCDCqSAyMDE5IEJhcHRpc3RlIFN0cmF6enVsbGEgPGJzdHJhenp1bGxAaG90bWFp bC5mcj4KKzs7OyBDb3B5cmlnaHQgwqkgMjAxOSBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBh dXRpdGljaS5vcmc+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7 OwpAQCAtMTY1NjQsMyArMTY1NjUsMjkgQEAgZGlyZWN0b3JpZXMsIGRpcmVjdCB2aXN1YWxpc2F0 aW9uIG9mIGltYWdlIGZpbGVzLCBqdW1waW5nIGRpcmVjdGx5IHRvIGxpbmtzIGJ5CiBuYW1lICh3 aXRoIGF1dG9jb21wbGV0aW9uKSwgYSBzaW1wbGUgYm9va21hcmsgbWFuYWdlbWVudCBzeXN0ZW0g YW5kCiBjb25uZWN0aW9ucyB1c2luZyBUTFMgZW5jcnlwdGlvbi4iKQogICAgIChsaWNlbnNlIGxp Y2Vuc2U6Z3BsMyspKSkKKworKGRlZmluZS1wdWJsaWMgZW1hY3MtemVyb2RhcmstdGhlbWUKKyAg KHBhY2thZ2UKKyAgICAobmFtZSAiZW1hY3MtemVyb2RhcmstdGhlbWUiKQorICAgICh2ZXJzaW9u ICI0LjUiKQorICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgZ2l0LWZl dGNoKQorICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAodXJsICJodHRw czovL2dpdGxhYi5wZXR0b24uZnIvbmljby96ZXJvZGFyay10aGVtZS5naXQiKQorICAgICAgICAg ICAgIChjb21taXQgdmVyc2lvbikpKQorICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUg bmFtZSB2ZXJzaW9uKSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAgICAgICAg ICIwbm5seHpzbWhzYnN6cWlnY3l4YWs5aTFhMGRpZ3JkMTNndjZ2MThjazRoNzYwbWloaDFtIikp KSkKKyAgICAoYnVpbGQtc3lzdGVtIGVtYWNzLWJ1aWxkLXN5c3RlbSkKKyAgICAocHJvcGFnYXRl ZC1pbnB1dHMKKyAgICAgYCgoImVtYWNzLWFsbC10aGUtaWNvbnMiICxlbWFjcy1hbGwtdGhlLWlj b25zKSkpCisgICAgKGhvbWUtcGFnZQorICAgICAiaHR0cHM6Ly9naXRsYWIucGV0dG9uLmZyL25p Y28vemVyb2RhcmstdGhlbWUiKQorICAgIChzeW5vcHNpcworICAgICAiRGFyaywgbWVkaXVtIGNv bnRyYXN0IHRoZW1lIGZvciBFbWFjcyIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJaZXJvZGFy ayBpcyBhIGRhcmsgdGhlbWUgaW5zcGlyZWQgZnJvbSBPbmUgRGFyayBhbmQgTmlmbGhlaW0uCitB biBvcHRpb25hbCBtb2RlLWxpbmUgZm9ybWF0IGNhbiBiZSBlbmFibGVkIHdpdGggQGNvZGV7emVy b2Rhcmstc2V0dXAtbW9kZWxpbmUtZm9ybWF0fS4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3Bs MyspKSkKLS0gCjIuMjIuMAoK --=-Ums9xZls+T/TUANLzgBH--