From: mirai@makinata.eu
To: 59860@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>
Subject: [bug#59860] [PATCH 2/2] services: opensmtpd: Add shepherd-requirement field.
Date: Tue, 6 Dec 2022 16:52:10 +0000 [thread overview]
Message-ID: <29568421ebb18d7a157d817242262ec6f68bb7bb.1670345034.git.mirai@makinata.eu> (raw)
In-Reply-To: <cover.1670345034.git.mirai@makinata.eu>
From: Bruno Victal <mirai@makinata.eu>
---
doc/guix.texi | 5 +++++
gnu/services/mail.scm | 7 +++++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index a79b777826..4cf60d7114 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25730,6 +25730,11 @@ Data type representing the configuration of opensmtpd.
@item @code{package} (default: @var{opensmtpd})
Package object of the OpenSMTPD SMTP server.
+@item @code{shepherd-requirement} (default: @code{'()})
+This option can be used to provide a list of symbols naming Shepherd services
+that this service will depend on, such as @code{'networking}
+if you want to configure OpenSMTPD to listen on non-loopback interfaces.
+
@item @code{config-file} (default: @code{%default-opensmtpd-config-file})
File-like object of the OpenSMTPD configuration file to use. By default
it listens on the loopback network interface, and allows for mail from
diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm
index dc4a7986b6..6f588679b1 100644
--- a/gnu/services/mail.scm
+++ b/gnu/services/mail.scm
@@ -1651,6 +1651,8 @@ (define-record-type* <opensmtpd-configuration>
opensmtpd-configuration?
(package opensmtpd-configuration-package
(default opensmtpd))
+ (shepherd-requirement opensmtpd-configuration-shepherd-requirement
+ (default '())) ; list of symbols
(config-file opensmtpd-configuration-config-file
(default %default-opensmtpd-config-file))
(setgid-commands? opensmtpd-setgid-commands? (default #t)))
@@ -1667,10 +1669,11 @@ (define %default-opensmtpd-config-file
"))
(define (opensmtpd-shepherd-service config)
- (match-record config <opensmtpd-configuration> (package config-file)
+ (match-record config <opensmtpd-configuration>
+ (package config-file shepherd-requirement)
(list (shepherd-service
(provision '(smtpd))
- (requirement '(loopback))
+ (requirement `(loopback ,@shepherd-requirement))
(documentation "Run the OpenSMTPD daemon.")
(start (let ((smtpd (file-append package "/sbin/smtpd")))
#~(make-forkexec-constructor
--
2.38.1
prev parent reply other threads:[~2022-12-06 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 16:50 [bug#59860] [PATCH 0/2] Add shepherd-requirement field to OpenSMTPD mirai
2022-12-06 16:52 ` [bug#59860] [PATCH 1/2] services: opensmtpd: Use 'match-record' instead of 'match' mirai
2022-12-06 16:52 ` mirai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29568421ebb18d7a157d817242262ec6f68bb7bb.1670345034.git.mirai@makinata.eu \
--to=mirai@makinata.eu \
--cc=59860@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).