From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2MkPK+HpLmBqeQAA0tVLHw (envelope-from ) for ; Thu, 18 Feb 2021 22:27:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SNEAJ+HpLmBYGwAA1q6Kng (envelope-from ) for ; Thu, 18 Feb 2021 22:27:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7690C15E16 for ; Thu, 18 Feb 2021 23:27:45 +0100 (CET) Received: from localhost ([::1]:42698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCrlw-0002tN-Iz for larch@yhetil.org; Thu, 18 Feb 2021 17:27:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCrlG-0002tB-Rt for guix-patches@gnu.org; Thu, 18 Feb 2021 17:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCrlG-0005Ft-JZ for guix-patches@gnu.org; Thu, 18 Feb 2021 17:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCrlG-0001OH-Fh for guix-patches@gnu.org; Thu, 18 Feb 2021 17:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45889] Nextcloud Client (v10) Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 Feb 2021 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45889@debbugs.gnu.org Received: via spool by 45889-submit@debbugs.gnu.org id=B45889.16136871975301 (code B ref 45889); Thu, 18 Feb 2021 22:27:02 +0000 Received: (at 45889) by debbugs.gnu.org; 18 Feb 2021 22:26:37 +0000 Received: from localhost ([127.0.0.1]:48346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCrkr-0001NR-El for submit@debbugs.gnu.org; Thu, 18 Feb 2021 17:26:37 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:65387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCrkp-0001NE-E1 for 45889@debbugs.gnu.org; Thu, 18 Feb 2021 17:26:36 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DhTnz1TqDz3wLw; Thu, 18 Feb 2021 23:26:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1613687191; bh=QUv+5H4fGPBdzevCSB7VvfC4jbberIoO99e1xF6NsNo=; h=Subject:From:To:Date:In-Reply-To:References; b=nEX+ftvDcVU5+jTDddw0XRVJSAhctXYgeMGkkuE6cU3ed9HPQOe8LieO7355oVvID v2K0ZIyk2YBiZw3xjCD45vD5JKDxcwc/xgDcL6GDtGsEIoQU1p6C83pGy76P247cvx U0NSyQ6ZF7ixE7pBlEaj0kILYxtZl1yqgGABp+gI= Message-ID: <29553b60ceb47530cd0bda7f84badb80b8daab74.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 18 Feb 2021 23:26:30 +0100 In-Reply-To: <67f2ff73-c6e0-743f-d873-0a488fa05e31@raghavgururajan.name> References: <609483b4-c583-cbf0-4b2a-4daf6c4feb98@raghavgururajan.name> <8b239920351c99a887835c98fd9a3892b9cfd0f5.camel@student.tugraz.at> <3c07544c-97fe-88b1-2e80-ec5cfb87d4ec@raghavgururajan.name> <73f0495c29ee82c2a16a96cc2825f19bd88b4ab4.camel@student.tugraz.at> <8f88bef4-cf4d-5bcc-e0bb-979dc0ce1efd@raghavgururajan.name> <67f2ff73-c6e0-743f-d873-0a488fa05e31@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 7690C15E16 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: xZIkKpTtAyUj Hi Raghav! Am Donnerstag, den 18.02.2021, 15:23 -0500 schrieb Raghav Gururajan: > Hi Leo! > > > Interesting. Is this due to CMakeLists picking up, that they're > > missing and not replacing them with core stuff? > > > > Perhaps you can patch the CMakeLists to add such support? > > Alternatively, you might want to delete them and unpack the > > upstream > > ones to their locations. > > I have asked upstream and they are looking into providing options to > use > distribution packages. > https://github.com/nextcloud/desktop/issues/2929#issuecomment-780548919 Good to know. > So once they update the source in the next-release, I will update > the > package and remove the 3rdparty directory completely. :-) In the meantime, would you mind packaging those 3rdparty sources from their respective origins and add them in at build time? That way, all we'd need to transition from pseudo-unbundled to actually unbundled would be to drop one phase. > > Note, that you're missing a space here. This would also match > > PKGCONFIG_GETVAR(pkg var foobar_install_dir). > > Changed in v10. LGTM. Regards, Leo