From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eA84DpUAvl7BQgAA0tVLHw (envelope-from ) for ; Fri, 15 May 2020 02:38:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cNINCpUAvl7WKwAA1q6Kng (envelope-from ) for ; Fri, 15 May 2020 02:38:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6CC7C9402D1 for ; Fri, 15 May 2020 02:38:12 +0000 (UTC) Received: from localhost ([::1]:42414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZQEk-0004mf-2i for larch@yhetil.org; Thu, 14 May 2020 22:38:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZQEd-0004mT-FM for guix-patches@gnu.org; Thu, 14 May 2020 22:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZQEc-0007Dn-GX for guix-patches@gnu.org; Thu, 14 May 2020 22:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZQEc-0008BF-F5 for guix-patches@gnu.org; Thu, 14 May 2020 22:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41226] gnu: Add bombadillo. Resent-From: x@wilsonb.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 May 2020 02:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41226 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Efraim Flashner Cc: 41226@debbugs.gnu.org Received: via spool by 41226-submit@debbugs.gnu.org id=B41226.158951026931403 (code B ref 41226); Fri, 15 May 2020 02:38:02 +0000 Received: (at 41226) by debbugs.gnu.org; 15 May 2020 02:37:49 +0000 Received: from localhost ([127.0.0.1]:35432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZQEJ-0008AF-2M for submit@debbugs.gnu.org; Thu, 14 May 2020 22:37:48 -0400 Received: from m42-5.mailgun.net ([69.72.42.5]:45743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZQEE-00089b-4P for 41226@debbugs.gnu.org; Thu, 14 May 2020 22:37:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com; q=dns/txt; s=krs; t=1589510260; h=Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From: Subject: From: Cc: To: Date: Sender; bh=3WCLhP+Y8x8UO8nud5FkkjfmHjEK4ypYe7w1MiaK5FY=; b=aLvYDw/ts8Xb1VKr4vFZdzLNvPj14mAHnXmj+mn0//3/hf3W+0Y1HoFs6sqw2NSs5WCTkZQW wNquMJylSHP6IYS0OLioWRyTgCssK8TY0GiQ52rFAn1TC7aAVb+J+kQo6lC7T/yjWEouPxiI ksfW0I20p7RwzkcKVGfCv+cX2bPwAm7yIHSBK4wLlrpS+ibVDlv5DZ8bijl6NUVEeT7qbAkw DxXJOPRts/Ds/VxqK/+2J8woKQZuwe26AvSGkkajYRyOSVjUP9EeBgfr7t1YTGdZz3YkS922 ydZEEbnW/r8p04PuB+q349AsHE5jzecfM/za6xTbNj0IfQvymTcMfw== X-Mailgun-Sending-Ip: 69.72.42.5 X-Mailgun-Sid: WyIwYTQ0MSIsICI0MTIyNkBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0= Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5ebe005d75dd50406ef49e0c (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Fri, 15 May 2020 02:37:17 GMT Received: from localhost (KD111239204120.au-net.ne.jp [111.239.204.120]) by wilsonb.com (Postfix) with ESMTPSA id CF402A137A; Fri, 15 May 2020 02:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com; s=201703; t=1589510234; bh=3WCLhP+Y8x8UO8nud5FkkjfmHjEK4ypYe7w1MiaK5FY=; h=Date:To:Cc:From:Subject:From:References:In-Reply-To:From; b=B+lbRCcv420gNwT2lvOhlahsSm82VRLKmutMH8e9GpLqs0e/LIAMwYuInKgAdaSdI gnI4iClp0SFmuBdAB99rdb9o3QA25uzEwAj9NtSv5otZh7QsxkMCBhPF7kVrjDhUjq jrCLvor3c9HQUFQ4VC6y2+BcCUa9JsXvlCFaqu8Z2JotNiBCMJeIBrdHAAGKtOokLU 0+Aa6npD11kcb5DY0a8KN+vieFH3rEcRgi72Vuxn32ofXys+lvtD60brei0NNTa8s4 xVCcjDUZStRg41j9Brl2M/8j3GuBu8ZQjJZ9XcOIKa6WsfJM2/grsX/KfzSEy6fds0 denx3SGQNzeuVs6N2h7Ua4pXXCEkq4o1YKtQr8aUR8169kPM8a1+1MxjOWhG1rZaTz EiE5cZaXSGkJ0pmJcpkKW5Xq+NruuPtPM1IWWQI4goV4VxEEDcYHQ5nNq2vbqcWsyi Xbn19i16mj88N4sK3wC8WudFC8AgIy1Rcoo1xxq5HYMiSd0b5ysjjpOQJJ68iyfHRF 7FlNyRzrDzcN92FlrWwM0BSWeHW+9lsWXJrgzt8LG9ijLc5/Q6o8yjf+ezIUG96kTo eh/LE3CyC/5UMeKjFjFLFVMZkJkZJb+BzETRLz9yagbzakeJQyExYiOYVTkV6YrG+V ugHOws5d4t+ycNtm5Htu4ZBM= Date: Fri, 15 May 2020 11:37:05 +0900 References: <31A6UJLD6OH4K.216PBSDR1OKVC@wilsonb.com> <38L6JFGGT7FFA.2BDMELJ0UOT4P@wilsonb.com> <20200513185602.GG918@E5400> In-Reply-To: <20200513185602.GG918@E5400> Message-Id: <28XNXCZEZJZX1.28FFVMDIKTMT6@wilsonb.com> User-Agent: mblaze/0.5.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="----_=_52458c17760479e13e23a173_=_" X-Spam-Score: 2.0 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 1.0 (+) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: elaexuotee@wilsonb.com, elaexuotee--- via Guix-patches From: elaexuotee--- via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=mg.wilsonb.com header.s=krs header.b=aLvYDw/t; dkim=fail (rsa verify failed) header.d=wilsonb.com header.s=201703 header.b=B+lbRCcv; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: LauWy+oEAEZp This is a multipart message in MIME format. ------_=_52458c17760479e13e23a173_=_ MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_47590f86199807fa1dd4029d_=_" This is a multipart message in MIME format. ------_=_47590f86199807fa1dd4029d_=_ Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for taking a look, Efraim. > 'guix lint' didn't catch this, but I'm pretty sure that this is an > auto-generated tarball and you should use git-fetch to download the > source instead. This sounded surprising to me, so I asked about it on the irc channel. For posterity, here is a summary of that discussion: I naively would figure that url-fetch on release tarballs is preferable to = a git-fetch on the associated commit, since the tarball likely contains thing= s like autoconf output etc.=20 On the channel, bricewge mentioned that this discussion just recently came = up: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00224.html. The consensus seems to be that neither git-fetch nor url-fetch can be recommend= ed as preferable across the board. That said, rekado also mentioned that GitHub has non-deterministically regenerated tars in the past, causing problems, so I did go with git-fetch = in the updated patch. > Assuming nothing needs this to build another package, you can add > '#:install-source? #f' to the arguments. Done. > You actually don't need to gzip the man-page, it happens automatically > as part of the build process. Also, I noticed that there's a .desktop > file and a license file. Both of those can be installed. This gave me a bit of grief. The source contains a makefile with an install= target that takes care of these files, but for some reason this was giving = me non-determinism problems. Anyway, I just went ahead and installed these "da= ta" files manually. > Other than those small things it looks good. Can you send an updated > patch? Here you go! ------_=_47590f86199807fa1dd4029d_=_ Content-Disposition: attachment; filename=0001-gnu-Add-bombadillo.patch Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable =46rom 954f46513fbb6f7b06645e8434021be03778cecd Mon Sep 17 00:00:00 2001 =46rom: "B. Wilson" =44ate: Wed, 13 May 2020 13:51:19 +0900 =53ubject: [PATCH] gnu: Add bombadillo. =54o: guix-patches@gnu.org =0Agnu/packages/web-browsers.scm (bombadillo): New variable. =2D-- =20gnu/packages/web-browsers.scm | 46 ++++++++++++++++++++++++++++++++++- =201 file changed, 45 insertions(+), 1 deletion(-) =0Adiff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.s= =63m =69ndex 62b7a5bdca..269754f37a 100644 =2D-- a/gnu/packages/web-browsers.scm =2B++ b/gnu/packages/web-browsers.scm =40@ -11,6 +11,7 @@ =20;;; Copyright =C2=A9 2019 Cl=C3=A9ment Lassieur =20;;; Copyright =C2=A9 2019 Brett Gilio =20;;; Copyright =C2=A9 2020 Raghav Gururajan = =0A+;;; Copyright =C2=A9 2020 B. Wilson =20;;; =20;;; This file is part of GNU Guix. =20;;; =40@ -66,7 +67,8 @@ =20 #:use-module (guix build-system gnu) =20 #:use-module (guix build-system glib-or-gtk) =20 #:use-module (guix build-system python) =2D #:use-module (guix build-system asdf)) =2B #:use-module (guix build-system asdf) =2B #:use-module (guix build-system go)) =20= =20(define-public midori =20 (package =40@ -692,3 +694,45 @@ key-bindings and is fully configurable and extensibl= =65 in Common Lisp.") =20= =20(define-public sbcl-next =20 (deprecated-package "sbcl-next" next)) =2B =2B(define-public bombadillo =2B (package =2B (name "bombadillo") =2B (version "2.2.0") =2B (source (origin =2B (method git-fetch) =2B (uri (git-reference =2B (url "https://tildegit.org/sloum/bombadillo") =2B (commit "61ae2859bf7be4c586e6cb82097bef7cbbb1691f"))= =29 =2B (sha256 =2B (base32 =2B "1m52b1wk48gkqmjy8l0x3jaksrx2v8w6w59lhr7zaw2i0n4f5k0z"))= =0A+ (file-name (git-file-name name version)))) =2B (build-system go-build-system) =2B (arguments =2B `(#:import-path "tildegit.org/sloum/bombadillo" =2B #:install-source? #f =2B #:phases (modify-phases %standard-phases =2B (add-after 'install 'install-data =2B (lambda _ =2B (let* ((builddir "src/tildegit.org/sloum/bombadill= =6F") =2B (pkg (strip-store-file-name %output)) =2B (sharedir (string-append %output "/share"))= =0A+ (appdir (string-append sharedir "/applicat= =69ons")) =2B (docdir (string-append sharedir "/doc/" pkg= =29) =2B (mandir (string-append sharedir "/man/man1"= =29) =2B (pixdir (string-append sharedir "/pixmaps")= =29) =2B (with-directory-excursion builddir =2B (install-file "bombadillo.desktop" appdir) =2B (install-file "LICENSE" docdir) =2B (install-file "bombadillo.1" mandir) =2B (install-file "bombadillo-icon.png" pixdir) =2B #t))))))) =2B (home-page "http://bombadillo.colorfield.space") =2B (synopsis "Terminal browser for the gopher, gemini, and finger proto= =63ols") =2B (description "Bombadillo is a non-web browser for the terminal with =2Bvim-like key bindings, a document pager, configurable settings, and robu= =73t =2Bcommand selection. The following protocols are supported as first-class= =0A+citizens: gopher, gemini, finger, and local. There is also support for= =20telnet, =2Bhttp, and https via third-party applications.") =2B (license license:gpl3+))) =2D-=20 =32.26.2 =0A= ------_=_47590f86199807fa1dd4029d_=_-- ------_=_52458c17760479e13e23a173_=_ Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQQ7FdZn/PDWvxE6cmR2pStZ7i7CgQUCXr4ASRccZWxhZXh1b3Rl ZUB3aWxzb25iLmNvbQAKCRB2pStZ7i7CgV9eAQCB3D94f12YaBBWgVH550OFjZ9/ sQAZDQLykGy5K4yX8QEA+APVuhvU0u/KaEcl3zJkG3LQhWle958Y/8pISbLukQw= =Rnir -----END PGP SIGNATURE----- ------_=_52458c17760479e13e23a173_=_--