Thanks for taking a look, Efraim. > 'guix lint' didn't catch this, but I'm pretty sure that this is an > auto-generated tarball and you should use git-fetch to download the > source instead. This sounded surprising to me, so I asked about it on the irc channel. For posterity, here is a summary of that discussion: I naively would figure that url-fetch on release tarballs is preferable to a git-fetch on the associated commit, since the tarball likely contains things like autoconf output etc. On the channel, bricewge mentioned that this discussion just recently came up: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00224.html. The consensus seems to be that neither git-fetch nor url-fetch can be recommended as preferable across the board. That said, rekado also mentioned that GitHub has non-deterministically regenerated tars in the past, causing problems, so I did go with git-fetch in the updated patch. > Assuming nothing needs this to build another package, you can add > '#:install-source? #f' to the arguments. Done. > You actually don't need to gzip the man-page, it happens automatically > as part of the build process. Also, I noticed that there's a .desktop > file and a license file. Both of those can be installed. This gave me a bit of grief. The source contains a makefile with an install target that takes care of these files, but for some reason this was giving me non-determinism problems. Anyway, I just went ahead and installed these "data" files manually. > Other than those small things it looks good. Can you send an updated > patch? Here you go!