From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QApvN+Z0eWLdYQEAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 22:09:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SE6hNuZ0eWItYgAAG6o9tA (envelope-from ) for ; Mon, 09 May 2022 22:09:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91B2029798 for ; Mon, 9 May 2022 22:09:10 +0200 (CEST) Received: from localhost ([::1]:57962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no9gr-0005r6-EX for larch@yhetil.org; Mon, 09 May 2022 16:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no9gk-0005qr-Kl for guix-patches@gnu.org; Mon, 09 May 2022 16:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no9gk-0006Zq-CG for guix-patches@gnu.org; Mon, 09 May 2022 16:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no9gk-0006rv-6P for guix-patches@gnu.org; Mon, 09 May 2022 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55242 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 55242@debbugs.gnu.org Received: via spool by 55242-submit@debbugs.gnu.org id=B55242.165212689926335 (code B ref 55242); Mon, 09 May 2022 20:09:02 +0000 Received: (at 55242) by debbugs.gnu.org; 9 May 2022 20:08:19 +0000 Received: from localhost ([127.0.0.1]:59543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no9g3-0006qh-Bp for submit@debbugs.gnu.org; Mon, 09 May 2022 16:08:19 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:39388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no9g1-0006qY-OX for 55242@debbugs.gnu.org; Mon, 09 May 2022 16:08:18 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id Uk8F2700L4UW6Th01k8Feg; Mon, 09 May 2022 22:08:16 +0200 Message-ID: <280a5bda16d7f580b6b8c46a00bc81101bcabb53.camel@telenet.be> From: Maxime Devos Date: Mon, 09 May 2022 22:08:11 +0200 In-Reply-To: <5BVwkhUhKpe_HOgy_US9e5QdB8dwxw3ED31P1VUezGdevXB90Ea2-eh6s2iaiTfMpwITHe5Z-2BVNn5vHGcejoNCe3pkWP2bRWA9QRFmEhY=@lendvai.name> References: <20220503114301.9524-2-attila@lendvai.name> <20220503114301.9524-7-attila@lendvai.name> <7974a00256e3ee153507f77d6b0a405473e9bbc4.camel@telenet.be> <76510182d505978ad41f5bff88bf7eee7c289558.camel@telenet.be> <91eb2af9b86d2491c9e9f9010b9e3cb2d05dd253.camel@telenet.be> <5BVwkhUhKpe_HOgy_US9e5QdB8dwxw3ED31P1VUezGdevXB90Ea2-eh6s2iaiTfMpwITHe5Z-2BVNn5vHGcejoNCe3pkWP2bRWA9QRFmEhY=@lendvai.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0awZQJapcUxiDzu1NqYY" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652126896; bh=irND4L6yjE9itJqLLhO3Ww+Amx4cndmQvPqv/z7CAjw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=TF8kI405cT47qd16CyDpfz1SsaiTCmlOKNbivklTysIHnoU09viZdjkew0GOVavyz 4mHRw5kLTm0sAw2VGoOM0vTSG6+y6XmMRojA21ng/0/uMdy3sYSEOsON+rylWxSskv rwPPSMHpISBxmeFLKaWxtE5LeDW2qXHiOYn62rhF6WGai03CfmlLYpNDuuTiOiE5zc F+lMmehscLpI+QFUkEgtt6hWf7PD3ltYZ+uz4jdzvX1No4PEklho24B7zcx9wcLy9/ Le8KJt7nV5ic3gibKcYQUQgPbi1Q2LLKOt8ScC9wzAmT3l9cM+1I+0B/YdN7fly3S3 HfBKY/SDcHNXw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652126950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=irND4L6yjE9itJqLLhO3Ww+Amx4cndmQvPqv/z7CAjw=; b=jyWP6DlOUwFWRVjjrew+n2pxzoj95dQAoKrLzpt7lpEE8e/LmOC4N0/Uoi1wCP2fXvYZYp kxDCYOuaB2qwnNoc8cjGmzc/54Yf5W+Ln4DsVtRPzEyqAFb/P/5mSJuCiH32dWzhJ02OSF s3mI56PkCVdJS1aHjKjkUK0NExXXJOx9UEni5UirTApjlB3kQClGTsxz1gGUHW3BweJ9yD pV53zsQVNJg2E4iu+pFdea+pjLnzIC/RSfQsOVOsmwy4+9pXQ7WZrwWJBuMBLgfXK8AjEI GBKGRt6Vokj2V1ototo6xT01FpZ8Th7v1/S8Lfaq9JRGeFXp85uUpxpraENzSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652126950; a=rsa-sha256; cv=none; b=Lwk5goRpOyzcHClIPMKtI4TXKYiwpeWlkQ73OC0aiW55eojq7BPCZr+UZR//a5hJPZYsnQ s46Dcvc+WwfXWThgsc82Rkq2pDLK3bayBYXLs7IrIbQwFofU+I447TOo/2uidIgcyUHnQn hgVddFPp9YuHpnFxzYoVXjWSGWzR7NSQpANKxt2OwXhcR8x6jVRKAHD4r+VnS2l4YZodDw WGVclN8Lu0adRVena6q1AkkyzTKLI117VJyxA+j4s4RvNu3Vn4u3rzSmfB3FiHDFwleFE1 et07BKFbP3TKVTiK7HeWbENrsHgtbLMyP9KvpEs9SD0AzuqOkJ2M198FUKyuZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=TF8kI405; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=TF8kI405; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 91B2029798 X-Spam-Score: 3.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: pVyTPZjKHTPq --=-0awZQJapcUxiDzu1NqYY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op ma 09-05-2022 om 20:02 [+0000]: > note that this patch does not just catch errors, but handles them by emit= ting useful information about them, and continues only after that. I think such errors are easily overlooked, but yes, and I don't have any actual data on that. > i consider silently swallowing errors a major sin (read: code that will c= ertainly eat up some portion of someone's life in the future). >=20 > the only place where this patch silently swallows errors is in the extrac= tion of descriprions and such, i.e. data that the user must review anyway. > [...] I think I've overstated the =E2=80=98swallows errors etc.=E2=80=99 a bit, g= iven that if "guix import go --recursive " skips a package , then the user will have to package its dependency anyway, and for that the user could first try "guix import go " (reporting errors on bug-guix@ or #guix) before fixing/extending the importer or doing things manually. Greetings, Maxime. --=-0awZQJapcUxiDzu1NqYY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnl0qxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kE+AP9odJkKelOQoXG/LUrX1wmWq+Y+ ZlYW1gXLuAI+B5EzQQD/fazvlplYuXCk2xIFz0YsQCU2MENe0Vr5p0GajoJJRwE= =y67O -----END PGP SIGNATURE----- --=-0awZQJapcUxiDzu1NqYY--