unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Rutherther via Guix-patches via <guix-patches@gnu.org>
To: 74405@debbugs.gnu.org
Cc: Rutherther <rutherther@ditigal.xyz>,
	Julien Lepiller <julien@lepiller.eu>
Subject: [bug#74405] [PATCH 1/1] gnu: antlr4: Pass full path to java in bin executable
Date: Sun, 17 Nov 2024 20:17:01 +0100	[thread overview]
Message-ID: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@ditigal.xyz> (raw)
In-Reply-To: <cover.1731870758.git.rutherther@ditigal.xyz>

The executable outputted by antlr4 package does not
refer to full path of java, but to standalone "java".
That means the package expects java to be in PATH.
Since it's an application, requiring java to run,
it should rather refer to full path of java executable
it was built with/for.

* gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path

Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64
---
 gnu/packages/java.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index df57385ea7..8607b62bea 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -8866,13 +8866,14 @@ (define-public antlr4
          (add-after 'install 'bin-install
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
-                   (bin (string-append (assoc-ref outputs "out") "/bin")))
+                   (bin (string-append (assoc-ref outputs "out") "/bin"))
+                   (java (search-input-file inputs "bin/java")))
                (mkdir-p bin)
                (with-output-to-file (string-append bin "/antlr4")
                  (lambda _
                    (display
                      (string-append "#!" (which "sh") "\n"
-                                    "java -cp " jar "/antlr4.jar:"
+                                    java " -cp " jar "/antlr4.jar:"
                                     (string-join
                                       (apply
                                         append
-- 
2.46.0




      reply	other threads:[~2024-11-17 19:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17 19:15 [bug#74406] [PATCH 0/1] antlr4 package does not refer to java executable by full path Rutherther via Guix-patches via
2024-11-17 19:17 ` Rutherther via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@ditigal.xyz \
    --to=guix-patches@gnu.org \
    --cc=74405@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=rutherther@ditigal.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).