From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sEvIJ0S1GGSw1QAASxT56A (envelope-from ) for ; Mon, 20 Mar 2023 20:34:28 +0100 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0COyJ0S1GGSBdAEAauVa8A (envelope-from ) for ; Mon, 20 Mar 2023 20:34:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 74AC137D28 for ; Mon, 20 Mar 2023 20:34:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peLGh-0002cP-4D; Mon, 20 Mar 2023 15:34:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peLGc-0002bz-Q7 for guix-patches@gnu.org; Mon, 20 Mar 2023 15:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peLGc-00008U-Hy for guix-patches@gnu.org; Mon, 20 Mar 2023 15:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peLGb-0003Hq-Ut for guix-patches@gnu.org; Mon, 20 Mar 2023 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-group) for user (resp. group) fields. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , 62298@debbugs.gnu.org Cc: ludo@gnu.org, maxim.cournoyer@gmail.com Received: via spool by 62298-submit@debbugs.gnu.org id=B62298.167934079512567 (code B ref 62298); Mon, 20 Mar 2023 19:34:01 +0000 Received: (at 62298) by debbugs.gnu.org; 20 Mar 2023 19:33:15 +0000 Received: from localhost ([127.0.0.1]:56848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peLFr-0003Gd-C2 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 15:33:15 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peLFp-0003GQ-7X for 62298@debbugs.gnu.org; Mon, 20 Mar 2023 15:33:13 -0400 Received: by mail-ed1-f68.google.com with SMTP id cn12so5529558edb.4 for <62298@debbugs.gnu.org>; Mon, 20 Mar 2023 12:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679340787; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=A9LwoFZUTtk4h5N2MZuhQOWF0+EVuYR8kUlZpmqGC/4=; b=JFtKpbVcbXa8VjKrgOnMIcm7MUk+AJCgkGPQS26juN+taM0ICgN6oUk0TKYLFcLaLn 6BcjAy4+R9kBJw296KZ24Y8subKg2pLLpjzPxq7QEFwJJ1b+Tt6TpMKyFEdGoaRPza+7 A2Fpspo8Q1FpGRBIykQkUWUzkHk0kEVJ7SrGuEi3muim9Y10Jv+FaAA/wWjwPDv8oZYr hh+1DlNckdwRoeRZGAxIO1fJB3aj6d/gLp4NxqBCMEnP0XXbCJQbf9rhda8ze/50PoMv /yiiwHCgN2odR7n31T+boF4Wp5H2EMjp0sdDjKUufs0ZQrTBAJW9Lxo3/JAczyCrITGP foug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679340787; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A9LwoFZUTtk4h5N2MZuhQOWF0+EVuYR8kUlZpmqGC/4=; b=6LeVkM/b3IZBMm6Jrz/BMByP4vcsml7+wRf8+Bb6YlKAyiNv5EP2CEdSZxwm4032Fd QzmeixJ4hdhbzJmEhUwBOA6Mvi3taBJm0CTs/mJKbb/7uBy8kscnL49Z8wX2dmPN45cy 4eXCXZ7fd2oYE9o4fFnJ+d1TNaDu5LSav15HNPJpQmbMkK/GxzxOhPzZTC+i0yC3VHiz 4Sqf5zMfmJXE0pg8zmJVtRwWSOD/SAeMF+EP5WEJA6UZYLwk9cHMguS5tHdoMHoPA6Sx 4Yz1uL8DfMn58j6IaQyeEcPWqtoWpatZMLFtp/ZQrlVsqvvPbEnEHrj+jE1sc2aDwKQm mtHA== X-Gm-Message-State: AO0yUKX5L8ut/mP65r3QamU4M1LidDc4unrRWiZ5D6adw8dBzfsTMkbo TVpBh0bm5DWf0YHedkogpR8= X-Google-Smtp-Source: AK7set8Hb8r7UwhcT70iXqdgS0DxTzmBjv3gzVzyy52zZz++ORCURIFWzHIUQUzEuBDKjCNW2G0j1g== X-Received: by 2002:a17:906:4d56:b0:927:6e70:e245 with SMTP id b22-20020a1709064d5600b009276e70e245mr195873ejv.63.1679340787166; Mon, 20 Mar 2023 12:33:07 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g19-20020a17090613d300b00931db712768sm4621554ejc.4.2023.03.20.12.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 12:33:06 -0700 (PDT) Message-ID: <27ddb1989f281cee887c903955cc793fc34bd1ab.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 20 Mar 2023 20:33:05 +0100 In-Reply-To: <6e1da37de3839d56546389924ce47b4563d05d94.1679332019.git.mirai@makinata.eu> References: <6e1da37de3839d56546389924ce47b4563d05d94.1679332019.git.mirai@makinata.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679340868; a=rsa-sha256; cv=none; b=GsWdc+K1BTcGh7iGGVwKOFip/lS7nIQe5X5v4GmlCXTz2KSHwMXQGPiNOqA99EaWhOsCLf +SnS7jTFyGseuwjmh1f9yP0toN/WTkWbBVWfyBRCXxf50SUYVy8mykUfWRWVKyMp6QI9D+ Ec9JizEbGVJjw4cSQ84emjwt2oLTQVMo0vR3wVwyfMr4C0oELIdtWObINyXpaE7L+zQ4jO STzy0AcBJTZEfw/0HYEbfomBXZcLkT1ZT1csQcK7keviOadwEML0lTInxYrrDzKz5hYFYp r3sU3Qi9aHPmlgGWpFXSDXE0TnBY80qx+3nk208hnEblo70O/LOjzskq8z/IWQ== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JFtKpbVc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679340868; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=A9LwoFZUTtk4h5N2MZuhQOWF0+EVuYR8kUlZpmqGC/4=; b=VgQiILQUhFDenbALE9e4cBLoP56cpFhKdcQ2qw+qsntH9Dl0Au3DhY0Okxufzpa865K7Zq AQ9irEmxe28b3jF+3yeRMexh9t++op5nnvTlyT1pYWftpybagwqXQMPtxJYWS7uFbOF7m2 5p9c9Z1qc4AkiWOUHm52RdxZXboANK1+dg/cvxRGP/VECxBXN9JSX6Lllr88OlI5G1iyFE S3joDIu3HZkyPAxsD30TCRndS7K6EcZM5+rpHr8Zb5AGqKPAScrcLKxc3cpTYmIlaf21KA ri8ySJRQiSWJ53zn1YsPR3cEUYRGSD9+eWczFpvqa2IkSgv50UXxrsdCdPXWPg== X-Migadu-Spam-Score: 7.25 X-Spam-Score: 7.25 X-Migadu-Queue-Id: 74AC137D28 Authentication-Results: aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JFtKpbVc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: wcXj1mRFIeJA Am Montag, dem 20.03.2023 um 17:07 +0000 schrieb Bruno Victal: > Deprecate using strings for these fields and prefer user-account > (resp. user-group) instead to avoid duplication within account- > service-type. If a string value is encountered, it is ignored and a > predefined variable is used instead. This is essentially a rollback > to how it used to be before > '5c5f0fc1135ff15f9c4adfc5f27eadd9a592b5d1'. I already wrote this in private in IRC, but falling back to a constant when a string value is given is very silly. IIUC the reason to do so is because you would need to sanitize the user account and group at the same time so that the former has access to the latter. I think it's possible to use one of the following approaches to get a better result: 1. In (mpd-accounts), check if the user group equals the group name and raise a warning (or error) if not. 2. Use a special unique symbol, e.g. (make-symbol "%mpd-group") to denote the value to be lazily inserted by the serializer. Cheers