unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, 53676@debbugs.gnu.org
Subject: [bug#53676] [PATCH v2 3/4] services: pulseaudio: Add an extra-script-files configuration field.
Date: Thu, 24 Feb 2022 19:53:34 +0100	[thread overview]
Message-ID: <27655b0c24666a93d23800ee74837ea032667432.camel@telenet.be> (raw)
In-Reply-To: <20220224163828.11330-3-maxim.cournoyer@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

Maxim Cournoyer schreef op do 24-02-2022 om 11:38 [-0500]:
> +  (define (file-like->name file)
> +    (match file
> +      ((? local-file?)
> +       (local-file-name file))
> +      ((? plain-file?)
> +       (plain-file-name file))
> +      ((? computed-file?)
> +       (computed-file-name file))
> +      (_ (leave (G_ "~a is not a local-file, plain-file or \
> +computed-file object~%") file))))

This would not work with things like '(file-append ...)'.
Perhaps 'extra-script-files->file-union' can be made more general
by creating a variant of 'file-union' for this use case?
Maybe something like (untested):

;; Based on 'file-union'
(define* (file-directory . files)
  ; files: (file-like1 file-like2 ...)
  (computed-file name
                 (with-imported-modules '((guix build utils))
                   (gexp
                    (begin
                      (use-modules (guix build utils))

                      (mkdir (ungexp output))
                      (chdir (ungexp output))
                      (ungexp-splicing
                       (map (lambda (source)
                              (gexp
                               (let ((target (basename source))
                                 ;; Stat the source to abort early if it does
                                 ;; not exist.
                                 (stat (ungexp source))
                                 (symlink (ungexp source) (ungexp target)))))
                            files)))))))

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-02-24 19:03 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  4:13 [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Maxim Cournoyer
2022-02-01  4:19 ` [bug#53676] [PATCH 1/5] doc: Fix typo Maxim Cournoyer
2022-02-01  4:19   ` [bug#53676] [PATCH 2/5] services/sound: Normalize pulseaudio-configuration accessor names Maxim Cournoyer
2022-02-01 19:48     ` Liliana Marie Prikler
2022-02-01 20:18       ` Maxim Cournoyer
2022-02-01 21:29         ` Liliana Marie Prikler
2022-02-01  4:19   ` [bug#53676] [PATCH 3/5] gnu: pulseaudio: Graft to adjust configuration Maxim Cournoyer
2022-02-01 19:45     ` Liliana Marie Prikler
2022-02-01 20:20       ` Maxim Cournoyer
2022-02-01 21:37         ` Liliana Marie Prikler
2022-02-02  4:30           ` Maxim Cournoyer
2022-02-02 20:43             ` Liliana Marie Prikler
2022-02-06  6:30               ` [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Maxim Cournoyer
2022-02-06  9:07                 ` Liliana Marie Prikler
2022-02-24 16:31                   ` Maxim Cournoyer
2022-02-24 20:26                     ` Liliana Marie Prikler
2022-02-01  4:19   ` [bug#53676] [PATCH 4/5] services: pulseaudio: Add an extra-script-files configuration field Maxim Cournoyer
2022-02-01 19:56     ` Liliana Marie Prikler
2022-02-01 20:27       ` Maxim Cournoyer
2022-02-01 21:26         ` Liliana Marie Prikler
2022-02-02  3:44           ` Maxim Cournoyer
2022-02-02 20:07             ` Liliana Marie Prikler
2022-02-06  7:25               ` Maxim Cournoyer
2022-02-06  8:02                 ` Liliana Marie Prikler
2022-02-24 16:25                   ` Maxim Cournoyer
2022-02-01  4:19   ` [bug#53676] [PATCH 5/5] services: pulseaudio: Deploy the configuration files to /etc/pulse Maxim Cournoyer
2022-02-01 19:43     ` Liliana Marie Prikler
2022-02-02 22:43       ` Jack Hill
2022-02-07 22:29         ` [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Maxim Cournoyer
2022-02-08  5:21           ` Liliana Marie Prikler
2022-02-08 14:25             ` Maxim Cournoyer
2022-02-08 19:31               ` Liliana Marie Prikler
2022-02-08 14:29             ` Maxim Cournoyer
2022-02-08 10:12           ` Maxime Devos
2022-02-08 14:27             ` Maxim Cournoyer
2022-02-24 16:36               ` Maxim Cournoyer
2022-02-24 14:42         ` [bug#53676] [PATCH 5/5] services: pulseaudio: Deploy the configuration files to /etc/pulse Maxim Cournoyer
2022-02-01 19:49   ` [bug#53676] [PATCH 1/5] doc: Fix typo Liliana Marie Prikler
2022-02-01  4:24 ` [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Leo Famulari
2022-02-01 20:15   ` Maxim Cournoyer
2022-02-24 16:38 ` [bug#53676] [PATCH v2 1/4] services/sound: Normalize pulseaudio-configuration accessor names Maxim Cournoyer
2022-02-24 16:38   ` [bug#53676] [PATCH v2 2/4] gnu: pulseaudio: Graft to adjust configuration Maxim Cournoyer
2022-02-24 19:47     ` Liliana Marie Prikler
2022-02-24 22:00       ` Maxim Cournoyer
2022-02-25  5:20         ` Liliana Marie Prikler
2022-02-26  6:21           ` Maxim Cournoyer
2022-02-26 13:19             ` Liliana Marie Prikler
2022-02-26 14:14               ` bug#53676: " Maxim Cournoyer
2022-02-24 16:38   ` [bug#53676] [PATCH v2 3/4] services: pulseaudio: Add an extra-script-files configuration field Maxim Cournoyer
2022-02-24 18:53     ` Maxime Devos [this message]
2022-02-24 22:20       ` Maxim Cournoyer
2022-02-24 16:38   ` [bug#53676] [PATCH v2 4/4] services: pulseaudio: Deploy the configuration files to /etc/pulse Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27655b0c24666a93d23800ee74837ea032667432.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=53676@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).