From: Maxime Devos <maximedevos@telenet.be>
To: Paul Alesius <paul@unnservice.com>, 55055@debbugs.gnu.org
Subject: [bug#55055] [PATCH] gnu: wireguard: Add support for PresharedKey
Date: Thu, 21 Apr 2022 16:25:53 +0200 [thread overview]
Message-ID: <274c06a235949ebbdd3f90e31afea1189f207ea0.camel@telenet.be> (raw)
In-Reply-To: <CAL8jUGVj31UESVDj61D3kaYCWyPrapEzOYEAmPHwAqgN0tr6nw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Paul Alesius schreef op do 21-04-2022 om 15:26 [+0200]:
> + (preshared-key wireguard-peer-preshared-key
> + (default #f)) ;string
This should be documented in the documentation, otherwise it will be
difficult to discover. Also, #f is not a string, did you mean
‘;#f|string’?
Also, a limitation: the preshared key will end up in the store, and
hence be world-readable. So other users on the same system (other
people or compromised system daemons) could now determine the preshared
key.
Questions:
* Could the security limitation be documented?
* What security impact does a leaked secret key have?
* Does wireguard has some inclusion mechanism, such that the
wireguard configuration can ‘include’ some file outside the store?
* WDYT of verifying that the preshared key looks ‘reasonable’
(I guess only a-z0-9 characters, no spaces or newlines, not a
bytevector ...)
As-is, if I do (preshared-keys (string->utf8 "oops I thought this
needs to be bytevector)) then "guix system reconfigure" doesn't
give a nice error message, it will just silently produce a broken
configuration file.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-04-21 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 13:26 [bug#55055] [PATCH] gnu: wireguard: Add support for PresharedKey Paul Alesius
2022-04-21 14:25 ` Maxime Devos [this message]
[not found] ` <CAL8jUGUyedoy+9va2qGJR5QpXn5B6cn7dWODyBJ0kxq1HQ+GYQ@mail.gmail.com>
2022-04-21 20:41 ` [bug#55055] Fwd: " Paul Alesius
2022-04-21 21:55 ` Maxime Devos
2022-04-21 21:59 ` Maxime Devos
2022-04-21 21:48 ` Maxime Devos
2022-12-26 16:53 ` bug#55055: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274c06a235949ebbdd3f90e31afea1189f207ea0.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55055@debbugs.gnu.org \
--cc=paul@unnservice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).