unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Raghav Gururajan" <raghavgururajan@disroot.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40445@debbugs.gnu.org
Subject: [bug#40445] gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 10:28:20 +0000	[thread overview]
Message-ID: <265df2102f5ed69aa35fc059dbb4d8e5@disroot.org> (raw)
In-Reply-To: <b633146363e6944017f5aa752f577237@disroot.org>

Hi Mathieu!

>> Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
>> CCFLAGS without having to repeat all the other options that are already
>> present in the Makefile:
>> 
>> --8<---------------cut here---------------start------------->8---
>> CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
>> --8<---------------cut here---------------end--------------->8---
>> 
>> Adding a new 'add-fpic-ccflag' phase could be an option?
> 
> We can do that too. But this seems simple and less messy :-)

Also, I believe, the make-flag just overwrites that line in the source.

Regards,
RG.

  parent reply	other threads:[~2020-04-05 10:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05  7:07 [bug#40445] gnu: gsm: Update to 1.0.19 Raghav Gururajan
2020-04-05  9:40 ` Mathieu Othacehe
2020-04-05  9:45 ` Raghav Gururajan
2020-04-05 10:22   ` Mathieu Othacehe
2020-04-05 10:26   ` Raghav Gururajan
2020-04-05 10:28   ` Raghav Gururajan [this message]
2020-04-05 10:33     ` Mathieu Othacehe
2020-04-05 10:37     ` Raghav Gururajan
2020-04-05 10:52     ` Raghav Gururajan
2020-04-05 10:53     ` Raghav Gururajan
2020-04-05 17:38   ` maxim.cournoyer
2020-04-05 18:20     ` bug#40445: " maxim.cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=265df2102f5ed69aa35fc059dbb4d8e5@disroot.org \
    --to=raghavgururajan@disroot.org \
    --cc=40445@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).