From: "Tomás Ortín via Guix-patches" <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#43781] [PATCH 2/2] gnu: Add cgoban
Date: Thu, 22 Oct 2020 15:07:43 +0000 [thread overview]
Message-ID: <264BCB13-4FA2-4713-810E-2704D3E45A15@mailbox.org> (raw)
In-Reply-To: <871rhqtimt.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]
Hello,
Thank you for your feedback. I will add a comment about the tests.
About the patch: it's taken from the Gentoo package. I first tried packaging cgoban without any package and it consistently failed at configure phase, no matter the flags I passed. I decided to check the Gentoo package to see how they built it, as I have used cgoban in that distribution before and works well, and saw they just added this patch. Tried adding it, and it works. But I won't pretend to understand why.
If adding the patch is not a good solution, could someone help me figure out how to properly pack cgoban? Sorry about the inconvenience.
Tomás Ortín
On October 22, 2020 2:55:38 PM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hi,
>
>Tomás Ortín Fernández <tomasortin@mailbox.org> skribis:
>
>> Sorry, I see I should have sent it all in one email.
>>
>> * gnu/packages/games.scm (cgoban): New variable.
>
>Sorry for the delay! Some comments:
>
>> + (arguments
>> + `(#:tests? #t))
>
>Please add a short comment explaining why tests are disabled.
>
>> --- /dev/null
>> +++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
>> @@ -0,0 +1,40 @@
>> +--- a/configure.in
>> ++++ b/configure.in
>
>Patches should start with a couple lines stating the origin, their
>upstream status, and what they do.
>
>Patches also need to be listed in ‘gnu/local.mk’ and mentioned in the
>commit log.
>
>However, I suspect this patch has no effect: since ‘autoconf’ is not an
>input of the package, its ‘configure’ script cannot be rebuilt to take
>those changes into account.
>
>Perhaps you can just remove it?
>
>Could you send a second version?
>
>Thanks!
>
>Ludo’.
[-- Attachment #2: Type: text/html, Size: 2404 bytes --]
next prev parent reply other threads:[~2020-10-26 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 17:50 [bug#43781] [PATCH 0/2] gnu: Add cgoban Tomás Ortín Fernández via Guix-patches via
2020-10-03 19:05 ` [bug#43781] [PATCH 2/2] " Tomás Ortín Fernández via Guix-patches via
2020-10-22 14:55 ` Ludovic Courtès
2020-10-22 15:07 ` Tomás Ortín via Guix-patches [this message]
2020-10-26 10:44 ` Ludovic Courtès
2020-11-18 22:06 ` Ludovic Courtès
2020-11-26 8:56 ` [bug#43781] (no subject) Tomás Ortín Fernández via Guix-patches via
2020-11-29 19:19 ` bug#43781: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=264BCB13-4FA2-4713-810E-2704D3E45A15@mailbox.org \
--to=guix-patches@gnu.org \
--cc=ludo@gnu.org \
--cc=tomasortin@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).