[bug#40485] gnu: Update libxfce4ui to 4.15.2.

[bug#40485] gnu: Update libxfce4ui to 4.15.2.

[Naga Malleswari]

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

Submission of patch for updating description for libxfce4ui

-- 
Regards
NagaMalli


[-- Attachment #2: 0001-gnu-Update-libxfce4ui-to-4.15.2.patch --]
[-- Type: text/x-patch, Size: 1168 bytes --]

From 95e1a33913a13e49fe64a54222bf950dea8c54f3 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Tue, 7 Apr 2020 18:22:41 +0530
Subject: [PATCH] gnu: Update libxfce4ui to 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): Update to 4.15.2.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..d0f7da61b3 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -166,7 +166,7 @@ storage system.")
 (define-public libxfce4ui
   (package
     (name "libxfce4ui")
-    (version "4.14.1")
+    (version "4.15.2")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://archive.xfce.org/src/xfce/"
@@ -174,7 +174,7 @@ storage system.")
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1npjhznmnckhnylsv3l7p1zvhckhmp9d7vifs8w12kdfmrg0fjf4"))))
+                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
-- 
2.25.1

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

Hi Danny


 (inputs `(("libsm" ,libsm)
              ("libice" ,libice)
              ;; FIXME: required by libxfce4ui-1.pc, so should be
propagated,
              ;; but will lead to a conflict with gtk+.
              ("gtk+-2" ,gtk+-2)

I understand that xfce4-embed-plugin failed after libxfce4ui is updated
because of the conflict with the inputs. What is suggested to do.  

On 07/04/20 6:26 pm, GNU bug Tracking System wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 40485@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
-- 
Regards
NagaMalli

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Build via

  ./pre-inst-env guix build -K libxfce4ui

Check /tmp/guix-build-xfce4-embed-plugin-1.6.0.drv-*/*/config.log for libxfce4ui
and see what the surrounding lines say.

If that doesn't help,

  ./pre-inst-env guix environment --pure libxfce4ui

then

  pkg-config --cflags --libs libxfce4ui-1

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

I meant:

Build via

  ./pre-inst-env guix build -K xfce4-embed-plugin

Check /tmp/guix-build-xfce4-embed-plugin-1.6.0.drv-*/*/config.log for libxfce4ui
and see what the surrounding lines say.

If that doesn't help,

  ./pre-inst-env guix environment --pure xfce4-embed-plugin

then

   pkg-config --cflags --libs libxfce4ui-1

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Then check the directories $PKG_CONFIG_PATH for libxfce4ui* .

In this case there's a libxfce4ui-2, which means they have changed the API
version because there was an incompatible change (previously it was
libxfce4ui-1).

So update xfce4-embed-plugin as well and hope they have adapted to the API
change (if not, we'll just get an error message again).

This will probably happen for quite a few packages, so it's gonna take some
work.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

I thought of the same but

xfce4-embed-plugin version is latest in guix. (1.6.0)


I got this error:

*** The required package libxfce4ui-1 was not found on your system.
*** Please install libxfce4ui-1 (atleast version 4.8.0) or adjust
*** the PKG_CONFIG_PATH environment variable if you

On 07/04/20 7:37 pm, Danny Milosavljevic wrote:
> Then check the directories $PKG_CONFIG_PATH for libxfce4ui* .
>
> In this case there's a libxfce4ui-2, which means they have changed the API
> version because there was an incompatible change (previously it was
> libxfce4ui-1).
>
> So update xfce4-embed-plugin as well and hope they have adapted to the API
> change (if not, we'll just get an error message again).
>
> This will probably happen for quite a few packages, so it's gonna take some
> work.

-- 
Regards
NagaMalli

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Upstream (the actual author) is https://docs.xfce.org/panel-plugins/xfce4-embed-plugin 
according to our page https://guix.gnu.org/packages/xfce4-embed-plugin-1.6.0/ .

Their latest release was in 2015, so I don't think they adapted to the new libxfce4ui.

That's too bad.

There are multiple possible ways to proceed:

(1) Delete xfce4-embed-plugin, if possible (if nobody is using it and if it has
security problems anyway etc), or
(2) Keep both packages of libxfce4ui.  Use the old package for
xfce4-embed-plugin and the new package for the other dependents.

Please make sure to use ./pre-inst-env guix lint xfce4-embed-plugin libxfce4ui
(with the old unchanged version) to find out whether there are known security
problems with it.

If not, I'd prefer (2).

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

Hi

On 07/04/20 7:53 pm, Danny Milosavljevic wrote:
> (2) Keep both packages of libxfce4ui.  Use the old package for
> xfce4-embed-plugin and the new package for the other dependents.


(define-public libxfce4ui/latest
  (package
    (inherit libxfce4ui)
    (version "4.15.2")
    (source (origin
              (method url-fetch)
              (uri (string-append "https://archive.xfce.org/src/xfce/"
                                  name "/" (version-major+minor version) "/"
                                  name "-" version ".tar.bz2"))
              (sha256
               (base32
                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))


I Added this and tried. always its showing 4.15.2 not found. Unable to
trace the error.

> If not, I'd prefer (2).

-- 
Regards
NagaMalli

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

Hi Naga,

On Wed, 8 Apr 2020 00:47:16 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

> On 07/04/20 7:53 pm, Danny Milosavljevic wrote:
> > (2) Keep both packages of libxfce4ui.  Use the old package for
> > xfce4-embed-plugin and the new package for the other dependents.  
> 
> 
> (define-public libxfce4ui/latest
>   (package
>     (inherit libxfce4ui)
>     (version "4.15.2")
>     (source (origin
>               (method url-fetch)
>               (uri (string-append "https://archive.xfce.org/src/xfce/"
>                                   name "/" (version-major+minor version) "/"
>                                   name "-" version ".tar.bz2"))
>               (sha256
>                (base32
>                 "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
> 
> 
> I Added this and tried. always its showing 4.15.2 not found. Unable to
> trace the error.

That approach is good is principle.

But I'd do it the other way around--otherwise you have to update all libxfce4ui
references in all the other packages (which presumably can use the newer
version just fine).

So better rename the old libxfce4ui variable to libxfce4ui-1 and then
update the reference in xfce4-embed-plugin to use libxfce4ui-1, and
then introduce a new libxfce4ui variable with a similar body as your
libxfce4ui/latest had.

That means that everyone still referring to the libxfce4ui variable will get
the new version automatically.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Hi Naga,

On Wed, 8 Apr 2020 00:47:16 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

> (define-public libxfce4ui/latest
[...]
> 
> I Added this and tried. always its showing 4.15.2 not found. Unable to
> trace the error.

When processing which package?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

I am getting weird outputs.

I tried building two versions of help2man/latest and libuv/latest which
were build the same way and they worked perfectly fine.


I tried these

https://paste.debian.net/1139190/


CASE1:

 ./pre-inst-env guix build libxfce4ui   is building 4.14.1

./pre-inst-env guix build libxfce4ui-1           error: libxfce4ui-1: unknown package

./pre-inst-env guix build libxfce4ui@4.15.2      error: libxfce4ui-4.15.2: unknown package


CasE 2: 
 ./pre-inst-env guix build libxfce4ui   is building 4.14.1

./pre-inst-env guix build libxfce4ui@4.15.2  resulted  error: libxfce4ui-4.15.2: unknown package


Am i missing something here........... orocess which worked fine for
help2man and libuv is not working for this.



On 08/04/20 1:18 am, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Wed, 8 Apr 2020 00:47:16 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> (define-public libxfce4ui/latest
> [...]
>> I Added this and tried. always its showing 4.15.2 not found. Unable to
>> trace the error.
> When processing which package?

THis one

 ./pre-inst-env guix build xfce4ui

-- 
Regards
NagaMalli

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 5657 bytes --]

Hi Naga,

On Thu, 9 Apr 2020 01:13:34 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

> https://paste.debian.net/1139190/

Please, for archival purposes, post source code in the mailing list.  Pastebin
content will eventually vanish--and we do want to have some kind of public
record.

I'm gonna paste it here:

CASE 1:

(define-public libxfce4ui-1
  (package
    (name "libxfce4ui")
    (version "4.14.1")

(define-public libxfce4ui/latest
  (package
    (inherit libxfce4ui-1)
    (version "4.15.2")

CASE 2:
(define-public libxfce4ui
  (package
    (name "libxfce4ui")
    (version "4.14.1")


(define-public libxfce4ui/latest
  (package
    (inherit libxfce4ui)
    (version "4.15.2")
    (source (origin
              (method url-fetch)
              (uri (string-append "https://archive.xfce.org/src/xfce/"
                                  name "/" (version-major+minor version) "/"
                                  name "-" version ".tar.bz2"))
              (sha256
               (base32
                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))

> CASE1:
> 
>  ./pre-inst-env guix build libxfce4ui   is building 4.14.1

I would have expected 4.15.2--are you sure that you overwrote the field SOURCE ?

> ./pre-inst-env guix build libxfce4ui-1           error: libxfce4ui-1: unknown package

"libxfce4ui-1" is not a package's name but a variable's name.  That won't work[1].

> ./pre-inst-env guix build libxfce4ui@4.15.2      error: libxfce4ui-4.15.2: unknown package

Why is there a dash in the error message?

Should work just fine with "@".

> CasE 2: 
>  ./pre-inst-env guix build libxfce4ui   is building 4.14.1

Should build 4.15.2.

> ./pre-inst-env guix build libxfce4ui@4.15.2  resulted  error: libxfce4ui-4.15.2: unknown package

Again the dash?  Why?

it works for me:

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..ee2bba5ca1 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,9 @@ Xfce Desktop Environment.")
 storage system.")
     (license lgpl2.0+)))
 
-(define-public libxfce4ui
+;; case 1
+
+(define-public libxfce4ui-1
   (package
     (name "libxfce4ui")
     (version "4.14.1")
@@ -201,6 +203,20 @@ storage system.")
 to share commonly used Xfce widgets among the Xfce applications.")
     (license lgpl2.0+)))
 
+(define-public libxfce4ui
+  (package
+    (inherit libxfce4ui-1)
+    (name "libxfce4ui") ; not necessary but I like it for no reason
+    (version "4.15.2")
+    (source (origin ; necessary block!!
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/xfce/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
 (define-public exo
   (package
     (name "exo")

$ ./pre-inst-env guix build libxfce4ui@4.14.1
/gnu/store/fk1ziblzyslg9z7gpm9j410jfgwbilsr-libxfce4ui-4.14.1

$ ./pre-inst-env guix build libxfce4ui@4.15.2
/gnu/store/cy5wyx1zrq9ahp6zl0wjpv0nd0a6hpkb-libxfce4ui-4.15.2

The argument to "guix build" is always[1] the field called NAME (and optionally
also the field called VERSION, after an "@" separator) of the package record.
The variable's name (define-public xxx) doesn't matter at this point[1].

Because the sha256 sum would have to change (among other things), make sure to
specify the field SOURCE also in the other package--otherwise you'll get the
old source.

Another reason to specify SOURCE in the other package follows:

Guile, the programming language used for Guix packages, usually uses
lexical scope.
Even the facility we built in order to make records (like <PACKAGE>) also uses
lexical scope.

That means a reference will bind to the identifier that is closest in the source
code (before it).  Once the identifier is bound, that's it--it's not going to
change binding ever again.

That means if you do this (silly example to prove a point--but you can actually
run that for real!):

  (define-public a
    (package
      (name "a")
      (version name)
      ;; Please ignore the following line for understanding for now.
      (source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

  (define-public b
    (package
      (inherit a)
      (name "b")))

  (write (package-name b))
  (newline)
  (write (package-version b))
  (newline)

package "b" would have: (name "b") but (version "a").
Version is "a".  That's not a typo.

However, with

  (define-public a
    (package
      (name "a")
      (version name) ; here, NAME is a reference, which will be bound to the NAME one line above
      ;; Please ignore the following line for understanding for now.
      (source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

  (define-public b
    (package
      (inherit a)
      (name "b")
      (version name)))

  (write (package-name b))
  (newline)
  (write (package-version b))
  (newline)

package "b" would have: (name "b") and (version "b").

Similarly for all other references, most notably the references to NAME and VERSION that
usually occur in a SOURCE field.

[1] Except for "guix build -e ..." (don't use it).
    Usually, user-facing tools only care about the contents of the <PACKAGE> record.
    Guile variables are invisible to the end user of the "guix" tool.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Correction:

That means a reference will bind to the value of the variable with that name
that is closest in the source code (before it).

Once the reference is bound, that's it--it's not going to change binding ever
again.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 133 bytes --]

Or maybe a simpler, but less applicable, example:

(let ((x 2))
  (let ((y x))
    (let ((x 3))
      y)))

=> 2

NOT 3.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

Hi

Finally It worked......Submitting the patch for review.

Now xfce4-embed-plugin is building fine after i modified the input to
old version of libxfce4ui.

I referred the older commit message from help2man from the log. I am
still not sure about it.

Its the same code i have sent you. I used the origin block. And (name  
x) was the only difference.

On 09/04/20 3:49 am, Danny Milosavljevic wrote:
> + (inherit libxfce4ui-1)
> +    (name "libxfce4ui") ; not necessary but I like it for no reason
> +    (version "4.15.2")
> +    (source (origin ; necessary block!!
I used the same. I added name block. It worked !!!
> $ ./pre-inst-env guix build libxfce4ui@4.14.1
> /gnu/store/fk1ziblzyslg9z7gpm9j410jfgwbilsr-libxfce4ui-4.14.1
>
> $ ./pre-inst-env guix build libxfce4ui@4.15.2
> /gnu/store/cy5wyx1zrq9ahp6zl0wjpv0nd0a6hpkb-libxfce4ui-4.15.2

It worked the same.

1) If name block is removed in latest.   Its building the older version.
Why??

2)  /latest is also removed from variable. Would i make a difference?


> ewline)
>   (write (package-version b))
>   (newline)
Thanks for such a long explanation. It took a bit of time for me.
> package "b" would have: (name "b") and (version "b").
>
>     Guile variables are invisible to the end user of the "guix" tool.

-- 
Regards
NagaMalli


[-- Attachment #2: 0001-gnu-libxfce4ui-Add-4.15.2.patch --]
[-- Type: text/x-patch, Size: 1731 bytes --]

From ce3d3d40a09631de05fd45eaec964d5473a4ca73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Fri, 10 Apr 2020 01:59:43 +0530
Subject: [PATCH] gnu: libxfce4ui: Add 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): New variable.
---
 gnu/packages/xfce.scm | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..9556d5aa39 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,7 @@ Xfce Desktop Environment.")
 storage system.")
     (license lgpl2.0+)))
 
-(define-public libxfce4ui
+(define-public libxfce4ui-1
   (package
     (name "libxfce4ui")
     (version "4.14.1")
@@ -201,6 +201,20 @@ storage system.")
 to share commonly used Xfce widgets among the Xfce applications.")
     (license lgpl2.0+)))
 
+(define-public libxfce4ui
+  (package
+    (inherit libxfce4ui-1)
+    (name "libxfce4ui")
+    (version "4.15.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/xfce/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
 (define-public exo
   (package
     (name "exo")
@@ -1449,7 +1463,7 @@ performance (bytes transferred per second).")
      `(("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("libxfce4ui" ,libxfce4ui)
+     `(("libxfce4ui" ,libxfce4ui-1)
        ("xfce4-panel" ,xfce4-panel)
        ("gtk+-2" ,gtk+-2)))
     (home-page
-- 
2.25.1

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]

Hi,

On Fri, 10 Apr 2020 02:12:42 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

>On 09/04/20 3:49 am, Danny Milosavljevic wrote:
>> + (inherit libxfce4ui-1)
>> +    (name "libxfce4ui") ; not necessary but I like it for no reason
>> +    (version "4.15.2")
>> +    (source (origin ; necessary block!!  

>I used the same. I added name block. It worked !!!

>1) If name block is removed in the latest [libxfce4ui package], it's building the
>older version. Why??

If I remove (name "libxfce4ui") from the latest libxfce4ui package, and then
invoke

  make -j5 SUBDIRS=

then I get an error

  error: name: unbound variable.

from the compilation of gnu/packages/xfce.scm.
So that's why the latest libxfce4ui package would never be loaded into guix
(it's broken) and instead the other one would be used.

I'm not sure why that is the case.  It's certainly different to most other
programming languages.  @Ludo?

@Ludo: Reduced test case:

  ,use (guix packages)
  (define-public a
    (package
      (name "a")
      (version name)
      (source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

  (define-public b
    (package
      (inherit a)
      (version name))) ; error message here

Error message:

  ;;; <stdin>:9:4: warning: possibly unbound variable `name'
  <unnamed port>:9:4: In procedure module-lookup: Unbound variable: name

What's happening here?  I would have expected NAME to be available from the
descendant record and accessing the ancestor record... is it not available
on purpose?

>2)  /latest is also removed from variable. Would it make a difference?

No.  It's just part of a variable's name (the slash has no special meaning
either).

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

Hi Danny

Is there a suggestion how to work on this.


Meanwhile i submitted another patch, please review

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40546


On 10/04/20 3:41 am, Danny Milosavljevic wrote:
> Hi,
>
> On Fri, 10 Apr 2020 02:12:42 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> On 09/04/20 3:49 am, Danny Milosavljevic wrote:
>>> + (inherit libxfce4ui-1)
>>> +    (name "libxfce4ui") ; not necessary but I like it for no reason
>>> +    (version "4.15.2")
>>> +    (source (origin ; necessary block!!  
>> I used the same. I added name block. It worked !!!
>> 1) If name block is removed in the latest [libxfce4ui package], it's building the
>> older version. Why??
> If I remove (name "libxfce4ui") from the latest libxfce4ui package, and then
> invoke
>
>   make -j5 SUBDIRS=
>
> then I get an error
>
>   error: name: unbound variable.
>
> from the compilation of gnu/packages/xfce.scm.
> So that's why the latest libxfce4ui package would never be loaded into guix
> (it's broken) and instead the other one would be used.
>
> I'm not sure why that is the case.  It's certainly different to most other
> programming languages.  @Ludo?
>
> @Ludo: Reduced test case:
>
>   ,use (guix packages)
>   (define-public a
>     (package
>       (name "a")
>       (version name)
>       (source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))
>
>   (define-public b
>     (package
>       (inherit a)
>       (version name))) ; error message here
>
> Error message:
>
>   ;;; <stdin>:9:4: warning: possibly unbound variable `name'
>   <unnamed port>:9:4: In procedure module-lookup: Unbound variable: name
>
> What's happening here?  I would have expected NAME to be available from the
> descendant record and accessing the ancestor record... is it not available
> on purpose?
>
>> 2)  /latest is also removed from variable. Would it make a difference?
> No.  It's just part of a variable's name (the slash has no special meaning
> either).

-- 
Regards
NagaMalli

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi Naga,

when trying to build the dependents, I get a build failure in
xfce4-equake-plugin.

Please fix xfce4-equake-plugin to also use libxfce4ui-1.
Same for xfce4-kbdleds-plugin.
Same for xfce4-mailwatch-plugin.

Otherwise OK.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40485] [PATCH v3] : [bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Naga Malleswari]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

Hi


Submitting v3 of patch

On 14/04/20 12:57 am, Danny Milosavljevic wrote:
> Hi Naga,
>
> when trying to build the dependents, I get a build failure in
> xfce4-equake-plugin.
My mistake i checked only embed plugin and formatted the patch.
>
> Please fix xfce4-equake-plugin to also use libxfce4ui-1.
> Same for xfce4-kbdleds-plugin.
> Same for xfce4-mailwatch-plugin.
Yes i build without modifications and after modifying each to validate
and i made necessary changes.
>
> Otherwise OK.

-- 
Regards
NagaMalli


[-- Attachment #2: 0001-gnu-libxfce4ui-Add-4.15.2.patch --]
[-- Type: text/x-patch, Size: 2696 bytes --]

From c16724c279309fd6fa58a927bd59862386f8a432 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Tue, 14 Apr 2020 21:10:07 +0530
Subject: [PATCH] gnu: libxfce4ui: Add 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): New variable.
---
 gnu/packages/xfce.scm | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b231761d43..f99aedcb88 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,7 @@ Xfce Desktop Environment.")
 storage system.")
     (license lgpl2.0+)))
 
-(define-public libxfce4ui
+(define-public libxfce4ui-1
   (package
     (name "libxfce4ui")
     (version "4.14.1")
@@ -201,6 +201,20 @@ storage system.")
 to share commonly used Xfce widgets among the Xfce applications.")
     (license lgpl2.0+)))
 
+(define-public libxfce4ui
+  (package
+    (inherit libxfce4ui-1)
+    (name "libxfce4ui")
+    (version "4.15.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/xfce/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
 (define-public exo
   (package
     (name "exo")
@@ -1313,7 +1327,7 @@ watch your every step.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gtk+-2" ,gtk+-2)
-       ("libxfce4ui" ,libxfce4ui)
+       ("libxfce4ui" ,libxfce4ui-1)
        ("xfce4-panel" ,xfce4-panel)))
     (home-page
      "https://goodies.xfce.org/projects/panel-plugins/xfce4-equake-plugin")
@@ -1450,7 +1464,7 @@ performance (bytes transferred per second).")
      `(("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("libxfce4ui" ,libxfce4ui)
+     `(("libxfce4ui" ,libxfce4ui-1)
        ("xfce4-panel" ,xfce4-panel)
        ("gtk+-2" ,gtk+-2)))
     (home-page
@@ -1547,7 +1561,7 @@ button and a personalized tooltip.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gtk+-2" ,gtk+-2)
-       ("libxfce4ui" ,libxfce4ui)
+       ("libxfce4ui" ,libxfce4ui-1)
        ("xfce4-panel" ,xfce4-panel)))
     (home-page
      "https://goodies.xfce.org/projects/panel-plugins/xfce4-kbdleds-plugin")
@@ -1575,7 +1589,7 @@ Caps, Scroll and Num Lock in Xfce panel.")
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gtk+-2" ,gtk+-2)
-       ("libxfce4ui" ,libxfce4ui)
+       ("libxfce4ui" ,libxfce4ui-1)
        ("exo" ,exo)
        ("xfce4-panel" ,xfce4-panel)))
     (home-page
-- 
2.25.1

[bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Naga, Danny,

What's the reason for adding an unstable version?  We don't 
usually do that in Guix.

Is this required for some other package?

Sorry for not bringing this up sooner; I'm still slogging through 
the backlog in a most random way.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#40485: Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi T G-R,
Hi Naga,

whoops, I've forgotten that that would be an unstable version.

Thanks for telling us.

Let's not merge this update then.

I've already merged the update of libxfce4util to 4.15.0--should we revert that?

Naga, please if possible let's only add stable releases to Guix.
If they are experimental, let's not add them to Guix if it can be helped.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]