From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8FYeNhQO0l4GewAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 07:41:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kBbwMRQO0l7HZgAA1q6Kng (envelope-from ) for ; Sat, 30 May 2020 07:41:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 49A13940308 for ; Sat, 30 May 2020 07:41:08 +0000 (UTC) Received: from localhost ([::1]:50218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jew79-0005Eh-7T for larch@yhetil.org; Sat, 30 May 2020 03:41:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jew74-0005AX-Ol for guix-patches@gnu.org; Sat, 30 May 2020 03:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jew74-0002w5-DP for guix-patches@gnu.org; Sat, 30 May 2020 03:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jew74-0007l8-8f for guix-patches@gnu.org; Sat, 30 May 2020 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41562] use consistent arguments. Resent-From: Tom Zander Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 May 2020 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41562 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 41562@debbugs.gnu.org, Marius Bakke Received: via spool by 41562-submit@debbugs.gnu.org id=B41562.159082441629764 (code B ref 41562); Sat, 30 May 2020 07:41:02 +0000 Received: (at 41562) by debbugs.gnu.org; 30 May 2020 07:40:16 +0000 Received: from localhost ([127.0.0.1]:56877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jew6J-0007jz-Ml for submit@debbugs.gnu.org; Sat, 30 May 2020 03:40:15 -0400 Received: from mx.kolabnow.com ([95.128.36.40]:34438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jew6H-0007jp-FM for 41562@debbugs.gnu.org; Sat, 30 May 2020 03:40:13 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTP id CF9D340D57; Sat, 30 May 2020 09:40:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freedommail.ch; h=content-type:content-type:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:date :subject:subject:from:from:received:received:received; s= dkim20160331; t=1590824407; x=1592638808; bh=UuHqCx3xUEwgm9vs6eP yEBILb3kWsjBZFasqz0u08cA=; b=h8YoMEbTXUaEbDH8R2qP6ROiQFcK02gfHZX uOJvbOCLW4CPCQZt7nUcoaJdmvHdT8sMOODJNs/YqQgrOKFc3mJjrY3ozA36y1le oFgmVsSmffigVpDSKozwuDSUsYxlidG55RTqXchMJDB2NSBVk1rUC7quLkerWiCX lugws78yl3O4sFUJocYQTaH06dEIYMyclT6dBsj4ZErcvVzfgxd5ln0ogVLmu/IT gDPHXUbUOR81blMEQkvgoeoA3uMc/AuF5VIzeON2elaYicCjpUHN6RgXZdOh6NTj M8+tzpoERdw7LpX9anBG6a7Pj9I8Ufo2nQKS/A2SlIZJP492//81Ks/j6qpeiCrv rikuffm0exiekollrn2YlpT51YYZ9ipLdPOk46wpyZp+TpeTyYt7Irx7m/T+NDVm tupBYd4+BmGrWXdCyO9xPphrWohPHXBsx0NuYelu35GE3HKMbvBmybVgTS4yYXRY +vqx+ri2HXs+k/4EDHMPcPke6bsMWecz2mNrx9eFsz5pQu6E/RJ/VFQvos+LMRfP p0ZyN71sDkfpWk8XB1vTPqgWEAeRqdSdev1kqtK1f3BJq/2M8ta6zVZ+YTTcqmZl nySlZhbTM57WqO4mvWAt56+25Z0c4k3GwajVd9lcnRpLlZayplSmK/IROzU0kokp ozxy23nw= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Score: -1.899 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id roDEirhY0ATC; Sat, 30 May 2020 09:40:07 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTPS id C9F4F40D33; Sat, 30 May 2020 09:40:06 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 71EA751E; Sat, 30 May 2020 09:40:06 +0200 (CEST) Date: Sat, 30 May 2020 09:40:04 +0200 Message-ID: <2590775.irdbgypaU6@cherry> In-Reply-To: <874kry4g0d.fsf@gnu.org> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> <874kry4g0d.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tom Zander , Tom Zander via Guix-patches From: Tom Zander via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=freedommail.ch header.s=dkim20160331 header.b=h8YoMEbT; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: QlQx576jEIqb On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote: > Tom Zander via Guix-patches via writes: > > As suggested on IRC > > > >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 > >> > > From: TomZ > > Date: Wed, 27 May 2020 13:21:58 +0200 > > Subject: [PATCH] gnu: flowee: Disable unpredictable test. > > > > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts > > > > which fail half the time in a build, so disable the test. > > Can you move this piece of information to a comment in the code? Can you point to the file I find the code in, to add this to? In case you mean the package description, its already there. > Also, this should say (flowee)[arguments]: ... > > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > > index f182057bb4..d176ac0660 100644 > > --- a/gnu/packages/finance.scm > > +++ b/gnu/packages/finance.scm > > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over > > RPC.")> > > (base32 > > "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) > > > > (build-system cmake-build-system) > > (arguments > > > > - `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF") > > + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" > > "-Denable_gui=OFF") > This should probably not be here? Why not? > > #:phases > > > > (modify-phases %standard-phases > > > > (add-before 'configure 'make-qt-deterministic > > > > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over > > RPC.")> > > (lambda _ > > > > (substitute* "testing/CMakeLists.txt" > > > > (("test_api") "")) > > Can this be removed? It looks like it tries to do the same as your new > substitution below. Same file, two substitutes because there are two lines that need changing. CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make- check' > > + (substitute* "testing/CMakeLists.txt" > > + (("add_subdirectory\\(api\\)") "")) > > > > #t)) > > > > (add-after 'configure 'set-build-info > > > > ;; Their genbuild.sh to generate a build.h fails in guix (no > > .git dir) . -- Tom Zander