From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44620) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1id02W-0005Vn-7c for guix-patches@gnu.org; Thu, 05 Dec 2019 17:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1id02U-00007P-HB for guix-patches@gnu.org; Thu, 05 Dec 2019 17:56:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1id02T-0008Vh-Oe for guix-patches@gnu.org; Thu, 05 Dec 2019 17:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1id02T-000341-M6 for guix-patches@gnu.org; Thu, 05 Dec 2019 17:56:01 -0500 Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-Message-ID: Message-ID: <24b5011d36a76fbb4a64e16d8eeaf540b4ba92df.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 05 Dec 2019 23:55:09 +0100 In-Reply-To: <877e3ad2zk.fsf@posteo.net> References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> <87fthyd54z.fsf@posteo.net> <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> <877e3ad2zk.fsf@posteo.net> Content-Type: multipart/mixed; boundary="=-xqjyJqD25Y6ifULSgcBP" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brett Gilio Cc: 38463@debbugs.gnu.org --=-xqjyJqD25Y6ifULSgcBP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Am Donnerstag, den 05.12.2019, 12:46 -0600 schrieb Brett Gilio: > That is why I made the note about eventually replacing the > installation of that directory to use the system usually used by > `emacs-build-system` because I figure this would cause less issues in > the future if for some reason the emacs site-lisp directory structure > were to change again. > > --8<---------------cut here---------------start------------->8--- > ;; TODO: Replace with `#:include' method used by > ;; emacs-build-system. > --8<---------------cut here---------------end--------------->8--- > > But I don't think it is a pressing issue to do it so cleanly. > Or maybe it is. Idk. Perhaps you're right, but as far as I can see the Emacs build system does not yet tell us how to proceed with data. It also has a unique way of handling documentation, first putting it into site-lisp before moving it to share/info where it should belong. > > I still don't feel comfortable with data being at the top of site- > > lisp, > > though. Perhaps something similar to emacs-yasnippet-snippets, > > where > > you store the data in share/emacs/telega-data would be more > > appropriate. > > I was ACTUALLY going to do it this way originally, but I was really > uncertain of it so I just sent the patch as is. I like the idea more, > so > I am going to revise the patch. Otherwise, once I get this revision > in > everything should be good to go. I'll also substitute the functions > to > reflect that changed path. > > [...] > > Alright, carry on! Patch will be available soon. Looking at your revised patch, I still feel a bit uneasy about putting data into the load-path. I therefore proprose a revised revised (R^2, if you will) patch, which I've attached to this message. Regards, Leo --=-xqjyJqD25Y6ifULSgcBP Content-Disposition: attachment; filename="0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch" Content-Type: text/x-patch; name="0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1OTkxOGQ0YTQ4NmM0NTM0NjNlNmM1OTQ4NzA0NzE3N2YzYjU0MjA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmV0dCBHaWxpbyA8YnJldHRnQHBvc3Rlby5uZXQ+CkRhdGU6 IFRodSwgNSBEZWMgMjAxOSAxMzo1MToxNCAtMDYwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSBnbnU6 IGVtYWNzLXRlbGVnYTogSW5zdGFsbCB0ZWxlZ2EtZGF0YSB0byBzaXRlLWxpc3AuCgoqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy10ZWxlZ2EpW2FyZ3VtZW50c106IFRoaXMgY29t bWl0IHJldmlzZXMgYQogIHByZXZpb3VzIHBhdGNoIGFuZCBnaXZlcyB0aGUgc291cmNlIGV0Yy8g ZGlyZWN0b3J5IGEgdW5pcXVlIGluc3RhbGxhdGlvbiBwdGgKICBpbiB0aGUgc2l0ZS1saXNwIGRp cmVjdG9yeSBzdHVjdHVyZS4KCkNvLWF1dGhvcmVkLWJ5OiBMZW8gUHJpa2xlciA8bGVvLnByaWts ZXJAc3R1ZGVudC50dWdyYXouYXQ+Ci0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gfCAy NSArKysrKysrKysrKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IGY4ZjY1ZjBlN2UuLmM0YWE0 NGQ4ZDAgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC0xOTk4OSw2ICsxOTk4OSwxNiBAQCBmaXNoLWNvbXBs ZXRpb24uICBJdCBjYW4gYmUgdXNlZCBpbiBib3RoIEVzaGVsbCBhbmQgTS14IHNoZWxsLiIpCiAg ICAgICAgICAgICAgICAgICgoInB5dGhvbjMgcnVuX3Rlc3RzLnB5IikKICAgICAgICAgICAgICAg ICAgICIiKSkKICAgICAgICAgICAgICAgICN0KSkKKyAgICAgICAgICAgOzsgTW9kaWZ5IHRlbGVn YS11dGlsIHRvIHJlZmxlY3QgdW5pcXVlIGRpciBuYW1lIGluCisgICAgICAgICAgIDs7IGB0ZWxl Z2EtaW5zdGFsbC1kYXRhJyBwaGFzZS4KKyAgICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICd0 ZWxlZ2EtZGF0YS1wYXRjaAorICAgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgICAg KHN1YnN0aXR1dGUqICJ0ZWxlZ2EtdXRpbC5lbCIKKyAgICAgICAgICAgICAgICAgKCgiXFwoY29u Y2F0IFwiZXRjL1wiIGZpbGVuYW1lXFwpIHRlbGVnYS0tbGliLWRpcmVjdG9yeSIpCisgICAgICAg ICAgICAgICAgICAiKGNvbmNhdCBcInRlbGVnYS1kYXRhL1wiIGZpbGVuYW1lKQorICAgICAgICAg ICAgICAgICAgICAobG9jYXRlLWRvbWluYXRpbmctZmlsZSB0ZWxlZ2EtLWxpYi1kaXJlY3RvcnkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXCJ0ZWxlZ2EtZGF0 YVwiKSIpKQorICAgICAgICAgICAgICAgI3QpKQogICAgICAgICAgICA7OyBUaGUgdGVsZWdhIHRl c3Qgc3VpdGUgY2hlY2tzIGZvciBhIHZlcnNpb24gb2YgRW1hY3MKICAgICAgICAgICAgOzsgY29t cGlsZWQgd2l0aCBpbWFnZW1hZ2ljayBhbmQgc3ZnIHN1cHBvcnQuIFNpbmNlIHdlCiAgICAgICAg ICAgIDs7IGFyZSB1c2luZyBgZW1hY3MtbWluaW1hbGAsIHRoaXMgc3RlcCB3aWxsIGZhaWwuCkBA IC0yMDAxOSwxMSArMjAwMjksMjAgQEAgZmlzaC1jb21wbGV0aW9uLiAgSXQgY2FuIGJlIHVzZWQg aW4gYm90aCBFc2hlbGwgYW5kIE0teCBzaGVsbC4iKQogICAgICAgICAgICA7OyBCdWlsZCBlbWFj cy1zaWRlIHVzaW5nIGBlbWFjcy1idWlsZC1zeXN0ZW0nCiAgICAgICAgICAgIChhZGQtYWZ0ZXIg J2NvbXByZXNzLWRvY3VtZW50YXRpb24gJ2VtYWNzLWFkZC1zb3VyY2UtdG8tbG9hZC1wYXRoCiAg ICAgICAgICAgICAgKGFzc29jLXJlZiBlbWFjczolc3RhbmRhcmQtcGhhc2VzICdhZGQtc291cmNl LXRvLWxvYWQtcGF0aCkpCi0gICAgICAgICAgIChhZGQtYWZ0ZXIgJ2VtYWNzLXNldC1lbWFjcy1s b2FkLXBhdGggJ2VtYWNzLWluc3RhbGwKKyAgICAgICAgICAgKGFkZC1hZnRlciAnZW1hY3MtYWRk LXNvdXJjZS10by1sb2FkLXBhdGggJ2VtYWNzLWluc3RhbGwKICAgICAgICAgICAgICAoYXNzb2Mt cmVmIGVtYWNzOiVzdGFuZGFyZC1waGFzZXMgJ2luc3RhbGwpKQotICAgICAgICAgICAoYWRkLWFm dGVyICdlbWFjcy1pbnN0YWxsICdlbWFjcy1idWlsZAorICAgICAgICAgICA7OyBUaGlzIHN0ZXAg aW5zdGFsbHMgc3ViZGlyIC9ldGMsIHdoaWNoIGNvbnRhaW5zIGltYWdlcywgc291bmRzIGFuZAor ICAgICAgICAgICA7OyB2YXJpb3VzIG90aGVyIGRhdGEsIG5leHQgdG8gdGhlIHNpdGUtbGlzcCBk aXIuCisgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2VtYWNzLWluc3RhbGwgJ3RlbGVnYS1pbnN0YWxs LWRhdGEKKyAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVy LWtleXMpCisgICAgICAgICAgICAgICAoY29weS1yZWN1cnNpdmVseQorICAgICAgICAgICAgICAg ICJldGMiCisgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiBvdXRwdXRz ICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvc2hhcmUvZW1hY3MvdGVs ZWdhLWRhdGEvIikpCisgICAgICAgICAgICAgICAjdCkpCisgICAgICAgICAgIChhZGQtYWZ0ZXIg J3RlbGVnYS1pbnN0YWxsLWRhdGEgJ2VtYWNzLWJ1aWxkCiAgICAgICAgICAgICAgKGFzc29jLXJl ZiBlbWFjczolc3RhbmRhcmQtcGhhc2VzICdidWlsZCkpCi0gICAgICAgICAgIChhZGQtYWZ0ZXIg J2VtYWNzLWluc3RhbGwgJ2VtYWNzLW1ha2UtYXV0b2xvYWRzCisgICAgICAgICAgIChhZGQtYWZ0 ZXIgJ2VtYWNzLWJ1aWxkICdlbWFjcy1tYWtlLWF1dG9sb2FkcwogICAgICAgICAgICAgIChhc3Nv Yy1yZWYgZW1hY3M6JXN0YW5kYXJkLXBoYXNlcyAnbWFrZS1hdXRvbG9hZHMpKSkpKQogICAgICAg KHByb3BhZ2F0ZWQtaW5wdXRzCiAgICAgICAgYCgoImVtYWNzLXZpc3VhbC1maWxsLWNvbHVtbiIg LGVtYWNzLXZpc3VhbC1maWxsLWNvbHVtbikpKQotLSAKMi4yNC4wCgo= --=-xqjyJqD25Y6ifULSgcBP--