From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wEWSElJLBGFFkwAAgWs5BA (envelope-from ) for ; Fri, 30 Jul 2021 20:56:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cBEqDlJLBGF6GAAA1q6Kng (envelope-from ) for ; Fri, 30 Jul 2021 18:56:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B747714B1A for ; Fri, 30 Jul 2021 20:56:17 +0200 (CEST) Received: from localhost ([::1]:35440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9Xg8-0008A8-La for larch@yhetil.org; Fri, 30 Jul 2021 14:56:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9Xfu-0007a6-OG for guix-patches@gnu.org; Fri, 30 Jul 2021 14:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9Xfu-0003o0-CV for guix-patches@gnu.org; Fri, 30 Jul 2021 14:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9Xfu-0006Pa-CO for guix-patches@gnu.org; Fri, 30 Jul 2021 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49783] [PATCH] Add vimpc mpd client package definition Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Jul 2021 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49783 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: guil_fsf@tutanota.com, 49783@debbugs.gnu.org Received: via spool by 49783-submit@debbugs.gnu.org id=B49783.162767132724595 (code B ref 49783); Fri, 30 Jul 2021 18:56:02 +0000 Received: (at 49783) by debbugs.gnu.org; 30 Jul 2021 18:55:27 +0000 Received: from localhost ([127.0.0.1]:60944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9XfL-0006Od-8W for submit@debbugs.gnu.org; Fri, 30 Jul 2021 14:55:27 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:41462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9XfH-0006OT-S3 for 49783@debbugs.gnu.org; Fri, 30 Jul 2021 14:55:25 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id bWvM2500U0mfAB406WvNEq; Fri, 30 Jul 2021 20:55:22 +0200 Message-ID: <245c92a24b2ea0e7d21190c2d3d1835d23168308.camel@telenet.be> From: Maxime Devos Date: Fri, 30 Jul 2021 20:55:14 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wKXF8NzEA+GjRqjseiSh" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1627671322; bh=+0TFNbq7QTUj1+iTrrv0UQn9nYlitsD6NG9IP9aT4e8=; h=Subject:From:To:Date:In-Reply-To:References; b=jDnTQP94PKx+5kOlA3pHHAghYITXq99GAc2hwwFsbPfA8zkHGFeCRQeQkGduo6ZCe 1GfrP9x2FZPqTt55+yDKoDXgxT9cWWyJNhVY8DWQvSJ6U37KqeHdvDEs/dXhRJyCJn p467aAPYeEGlzbuBiPSwsA3Z7GRgCUcp1lXtKnYsQnuDNr5nB7MUj97wopgiD77EjK uiIMD/gW1VSlTjXDqNhTEdRQLL7gdosOS/QKKwgyqN5yjqyjVBNQb7dsSwKKNmS4JU LwAMedx67Yl76TqMZDHMTpfceIT4QlqZ6/VomLHOjWa9digXg5riJkkYP9xjgWao5i gq8wec/3BRsxw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627671378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+0TFNbq7QTUj1+iTrrv0UQn9nYlitsD6NG9IP9aT4e8=; b=orOGrS2kHcDHgefsKKYuHUduoSoFeX5S2vr2V2pD2g6u7yV4Ur3+TL7AzAlGZrYyMCA3LL vmffNpqqmEBax+T2iiH6p8+DlmFqXpLezoVpASY3MXdaKjeOlSF/5PGCJ1lWW8XJRwQsUw zQT0a0z0W8HaXKRwSI8LDtie4UGZc/56hBZTnprgHf/hRX+Frp6T3/ob9keo456C0xr0qc yh3wWFS/zlyGk1maUCVGuYaQ/SGNBCZnNkan2clst0IuI5f4Yhxo7dT2YgWj7juFtFZkhg 4QTN+ky8tIZ+bT4TGaUciuS6aScjXB2IZywiSJ8dZNPjusgnV7FiUC8TQRPr6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627671378; a=rsa-sha256; cv=none; b=hse5ZHK9nKS543qwrZekrGgfGnLYTwSY6w5Bd8Uu8q9BZmuv9o9JBKx9gJhtyD7HQSAtkR FYmx/Vf4GakKDEKj2WEhO5518WcA8oT127DxjAbTtBve9MSNK3+boc0VkFmO9iU4U7ayXy bD8+j9rAf9/htwvFyqP8dztk909mEWVYQjq9ikC3n7eBAqMtPbi4aCdQuGZY8oY3bF0/xC UZNFRr/52Ej+YIfNafKbRFdMhnfuoSUY1SKTrHaW2enpym8Q7sSp1Bo132xbvve2q6C3NA eft5PzZuCA2l0ZxhH9CdkYtxpZZkjHMXcYuXC5GLg/uOMFxNQzKT/iwLOGjjpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=jDnTQP94; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=jDnTQP94; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B747714B1A X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: pAd59EXQkvoD --=-wKXF8NzEA+GjRqjseiSh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, guil_fsf--- via Guix-patches via schreef op vr 30-07-2021 om 15:30 [+0200]: > --- > gnu/packages/mpd.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) A commit message is missing. > diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm > index b97abcafc3..2c1f189421 100644 > --- a/gnu/packages/mpd.scm > +++ b/gnu/packages/mpd.scm > @@ -513,3 +513,53 @@ for your favorite MPD client but an addition to get = a better > album-experience.") > (home-page "https://gitlab.com/coderkun/mcg") > (license license:gpl3+))) > + > +(define-module (vimpc) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix build-system gnu) > + #:use-module (guix git-download) > + #:use-module (gnu packages mpd) > + #:use-module (gnu packages pcre) > + #:use-module (gnu packages mp3) > + #:use-module (gnu packages autotools) > + #:use-module (gnu packages curl) > + #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages ncurses)) This define-module block can be removed, and the #:use-module can be moved to the top of the file. > +(define-public vimpc > + (package > + (name "vimpc") > + (version "0.09.2") > + > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/boysetsfrog/vimpc.git") I think there is a linter checking that ".git" is not included in GitHub URLs. Try "./pre-inst-env guix lint vimpc". > + (commit (string-append "v" version)))) > + (sha256 (base32 "0lswzkap2nm7v5h7ppb6a64cb35rajysd09nb204rxg= rkij4m6nx")) > + (file-name (git-file-name name version)))) > + (build-system gnu-build-system) > + (native-inputs `(("autoconf" ,autoconf) > + ("automake" ,automake))) > + (inputs `(("libmpdclient" ,libmpdclient) > + ("pcre" ,pcre) > + ("taglib" ,taglib) > + ("pkg-config" ,pkg-config) "pkg-config" should most likely be in 'native-inputs', not 'inputs'. The difference between 'inputs' and 'native-inputs' matters when cross-compiling. I'd suggest running "./pre-inst-env guix build vimpc --target=3Dx86_64-linux-gnu" for testing, but meson-build-system (used by libmpdclient) doesn't support cross-compilation yet (at least, on master it doesn't. On the core-updates branch, meson-build-system supports cross-compilation), so that wouldn't work yet anyway. > + ("curl" ,curl) > + ("ncurses" ,ncurses) > + )) > + (arguments > + `(#:tests? #false When disabling tests, always write a comment explaining why. If the tests fail, that may indicate a real problem (that's the purpose of tests). > + > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-hardcoded-paths > + (lambda _ > + (system* "./autogen") > + ))))) The formatting went wrong here (whitespace and lonely parentheses). I'd recommend using "git format-patch HEAD^..HEAD" and sending the patch as an attachment, or using "git send-email". > + (synopsis "Vi-like Mpd TUI client written in C++") > + (description "Vimpc provides an alternative to other mpd clients (suc= h as ncmpc and ncmpcpp) that tries to provide an interface similar to that = of the vim text editor.") This description doesn't explain anything to people who don't know what 'Mpd', 'Vi', 'nmpc' and 'ncmpcpp' are. I only know of the first two (a music/video player and a customisable text editor), but only because I've read something about it some time ago.=20 Browsing through the source code, I notice files named "lyricsloader.cpp", "lyricsfetcher.cpp", "song.cpp". Maybe you could note that "vimpc" is a music player? Greetings, Maxime. --=-wKXF8NzEA+GjRqjseiSh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYQRLEhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sUdAP9Y+dXhqXhwBrerRzDASJRBh/9t 6fejJbR/ibeE82suuwEApWE4V8Xr6ElCR67JtIowfrN/5GJbWfZldRNonZKzZAw= =6wKA -----END PGP SIGNATURE----- --=-wKXF8NzEA+GjRqjseiSh--