From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oGpHA5SS1WKa3AAAbAwnHQ (envelope-from ) for ; Mon, 18 Jul 2022 19:04:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ULlJApSS1WJZrgAAG6o9tA (envelope-from ) for ; Mon, 18 Jul 2022 19:04:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C1F123EA13 for ; Mon, 18 Jul 2022 19:04:19 +0200 (CEST) Received: from localhost ([::1]:43874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDUAL-0004lZ-Tz for larch@yhetil.org; Mon, 18 Jul 2022 13:04:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDUA6-0004hJ-F0 for guix-patches@gnu.org; Mon, 18 Jul 2022 13:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDUA5-00078E-V4 for guix-patches@gnu.org; Mon, 18 Jul 2022 13:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDUA5-0002xe-Pk for guix-patches@gnu.org; Mon, 18 Jul 2022 13:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Jul 2022 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , zimoun Cc: 51427@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.165816382211354 (code B ref 51427); Mon, 18 Jul 2022 17:04:01 +0000 Received: (at 51427) by debbugs.gnu.org; 18 Jul 2022 17:03:42 +0000 Received: from localhost ([127.0.0.1]:51950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDU9m-0002x4-5A for submit@debbugs.gnu.org; Mon, 18 Jul 2022 13:03:42 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:38647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDU9i-0002wp-6z for 51427@debbugs.gnu.org; Mon, 18 Jul 2022 13:03:40 -0400 Received: by mail-ej1-f65.google.com with SMTP id l23so22438357ejr.5 for <51427@debbugs.gnu.org>; Mon, 18 Jul 2022 10:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=mfR4lT4ipVVMv7wQ5zhlzQYPqKIu1msEtc46UhVS0/o=; b=qM8u6SazPr7UDMB1ZrefblwyG+DKnKFISS5pcK+yMne6ru9JCAKaeFI5Cije4eJSna SWSMt2yLfcwLkJH6590EfWYesaLf+KrrWc/pmYfyqfl87+c9wQFGuAUDJf6xKnXdezFh tbVTIauWzl6omNnTGmvgGOEnrJE74KXlpjWztLmglzZtftd3q6K4wX7snpg4kest4v5R g4I3jnUJl9RjX+la/TEtOC4hwyc1fMTeUxvxPwePgoD0BrljwmYgwA1XhA4UF3g9K+L+ NBFjDka/1et07EimTtSUJBXEZMOmHBtUYpcCjpTnbsCNfPDCx+sEBpPKOy4wKGnnNy09 QoSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=mfR4lT4ipVVMv7wQ5zhlzQYPqKIu1msEtc46UhVS0/o=; b=DZGurdi0OyJvjZ6tKUyLd8F/sx2ijJ21sqbvk8J8x/dgmNED0BieypvCnXX5jmsw6A nuju2hRapfM+porCH1e32oC2CvlptrSwIzdM+IEc1oxD0KN4C/WnTq0Czz73SzfOIpR8 W0tFbwWTqJ9LsXICB70qUsFd96jrKHspw+3qjAHywlYP6HUXYWFqHo+cZbuaqPNhne8H 9nWyVD6teHm/Bcpp26qKP33Wm/X2nZcdXRwIyk69DbkNN5hEuUXX4uK9aesuh38yCnk0 VpwI8GHuxAB/rzGdUguCCKIkgdHLm22VpWMAar6iXrw2Eiqf1yHmEe7XbPKLMJSxmDEf ixZQ== X-Gm-Message-State: AJIora8yRu6aXqxEZQ66UJ6qqH7vgL24K677w83Cw4NtYYbDUG6GmOqS SsgNVF/2nlb1Xfz1I1r41zg= X-Google-Smtp-Source: AGRyM1vawT206Q0A4KtU2pTAgiORMaHPB1ECD6W/3EFP0KYNLGwNiKgjjgU9RbcUEDxCgPszR1w7lQ== X-Received: by 2002:a17:906:5d04:b0:722:f46c:b891 with SMTP id g4-20020a1709065d0400b00722f46cb891mr27105767ejt.4.1658163812406; Mon, 18 Jul 2022 10:03:32 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j26-20020aa7de9a000000b0043a7293a03dsm8878955edv.7.2022.07.18.10.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 10:03:31 -0700 (PDT) Message-ID: <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 18 Jul 2022 19:03:30 +0200 In-Reply-To: <87o7xmy14l.fsf_-_@gnu.org> References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> <87ee7tmdbd.fsf@gnu.org> <86k0hhnqss.fsf@gmail.com> <871r3f2j7y.fsf@gnu.org> <867dd7roi2.fsf@gmail.com> <87o7xmy14l.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658163859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mfR4lT4ipVVMv7wQ5zhlzQYPqKIu1msEtc46UhVS0/o=; b=O8tQVpffa7Xs1ITVMq+2h8kVVwJNTeKCIvtX0yFeONn88814Rh39o8Ll4APBx/FsbaPQ/j HQZIXARkSGd8ULqbPheH8D8d59/xvossD8FkZ+cPHkBZSRfBKkLkeGiz2vvl9+FdjX3toA FysaQ3XBTT1ui5fVXIo6NwDv7iQGqRqF0WIfLOvhVVMXOlsZ4gtAnJC/7wu0yu+dpl9ZAE 5tqLpUAoJy5N3QzrUxrHTVkLnKVNzZcpYI72+JX3SUhkP3J0SnSLjvJovrotI8chY9MF6I V+pBS5P/g/ER2HZy9Hof22/4pvj8XP5/yQVPwu4E046QvrUgAHnPd0VeO1iF1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658163859; a=rsa-sha256; cv=none; b=QKIkl1uzKqJWx9/vv3+jqjk0BdfIYOshYgXvA60CGCnvhTFNf29B5jw2y4uihny1BHgajK ygsUZfWQ4QWkjuVCPWXSamgXNDP+ICdAtYaXITCeoG6dnWpO69bpEj62S1BrKKx1k39ET8 UBBU07n34wqBTcbk2sJTjJPZAnxveZk7BQ1uuS3wXMIGkU4e2PCEPvRsT+GNBpC1rJB0vC G17G28B6jTyZW01RafXHRHOsTtm2lV9CMwZfeSPPggaTv+iTHr3mNZ/c+mISy2A4v4gsFg UoziBabOtiCEAznmo1TK09MtjMGPbUdKpc9+VMzj65P6jt0/dADWYr9V2To1Qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qM8u6Saz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qM8u6Saz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C1F123EA13 X-Spam-Score: 6.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: hMmL17J07bQJ Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Courtès: > Hello, > > With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021), > partially fixing , there is > hopefully less pressure to skip the remove-unused-links phase. > > Should we close this issue? As a hard disk user, I'm leaning towards "no". In fact, I recently encountered a case where I think I might want to skip it even if not deleting "specific items". For context, my machine has troubles with sudden power outages during builds (courtesy of a certain graphics card manufacturer), so if one of those happens during `guix package' or `guix system' invocation, the sanest thing to do is to run `guix gc' after reboot and retry whatever command I wanted to run. However, since I'm not really deleting much here, I'd probably be fine with accumulating trash and collecting it at a later date. Deleting unused links is also something that can on some machines be postponed to a time when they'd otherwise be idle, though I don't think it matters too much in the context of CI since the global lock is no longer held at that point, while the lack of storage is still blocking builds. Cheers