From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emij5-0000Us-Hu for guix-patches@gnu.org; Fri, 16 Feb 2018 11:19:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emij0-0005iS-If for guix-patches@gnu.org; Fri, 16 Feb 2018 11:19:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emij0-0005iK-En for guix-patches@gnu.org; Fri, 16 Feb 2018 11:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1emij0-0007PU-6K for guix-patches@gnu.org; Fri, 16 Feb 2018 11:19:02 -0500 Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-Message-ID: References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> From: Hartmut Goebel Message-ID: <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> Date: Fri, 16 Feb 2018 17:18:30 +0100 MIME-Version: 1.0 In-Reply-To: <87sha4wlot.fsf@fastmail.com> Content-Type: multipart/alternative; boundary="------------6EA775E0CA29205C2709EDDE" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30340@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= This is a multi-part message in MIME format. --------------6EA775E0CA29205C2709EDDE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 13.02.2018 um 23:48 schrieb Marius Bakke: >> I do not care about the comments, but FMPOV it is important to document >> somehow in the code or in the commits that all patches as of 2018-01-19 >> have been considered. an alternative would be to group these few commits >> into a (very short) branch and documenting the fact in the merge-commit. >> >> WDYT? > I don't think the comments are all that useful. They only add noise in > the commit log and the code -- since we have a working and up-to-date > Qt, it is implied that we don't need anything more from NixOS or > elsewhere. > @Ludo: What's you opinion on this? (See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62) -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------6EA775E0CA29205C2709EDDE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 13.02.2018 um 23:48 schrieb Marius Bakke:
I do not care about the comments, but FMPOV it is important to document
somehow in the code or in the commits that all patches as of 2018-01-19
have been considered. an alternative would be to group these few commits
into a (very short) branch and documenting the fact in the merge-commit.

WDYT?

I don't think the comments are all that useful.  They only add noise in
the commit log and the code -- since we have a working and up-to-date
Qt, it is implied that we don't need anything more from NixOS or
elsewhere.

@Ludo: What's you opinion on this? (See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------6EA775E0CA29205C2709EDDE--