unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>, 36695@debbugs.gnu.org
Subject: [bug#36695] [PATCH 3/3] guix: ant-build-system: Use absolute path as base-dir.
Date: Fri, 19 Jul 2019 12:56:15 +0200	[thread overview]
Message-ID: <23ECF5DC-4E69-4F34-87EA-E7A8F5E7258E@lepiller.eu> (raw)
In-Reply-To: <560f89f5-c186-9a93-ac3a-b5ca92f5842e@crazy-compilers.com>

Le 19 juillet 2019 12:43:50 GMT+02:00, Hartmut Goebel <h.goebel@crazy-compilers.com> a écrit :
>Am 17.07.19 um 10:17 schrieb Julien Lepiller:
>> I don't understand the point of that patch. I can already add a chdir
>phase just after unpack to do just that. What does this patch give us?
>
>This patch only ensures the build-directory is an absolute path instead
>of a relative one. It does not enable to specify the build-dir as an
>option to the ant-build-system. Thus it is different from using a chdir
>phase.
>
>As this patch is some years old now, I can't remember the exact case.
>AFAIR the relative path did not work for some packages for some reason.
>
>Please let me know if I should include this one, too. (No reasoning
>necessary.)
>
>(I'm just waiting for your answer to avoid rebuilding all java-packages
>twice - even on staging)

I'm fine with this patch, but I still don't see the point.

  reply	other threads:[~2019-07-19 10:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 20:08 [bug#36695] [PATCH 0/3] Enhancemante for the ant-build-system Hartmut Goebel
2019-07-16 20:10 ` [bug#36695] [PATCH 1/3] guix: ant-build-system: Use ant-task "jar" instead of executing "jar" Hartmut Goebel
2019-07-16 20:10   ` [bug#36695] [PATCH 2/3] guix: ant-build-system: Put dummy project-name into default build.xml Hartmut Goebel
2019-07-16 20:10   ` [bug#36695] [PATCH 3/3] guix: ant-build-system: Use absolute path as base-dir Hartmut Goebel
2019-07-17  8:17     ` Julien Lepiller
2019-07-19 10:43       ` Hartmut Goebel
2019-07-19 10:56         ` Julien Lepiller [this message]
2019-07-19 11:04           ` Hartmut Goebel
2019-07-19 10:57         ` Julien Lepiller
     [not found] ` <handler.36695.B.156330772723013.ack@debbugs.gnu.org>
2019-07-25  8:26   ` bug#36695: [PATCH 0/3] Enhancemants for the ant-build-system Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23ECF5DC-4E69-4F34-87EA-E7A8F5E7258E@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=36695@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).