From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SDy3Hs2ZFmIpIQAAgWs5BA (envelope-from ) for ; Wed, 23 Feb 2022 21:32:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KDZYF82ZFmKYMwEAG6o9tA (envelope-from ) for ; Wed, 23 Feb 2022 21:32:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7CA638906 for ; Wed, 23 Feb 2022 21:32:12 +0100 (CET) Received: from localhost ([::1]:40500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMyJ0-0001ao-Ug for larch@yhetil.org; Wed, 23 Feb 2022 15:32:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMyIs-0001aT-2c for guix-patches@gnu.org; Wed, 23 Feb 2022 15:32:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMyIr-0007d3-PE for guix-patches@gnu.org; Wed, 23 Feb 2022 15:32:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMyIr-00055U-MJ for guix-patches@gnu.org; Wed, 23 Feb 2022 15:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v3 09/15] gnu: Add racket-vm-cgc. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Feb 2022 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , Philip McGrath , 53878@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Attila Lendvai , Maxime Devos , Malte Gerdes , raingloom , zimoun Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164564830318638 (code B ref 53878); Wed, 23 Feb 2022 20:32:01 +0000 Received: (at 53878) by debbugs.gnu.org; 23 Feb 2022 20:31:43 +0000 Received: from localhost ([127.0.0.1]:46663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMyIZ-0004qL-6j for submit@debbugs.gnu.org; Wed, 23 Feb 2022 15:31:43 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:34469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMyIY-0004lL-0j for 53878@debbugs.gnu.org; Wed, 23 Feb 2022 15:31:42 -0500 Received: by mail-ej1-f68.google.com with SMTP id gb39so55052218ejc.1 for <53878@debbugs.gnu.org>; Wed, 23 Feb 2022 12:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=h1GjfGhRT+QT34raVyoeimIKl/ITRptmFHh0KbSyC9Y=; b=m214/JV4wgX63n8aca65Ux/kWyL522N+rkyZXpz2Cxk/iowY5L1lPlyirCUe0jdngY KduzKQIcjzK3nlXallsl6FtM0k9l/AkhzP/mcGVWqgger4GIfIEOl24teIANNVs5NxCb UMBZZAviJRgOF1Xcy+fnjN57XxNS6FnvfGv1fl04JIcC10b71aQ92NUp5ob3tk9Wc9Pv y43MyT7h7o0gFr36AIyU6bIJNsNnYcL9obd6jLaFqE7BSZi34utr0/a/8c+4FbvICslu M5rkW36Oec67yYArw5hmLQU4UYYalQDOSUeyK5YnieWbaQ3UEzSkA4XUqxlFxgyS2Q9e ZlLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=h1GjfGhRT+QT34raVyoeimIKl/ITRptmFHh0KbSyC9Y=; b=MnCFGkf1VCqIQSAiKgWRDI21g46F6ukJKS8OArRnjKLIPKjlaqX3Hi8mhePJR0MG0M HsCBbfNPXjKMDN/PgF59hOUtxzcZ/8TyrMcvtW96GJQCnFJ9pHkmY7+p56vDIBOz14xS +PR3vC/MIkMW1rCbkOUJoHYtpHgl0Luhc0UoDnxT7zzQa3lT6oZp1KoSqF8zHUuiqLYf UkhqDF+hMYgyr1azyBH34rlJUtDiIQ1Oj9sOi4JG25t9hB/YGyIfRA7NzA+AJM9j+yJN +SX/ZFSsCnLyaXjGYiJFx5kU1GYLA2j4ow/80yJLMCelKou9QXImgxXHUG+I6+98/o2k gpbw== X-Gm-Message-State: AOAM530SMI4zDuHIK69ibcTQQ4DuOpZ1WUvh6+FgKA4SUwGDQWN+4AN/ f1cYIrEotBqa+VDaQXlXG00= X-Google-Smtp-Source: ABdhPJxGi1A4Gb+YXMa7/Q4bXMaFZq/D5gIcbaglpg6N6Mh2GgUnOo3CVOwEhXpZNqT+Kn+BtE1rUQ== X-Received: by 2002:a17:906:35da:b0:6b8:9f07:f15d with SMTP id p26-20020a17090635da00b006b89f07f15dmr1063586ejb.552.1645648296122; Wed, 23 Feb 2022 12:31:36 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l19sm373695edb.87.2022.02.23.12.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 12:31:35 -0800 (PST) Message-ID: <236d81872dff1880e9fba2f413f1a5ac3cb4f6fd.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 23 Feb 2022 21:31:34 +0100 In-Reply-To: References: <20220208151316.1897345-1-philip@philipmcgrath.com> <1853902.IiyMIqa0Cy@bastet> <5037281.s90xYg8xyF@bastet> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645648333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=h1GjfGhRT+QT34raVyoeimIKl/ITRptmFHh0KbSyC9Y=; b=HkUW3ndJ1f6uiKVqwKCTXPby46QducYlvB9trdpxZLqxRLDvz0jgCS5kKbhMtTV/Dptliy sqUkyVMbINbdofO+klo7zWN2Rx8d1pIjJTSOtC2kLsAdw6huk1si+JwWE0Q7oWUbp8mAKd rb3NhIdrxx5F40q22ajF31ZdoeL3KC7rkiuTATbIH3jvRrZnyES8qTpHY8rV2Dd3vFhonm zXzmKTHBRTLhRClsZ0lzeHT/cf7vkLJVANht6eFdHbtsbfS8ISX/srpma14W2Lg4zc33ew 6WjA+jA7+jYL9pZVNeB5Ss+Ier81kRzg9J0QIoxGnUdTIpGF/AbTzH6o5h5Ojg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645648333; a=rsa-sha256; cv=none; b=pZXEED6fuoP179YtiEwnFgg6WlmB6KDRyke1bIuP+vZJ6jTrTpBW3gbSzPmf8ZiM/EpUCH l7MFFUR6vHA//V5mqZvuVzcA2UD5wnuPErxaioDjZ+qw0gZTLGUNo1auEx1OSsOQ07H4Zi b6DdLMyI4EzhNNW83lOl2K8JlNGm9z2y/1Xq2YvvQSDBI002WtxfxtvSAdTUcUkfSHbsYp q3MhXQF/kjPZZ7uXgTphkQz0fJI+npy2ysxI4hDZscQ0lQbxyqp9hDSEMyT6RcvmcwKxUd qV9lGy19hXN4HblljMd2PjJLnyU86MPTSbQExmTyjSzu19HhyB5gHP9Efj182g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="m214/JV4"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="m214/JV4"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B7CA638906 X-Spam-Score: -1.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: UqwYJGlO8RNt Hi, Am Mittwoch, dem 23.02.2022 um 13:55 -0500 schrieb Philip McGrath: > To try to be concrete, I made the patch below as a mock-up of part of > your earlier suggestion (IIUC): > > On 2/20/22 04:03, Liliana Marie Prikler wrote: >  > Inside chez-and-racket-bootstrap, define (make-) > functions for >  > the following: >  > - chez-bootstrap-bootfiles, chez-for-racket-bootstrap-bootfiles: >  >    Taking version and origin. >  > - racket-vm-cgc: Taking version and origin. >  > - racket-vm-bc: Taking racket-vm-cgc. >  > - racket-vm-cs: Taking racket-vm-bc. > >  > Inside racket, define %racket-version, %racket-origin, racket- > minimal >  > and racket.  It'd also be good if you made local definitions >  > (define racket-vm-cgc (make-racket-vm-cgc %racket-version %racket- >  > origin)) >  > (define racket-vm-bc (make-racket-vm-bc racket-vm-cgc)) >  > ... >  > in this file. > > This applies on top of v4, or I've put it at > < > https://gitlab.com/philip1/guix-patches/-/commit/982fe7cfb4d33103ee611acc310e3225ccf35852 > > > if that's easier for anyone: To be fair, the issue here is with my proposal, which doesn't completely thunk through. I clarified later on that it would need another pair of brackets or – if that's easier for you – commented on the commit you've linked. > Overall, I certainly agree that duplicating the definition of > `%racket-version` is not ideal. I'd be glad for you or anyone to > improve the situation, and I'll try to get my head around Maxime's > email about the underlying semantics. > > But I am confident that v4 of this series is at least not broken, if > perhaps not maximally beautiful. Especially given that I, for one, > have tried things that initially seemed correct only to discover > subtle problems later, I think it would be better for any refinements > to come in follow-on patches later. I can understand the sentiment, but there are some things that still don't feel right for me – for instance the fact, that seemingly unrelated modules now have to pull in racket bootstrap sounds like a recipe for trouble. The final patch in the series also still does too much for me to wrap my head around, which makes it difficult to audit. Therefore, one question I have w.r.t. updating Racket is whether we could theoretically bump the version while keeping the old bootstrap, and then adjust the bootstrap by adding all the packages you've made. It does seem to be an all or nothing deal when doing the bootstrap first, but that need not necessarily hold for bootstrap second. Also, accepting for a moment that we might have to move chez-scheme and other important things into chez-scheme-and-racket-bootstrap (even though I'm not really content with it), I still wonder if we could introduce chez-scheme-for-system first (defined as simply chez-scheme initially) and adjust the callers, then move chez-scheme while keeping the function in chez.scm and finally do the magic with making it either chez or racket. I know I have a tendency towards being overly cautious when it comes to pushing big changes, so if that's the case I'd be happy if someone else were to take over. That said, I do feel somewhat lonely at the moment despite the many people specifically mentioned in "To:" and "Cc:", so I'm somewhat content with moving slowly for now. Cheers