unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38224] [PATCH] gnu: kpmcore: fix dependencies
@ 2019-11-15 20:16 Andrius Štikonas via Guix-patches via
  2019-11-16  8:52 ` Hartmut Goebel
  2019-11-17 15:28 ` bug#38224: Superseded Hartmut Goebel
  0 siblings, 2 replies; 7+ messages in thread
From: Andrius Štikonas via Guix-patches via @ 2019-11-15 20:16 UTC (permalink / raw)
  To: 38224, h.goebel; +Cc: Andrius Štikonas

* Add kauth, kcoreaddons, kwidgetsaddons
* Remove kconfigwidgets, kio
---
 gnu/packages/kde.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 79eb20cb59..dcce02e467 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -489,9 +489,10 @@ cards.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("kconfigwidgets" ,kconfigwidgets)
-       ("kio" ,kio)
+     `(("kauth" ,kauth)
+       ("kcoreaddons" ,kcoreaddons)
        ("ki18n" ,ki18n)
+       ("kwidgetsaddons" ,kwidgetsaddons)
        ("qtbase" ,qtbase)
        ("qca" ,qca)
        ("util-linux" ,util-linux)))
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#38224] [PATCH] gnu: kpmcore: fix dependencies
  2019-11-15 20:16 [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
@ 2019-11-16  8:52 ` Hartmut Goebel
  2019-11-16 23:13   ` [bug#38242] " Andrius Štikonas via Guix-patches via
  2019-11-16 23:14   ` [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
  2019-11-17 15:28 ` bug#38224: Superseded Hartmut Goebel
  1 sibling, 2 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-11-16  8:52 UTC (permalink / raw)
  To: andrius, 38224

Hi,

 the patch lloks good, but please adjust the commit massage to the
format we use. Just have a look at other packages adding or removing inputs.

Do you have commit permissions?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#38242] [PATCH] gnu: kpmcore: fix dependencies
  2019-11-16  8:52 ` Hartmut Goebel
@ 2019-11-16 23:13   ` Andrius Štikonas via Guix-patches via
  2019-11-17 15:27     ` bug#38242: Superseded Hartmut Goebel
  2019-11-17 15:30     ` [bug#38242] Merged Hartmut Goebel
  2019-11-16 23:14   ` [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
  1 sibling, 2 replies; 7+ messages in thread
From: Andrius Štikonas via Guix-patches via @ 2019-11-16 23:13 UTC (permalink / raw)
  To: 38242, h.goebel; +Cc: Andrius Štikonas

* gnu/packages/kde.scm(kpmcore): Add kauth, kcoreaddons, kwidgetsaddons.
  Remove kconfigwidgets, kio.
---
 gnu/packages/kde.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 79eb20cb59..dcce02e467 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -489,9 +489,10 @@ cards.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("kconfigwidgets" ,kconfigwidgets)
-       ("kio" ,kio)
+     `(("kauth" ,kauth)
+       ("kcoreaddons" ,kcoreaddons)
        ("ki18n" ,ki18n)
+       ("kwidgetsaddons" ,kwidgetsaddons)
        ("qtbase" ,qtbase)
        ("qca" ,qca)
        ("util-linux" ,util-linux)))
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#38224] [PATCH] gnu: kpmcore: fix dependencies
  2019-11-16  8:52 ` Hartmut Goebel
  2019-11-16 23:13   ` [bug#38242] " Andrius Štikonas via Guix-patches via
@ 2019-11-16 23:14   ` Andrius Štikonas via Guix-patches via
  1 sibling, 0 replies; 7+ messages in thread
From: Andrius Štikonas via Guix-patches via @ 2019-11-16 23:14 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 38224

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi,

I've just updated my patch. Hopefully, commit message is now in the right format.

I do not have commit permissions to guix repository, in fact this would be me first patch.

Best,
Andrius

2019 m. lapkričio 16 d., šeštadienis 10:52:49 EET Hartmut Goebel rašė:
> Hi,
> 
>  the patch lloks good, but please adjust the commit massage to the
> format we use. Just have a look at other packages adding or removing inputs.
> 
> Do you have commit permissions?
> 
> 


-- 
I encourage the use of end to end email encryption

GPG key:   https://stikonas.eu/andrius.asc
Fingerprint:  1EE5 A320 5904 BAA2 B88C 0A9D 24FD 3194 0095 C0E1

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#38242: Superseded
  2019-11-16 23:13   ` [bug#38242] " Andrius Štikonas via Guix-patches via
@ 2019-11-17 15:27     ` Hartmut Goebel
  2019-11-17 15:30     ` [bug#38242] Merged Hartmut Goebel
  1 sibling, 0 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-11-17 15:27 UTC (permalink / raw)
  To: 38242-close

Superseded by https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38224

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#38224: Superseded
  2019-11-15 20:16 [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
  2019-11-16  8:52 ` Hartmut Goebel
@ 2019-11-17 15:28 ` Hartmut Goebel
  1 sibling, 0 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-11-17 15:28 UTC (permalink / raw)
  To: 38224-close

Superseded by https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38242

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#38242] Merged
  2019-11-16 23:13   ` [bug#38242] " Andrius Štikonas via Guix-patches via
  2019-11-17 15:27     ` bug#38242: Superseded Hartmut Goebel
@ 2019-11-17 15:30     ` Hartmut Goebel
  1 sibling, 0 replies; 7+ messages in thread
From: Hartmut Goebel @ 2019-11-17 15:30 UTC (permalink / raw)
  To: 38242-close

Ups, I'd send the "superseded" message to the wrong isse.

This one has superseded 38224.

Merged as 9c8814909a8bb5f57044eecbf4a6843e66beca07

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-11-17 15:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-15 20:16 [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
2019-11-16  8:52 ` Hartmut Goebel
2019-11-16 23:13   ` [bug#38242] " Andrius Štikonas via Guix-patches via
2019-11-17 15:27     ` bug#38242: Superseded Hartmut Goebel
2019-11-17 15:30     ` [bug#38242] Merged Hartmut Goebel
2019-11-16 23:14   ` [bug#38224] [PATCH] gnu: kpmcore: fix dependencies Andrius Štikonas via Guix-patches via
2019-11-17 15:28 ` bug#38224: Superseded Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).