From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SJ9WIQvGOGLFOAEAgWs5BA (envelope-from ) for ; Mon, 21 Mar 2022 19:38:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UIHsGQvGOGLcaAEAG6o9tA (envelope-from ) for ; Mon, 21 Mar 2022 19:38:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 128ED370C2 for ; Mon, 21 Mar 2022 19:38:03 +0100 (CET) Received: from localhost ([::1]:41422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWMun-0002ZG-VA for larch@yhetil.org; Mon, 21 Mar 2022 14:38:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWMtq-0002Gf-Cq for guix-patches@gnu.org; Mon, 21 Mar 2022 14:37:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWMtq-00034C-4G for guix-patches@gnu.org; Mon, 21 Mar 2022 14:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWMtp-00024J-SM for guix-patches@gnu.org; Mon, 21 Mar 2022 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54352] [PATCH] services: dnsmasq: Add more options. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Mar 2022 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54352@debbugs.gnu.org, Remco van 't Veer Received: via spool by 54352-submit@debbugs.gnu.org id=B54352.16478878057923 (code B ref 54352); Mon, 21 Mar 2022 18:37:01 +0000 Received: (at 54352) by debbugs.gnu.org; 21 Mar 2022 18:36:45 +0000 Received: from localhost ([127.0.0.1]:38288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWMtZ-00023j-5n for submit@debbugs.gnu.org; Mon, 21 Mar 2022 14:36:45 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:57776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWMtX-00023a-Jp for 54352@debbugs.gnu.org; Mon, 21 Mar 2022 14:36:44 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 96ci270024UW6Th066cidJ; Mon, 21 Mar 2022 19:36:42 +0100 Message-ID: <2287729e13ea8689713cefe61e28abba9e817308.camel@telenet.be> From: Maxime Devos Date: Mon, 21 Mar 2022 19:36:41 +0100 In-Reply-To: <8735jbjpoj.fsf_-_@gnu.org> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jbjpoj.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-sSG/NNMlYvSg1cQHB3Z5" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647887802; bh=GATs9xizJsK0vcXk+SJm6eqRKzH/974e/tsU9TGiL4E=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZbSQ2Y4JxCy/8KxqrRMLlcg+M+YxNU9eJJMHdLGl5W2gmuhijXd57K/2b0L5vcafe l4WRo4PDW+f+AeGCnVy+A4KyigrhbWhLvevL0ht6m3znoXf9tJ6E64xEaDo2HIeHz8 wyoK2CnmHFFpIYNsWBaJlCwaAaadb00y4BDMmTZ57rqoFHXRgAmmjM2+Fv4ON6KKaD unHLlybGGMx8WR9ZnZ5F9Na2wQzvh+KjDjQyFs3cUKt0p7OtG6YiTD5E1a2ktyBstL 3sI+pGsz6E+mtbYs7YNs/cB0K9ISbjYg2FPl9P/gRM2pcDAe1HyOg7YIoP0v4yMfZU fHMXbHt57Qyvw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647887883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GATs9xizJsK0vcXk+SJm6eqRKzH/974e/tsU9TGiL4E=; b=M06mpKhnYFKQCktpAm7kCshTpGlHvv7S7VxTmVRGdxSsQl/7xrIfjgO/W5TR4TfeDgqhzO AN2wmXu2iGRYCRYasue+zPEsZ1Wnh1++WL+Y7FjVS+g6Ot5BIlTzmoaiVev1nbdILgponr nGjwe5Q5uvGelYkX0+h5jw76VXRtQ/OpUjACuDjUC7pxg2mzrCPBX7mYoZZKV9wvYhVdOW bmqaMmasgqGyKQ7Nb73oTn3llEkLxXUTYq/s8JdruOguC/m/3C9z72O7CMshtGlUivIIPy pEsOJ8Ehkr1L+4Zyaw2jHojKj37Me1vD4CAn1KySxSWok8LrQuv09oOajsSCRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647887883; a=rsa-sha256; cv=none; b=VYHml4DJWbLNc/QTGW+NInqO4GncqP2o6ou92OFBo5ZLbFsySGrj79SWtwvxMxWO/pz4Uc 9sFJi9ZcWXd3iIFz/sEAbGB0WQOHXBIsYWM62hHzWKy5DVeXxKODftuT15ANTtN34x0MkL EtVu2se0zf98ZJIU9w46kPn9pDOzhby7TfVSzRUf7x130JLEECvVV9H7FbtSO6f0+muaOt OsGIkYbqmxuzGdx7PrKfGoIX/OErlBuNTwiTdz/8vXicEzesDvpjLQDIaSXpDhWpiZvX6u jBVH9vB8q6eVXyINNZpeZ5TghZzMCJZzfNzHR5yKCgmz6JrJC1hAX6h3ZQlb0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ZbSQ2Y4J; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.68 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ZbSQ2Y4J; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 128ED370C2 X-Spam-Score: 3.68 X-Migadu-Scanner: scn1.migadu.com X-TUID: NFHBojm67zDd --=-sSG/NNMlYvSg1cQHB3Z5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op ma 21-03-2022 om 16:22 [+0100]: > I think this suggestion is beyond the scope of this review: we=E2=80=99ve= never > used sanitizers like this before (or almost), and this particular piece > of code doesn=E2=80=99t use them. >=20 > Also, with the recent discussion about the introduction of contracts, > I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99re = available. Seems reasonable to me, given that the specifics weren't discussed yet, although _everywhere_ (for all procedures, records, ...) seems a bit much, unless you meant every field of the dnsmasq record. Greetings, Maxime. --=-sSG/NNMlYvSg1cQHB3Z5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjjFuRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7riyAP467NKyMBcT8gTFjtPHT/4blClG JLQfTZKajoDOOVamOQEA3unPRxZ7Hgq47GZD+WKOVw2tX8cHalndJry7fKRPGgE= =Z1db -----END PGP SIGNATURE----- --=-sSG/NNMlYvSg1cQHB3Z5--