From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id rDeaNqseNmF7YQAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 15:59:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UE6jMaseNmEIMwAAB5/wlQ (envelope-from ) for ; Mon, 06 Sep 2021 13:59:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79168EECE for ; Mon, 6 Sep 2021 15:59:07 +0200 (CEST) Received: from localhost ([::1]:43436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNF9O-0003Vt-Ia for larch@yhetil.org; Mon, 06 Sep 2021 09:59:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNF9K-0003VN-Cv for guix-patches@gnu.org; Mon, 06 Sep 2021 09:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNF9K-00061T-58 for guix-patches@gnu.org; Mon, 06 Sep 2021 09:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNF9K-0004YC-5D for guix-patches@gnu.org; Mon, 06 Sep 2021 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50239] [PATCH core-updates-frozen] gnu: diffutils: Fix signal processing. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Maxime Devos , 50239@debbugs.gnu.org Received: via spool by 50239-submit@debbugs.gnu.org id=B50239.163093671517460 (code B ref 50239); Mon, 06 Sep 2021 13:59:02 +0000 Received: (at 50239) by debbugs.gnu.org; 6 Sep 2021 13:58:35 +0000 Received: from localhost ([127.0.0.1]:54142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNF8s-0004XX-KN for submit@debbugs.gnu.org; Mon, 06 Sep 2021 09:58:34 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:12794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNF8q-0004XH-Gf for 50239@debbugs.gnu.org; Mon, 06 Sep 2021 09:58:33 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 9A229F85; Mon, 6 Sep 2021 15:58:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1630936705; x=1632751106; bh=OYB6+jLv790IZkZZ7FqdY6FWKvZ1VC7FQLq rs2bqmz4=; b=1THAR54mtYlwbo8ZVODkorrQrmt7DwZtK9en973A2LTMu3JwOfm vP4O8FFtRu0lHExZO9QQXnu7mGyohBummkhFOM+lUpDwq/39M01Dq2hErd+ntUr6 RgMnOCIibSdxmMJ/OPdQh7boJ5SVgHgVbW3ddFHOpD2rDtDgJJnMQeoSEJB3uprk ont1TsRTJIVJiUPrET4Kg3bFE5nV3eDag8EHP7DWym7pJJDZbCrEPdkKbiGUkwrt ekS5Qz8LPF+sYzy7RtBQiIUx05vtpisyeP77sriB1jiyLPUvpmKFDm7y0mhO/aio QL0cX3mWTS+GLGEeWQOczC4RuMLUJmnRQSrfdz9/PhxidFGOFK1Dyaq/k6f4RE2+ +tQH+XnQ2aub9fi4wcOWEX2NGIoU9BP2Ih2nVAP+SRMhUYRsJTcnrz2xIlHm25lG oVsipD6OY/hi3NaF7n0mW1VJa6YEuCcCoxJ8rzfivDw6HE1qBHEbYg8E9jkL3Tkg JI9F1ztLVYiL1dWw0T6HKWhDRkzOY2sJuyNzUiq42eYZbinydofDpgz0DeqYfM0h RD3iPb8mN8psEHwqNh55bSJNwOiUT28GDoNcHg7PHqdKIK4SPQTTRuUVToI4MS7O CQqUNG1ghBMGKPpbML/MRJ1q5NeEz+gZQC6LWo7rQsTnOTAeRn2Il5wI= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XYRNNsk5R0op; Mon, 6 Sep 2021 15:58:25 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 9F5C218D; Mon, 6 Sep 2021 15:58:25 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 5A76C2FBD; Mon, 6 Sep 2021 15:58:24 +0200 (CEST) Date: Mon, 06 Sep 2021 10:58:16 -0300 Message-ID: <20395088.hJciOmStQJ@popigai> In-Reply-To: <877dft9auv.fsf@gnu.org> References: <20210828164357.8868-1-bauermann@kolabnow.com> <877dft9auv.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630936747; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OYB6+jLv790IZkZZ7FqdY6FWKvZ1VC7FQLqrs2bqmz4=; b=d+ehEpQVPvBFk0Lh/HQEZNXrjZn6E+yIV/LcX8vAfXQGgrJTXo9uO3bw4YY8NHtAnNnMZF K9nNbofknWfaKs0PbjRKJvR2XdSp9wqojgEaIHZhkuwi8BJysODxizmXuNqUIEWUnAlF1a 4QDcmIQtVDNGwUj3M3jSDoplQJ7QEWmH7YSs1HIGWFZVKsNCzyrZjssc8zUFkDLsmlYM1W L8DSq/sGCFwWlmwUYvBmrwfah82f+BYM9LM3LjgrRGaEZr5mrnNeUillYJgGakHwlxVkux BQ2pjRHZlRf78x4j2ecZ3u8eUorWJfyT/Y77AmiwHPkCXslKhp3YTkWd17zkCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630936747; a=rsa-sha256; cv=none; b=auPfwD5VxEtEersmW8CtR9y1VFihC47n+T/wzT2UAC75cZu9qRFyBNO6miWz1aevlpxaAT J7Cvlcau4pAsm1ywG+ET5O993NHUkc/tmJp10Tm3fOhomqx2p2hvi3V6sMyHBX+UixpVjP 2pu4ZwCgKvn7fpFoMTooynUFch9q/jZLAWYhg7DBCxxiwHeFhd8SpDfQZr4TkJ4YwSBlyH Pzv2nxESEv09FRMbnCkJcrHzoYgKojwZnOFqz7/MCoWpumZRDsw99zufN37L/WQMz2iq+G NwfYaclIm68EHn6Di9g8qFRKkVhLJ1PBTEeXxwKtYcL4mMiNeNVKE2DLnw372w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=1THAR54m; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=1THAR54m; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 79168EECE X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9k8IZuePdkTq Hi Ludo, Em segunda-feira, 6 de setembro de 2021, =C3=A0s 08:55:52 -03, Ludovic Cour= t=C3=A8s=20 escreveu: > Hi, >=20 > Thiago Jung Bauermann skribis: > > This fixes the build of diffutils on powerpc64le-linux, which currently > > fails more often than not. The patch I=E2=80=99m adding here isn=E2=80= =99t being > > shipped by Debian and hasn=E2=80=99t been seen by upstream yet. I just = brought > > it to their attention here: > >=20 > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34519#11 >=20 > Thanks for working on this! You=E2=80=99re welcome. Thank you for reviewing the patches! > > I=E2=80=99m not familiar with the diffutils code base, but FWIW I analy= sed > > the patch and it looks very reasonable to me. To be honest I=E2=80=99m = not > > sure if it completely fixes the race condition or just makes it much > > less likely to happen, but in any case I can=E2=80=99t hit the race con= dition > > anymore. > >=20 > > In addition, since all it does is add a new call to the function which > > checks and processes any pending signal, I don=E2=80=99t think it can c= ause > > any harm. > >=20 > > Finally, this patch is based on top of the one which updates diffutils > > to version 3.8: > >=20 > > https://issues.guix.gnu.org/50233 > >=20 > > The fix works equally well in version 3.7 so if you think it=E2=80=99s = not > > worth updating diffutils I can rebase this patch on top of current > > =E2=80=98core-updates-frozen=E2=80=99. >=20 > Normally we won=E2=80=99t update diffutils on =E2=80=98core-updates-froze= n=E2=80=99. Yes, it makes sense. > Thus, could you adjust this patch so that (1) it applies on > =E2=80=98core-updates-frozen=E2=80=99, and (2) it doesn=E2=80=99t change = derivations on other > platforms (thus, the patch needs to be applied from a build phase)? Sure, no problem. I=E2=80=99ll do that. Thanks for the tip about having to = apply=20 the patch from a build phase. > Bonus point if there=E2=80=99s an upstream patch to use, as Maxime sugges= ted. There isn=E2=80=99t one for now. We have three alternatives if the situatio= n=20 doesn=E2=80=99t change by the time =E2=80=98core-updates-frozen=E2=80=99 ge= ts merged: 1. Apply this patch. 2. Disable the =E2=80=98colors=E2=80=99 test. This is what Debian is doing.= It=E2=80=99s a bit=20 unfortunate in that we=E2=80=99re disabling a test that just did its job of= finding=20 a bug, but on the other hand the bug is minor (the terminal is left in a=20 wrong state if =E2=80=98diff=E2=80=99 is interrupted in the middle of print= ing colored=20 output) and easy to work around (just run =E2=80=98reset=E2=80=99 if that h= appens). 3. Do nothing. If the diffutils build fails on the CI, restart it until it= =20 succeeds. :-) That is my personal order of preference, but option 1 carries a slight risk= =20 in that we would be shipping a patch that isn=E2=80=99t =E2=80=9Cbattle tes= ted=E2=80=9D, so the=20 other options are very reasonable too. =2D-=20 Thanks, Thiago