From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kCe1KbiZYmeJAwAAqHPOHw:P1 (envelope-from ) for ; Wed, 18 Dec 2024 09:45:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id kCe1KbiZYmeJAwAAqHPOHw (envelope-from ) for ; Wed, 18 Dec 2024 10:45:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=dc4L9rbC; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=VJem4ntP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734515128; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=WDozeRyoJ3baWr66l3ycMyWJjEVsDQMpGkJq9DIs1i8=; b=sblYJdZVHodtVexUW0vkfitJIbK6BngcgozCehblXt1UqtZTa42aZiTYpVsgEUkwPFUKCW 4S6EjFLWRcryo9yxXgQE9WBQdRUUWW5PQDX6SKxrGxY/cHFVmMZ2n6pN/DkwFxR+uKN4Ag uFpr3xv4aeb33raGKDlE8erfhR19x8gyvVt6I5cXjkkIsrorl4DAZ5/BVABxsr/ReGsJ84 yI9hcRysmJFM1d08SEi3qajKUTOcjN+4CQRmDWsnBwHRSQTB8N1YCxOMf/5PLx+2VIx1zd BNHW+XbayHa2fEsToB0NLjFU37yG+R6zpzzD3wJOiluvPbbTFWkkfEIGX8wM5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=dc4L9rbC; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=VJem4ntP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734515128; a=rsa-sha256; cv=none; b=OKv8LL6NftHZonLzaGj6mF9864aza20bMYkVD4iPuF4Zo0dmhvWEwFBvNvbzvJcl3JjJDf c8t+kqeWS26DYfpeaLIsEOZJLSEV1WVu+VedbrSjFUMNBky6z03eNsVGrTItwF5oZO84d4 TsiimfOmbqsupDaasDbwbyq7IX+ueARt2LyAtUHt/Hq6l5eqUEFq2DFSRHbdBndRmYxfvq Gs8jXIZ68SMciVLCopGaTrGv0oWWDnvSqstt1HCntcik/oMJ/Jm/luxXERBlrr2pSPrB7f xxAW5+LFPMkzSUoMZZn6vVJxLmJCMrJjkXJrOJJFJkvRzgNZ396PgETAfmco/g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EB9318167 for ; Wed, 18 Dec 2024 10:45:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNqc6-0003cf-7v; Wed, 18 Dec 2024 04:45:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNqc3-0003aI-93 for guix-patches@gnu.org; Wed, 18 Dec 2024 04:45:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNqc2-0004lO-UR for guix-patches@gnu.org; Wed, 18 Dec 2024 04:45:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=WDozeRyoJ3baWr66l3ycMyWJjEVsDQMpGkJq9DIs1i8=; b=dc4L9rbCUbNvnByZRxBUwAySoK0qR4ehdNIUlSk7Sq6q8IlwZrveDuEtbb64gZf+T7NrcUDUtkZGeBiGkoxXMPGAAYseOmNJrm82D8oI5xHs0SJMp4XeHmN8s87+Z4dOy6egg7x8OJWtvapSFV0VBljb2oHvRBHM8KAAzZmY3YY6Y3Lk2Mcqzjr1Qo7MGNRQrc/eFlNLt7yKKAb0c+mA4AjybVqKi+70tbojIKtCc8ns72wkJpHQlqd92Wnho0iAON8d/IdzJ7lLrqLQYeb/5dfN2H4s/MaxVRcepMaZldRJJmLpRu7PVavGuvKji2meHy9zsSwi8eo0OOmS08mvJA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNqc2-0000gg-GY for guix-patches@gnu.org; Wed, 18 Dec 2024 04:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74940] [PATCH] gnu: openmpi-4: Fix hardcoded call to ssh command. Resent-From: Romain GARBAGE Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Dec 2024 09:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74940 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74940@debbugs.gnu.org Cc: ludovic.courtes@inria.fr, Romain GARBAGE X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17345150812590 (code B ref -1); Wed, 18 Dec 2024 09:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Dec 2024 09:44:41 +0000 Received: from localhost ([127.0.0.1]:33438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNqbd-0000fd-R5 for submit@debbugs.gnu.org; Wed, 18 Dec 2024 04:44:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:40468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNqbY-0000fH-No for submit@debbugs.gnu.org; Wed, 18 Dec 2024 04:44:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNqbX-0003X0-MS for guix-patches@gnu.org; Wed, 18 Dec 2024 04:44:31 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNqbU-0004fG-9M for guix-patches@gnu.org; Wed, 18 Dec 2024 04:44:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WDozeRyoJ3baWr66l3ycMyWJjEVsDQMpGkJq9DIs1i8=; b=VJem4ntPPuHYduPeLwRzduuZErJu+WP9gXYx+JtfqPu4gfgOpGhHvzd7 NuUSlTT/Vlxl29Q1/O2bNhvfUIGrgxHRFH6eXr1AYA012vd6mlaIBG8OZ 0PYxvyd1jnel5cxwSxVBsDS6UhkkW/TvcaQ4+Wi/0ope7Vm9ZRUTAxoYO 4=; X-IronPort-AV: E=Sophos;i="6.12,244,1728943200"; d="scan'208";a="104627099" Received: from 91-160-179-8.subs.proxad.net (HELO localhost.localdomain) ([91.160.179.8]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2024 10:44:23 +0100 From: Romain GARBAGE Date: Wed, 18 Dec 2024 10:37:39 +0100 Message-ID: <20241218094410.3097-1-romain.garbage@inria.fr> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=192.134.164.104; envelope-from=romain.garbage@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.67 X-Spam-Score: -2.67 X-Migadu-Queue-Id: 2EB9318167 X-TUID: Z3KVxs0HNEp7 This patch fixes a runtime error when launching an MPI program using mpiexec/mpirun in an environment where the ssh command is not available. * gnu/packages/mpi.scm (openmpi-4)[inputs]: Add openssh-sans-x. (openmpi-4)[arguments]: Fix path in code. Change-Id: I65255186c37b6eaba3c283c7046163abc2cb38b7 --- The runtime error can be reproduced with: ---8<------------------>8--- $ guix shell -C openmpi@4 hello -- mpirun -np 2 hello -------------------------------------------------------------------------- The value of the MCA parameter "plm_rsh_agent" was set to a path that could not be found: plm_rsh_agent: ssh : rsh Please either unset the parameter, or check that the path is correct -------------------------------------------------------------------------- [guix-A102:00001] [[INVALID],INVALID] FORCE-TERMINATE AT Not found:-13 - error plm_rsh_component.c(335) ---8<------------------>8--- The size of the closure as given by guix size is 406.7 MiB after the patch vs 398.3 MiB before the patch. --- gnu/packages/mpi.scm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm index 661531abb9..60a1952809 100644 --- a/gnu/packages/mpi.scm +++ b/gnu/packages/mpi.scm @@ -53,6 +53,7 @@ (define-module (gnu packages mpi) #:use-module (gnu packages parallel) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) + #:use-module (gnu packages ssh) #:use-module (gnu packages valgrind) #:use-module (srfi srfi-1) #:use-module (ice-9 match)) @@ -220,7 +221,8 @@ (define-public openmpi-4 gfortran libfabric libevent - opensm) + opensm + openssh-sans-x) (if-supported psm) (if-supported psm2) (if-supported ucx) @@ -291,6 +293,13 @@ (define-public openmpi-4 '("./ompi/mca/io/romio321/src/io_romio321_component.c") (("MCA_io_romio321_COMPLETE_CONFIGURE_FLAGS") "\"[elided to reduce closure]\"")))) + (add-before 'build 'ssh-absolute-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "./orte/mca/plm/rsh/plm_rsh_component.c" + (("mca_plm_rsh_component.agent = \"ssh : rsh\";") + (format #f "mca_plm_rsh_component.agent = \"~a : rsh\";" + (search-input-file inputs + "bin/ssh")))))) (add-before 'build 'scrub-timestamps ;reproducibility (lambda _ (substitute* '("ompi/tools/ompi_info/param.c" base-commit: cd018214a3c0319451ab46855ea395b2be6a15dc -- 2.46.0