From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2FUiMjR1T2c9OAAAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Dec 2024 21:16:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2FUiMjR1T2c9OAAAqHPOHw (envelope-from ) for ; Tue, 03 Dec 2024 22:16:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="JoTeIR6/"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bzNg8GzQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733260595; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=kJ/yeL4J6T9NCJt9UgcQNbVex1oYSg5GFr+OTwNIu8ZG4vLHzLGTmGrB9W+UluIl7XkPic x7WSlffF4yvDjS2fSK/KYNbmLwBrAYQ1hjc+ygfjJNKKLXJf/gICSInhmQvDqCKtVGOb5f EEb1JEaK+Dgf38275x1KxT2BvSnxfUW9qM6xcCCpwzH+Z1WsloSNhjC4Zz0NzYfzsAj7ZE iAhf9o+5SYPK3GlEb/rbYXPkEsUadeWuEbs+6vjay31lWdYpGUg+r1ouDaKmRkU/LCYhOB PQQP3sLQuxlW+/S6EYMtlkSrJqAd3nPVhZ5a9dRb5O3dW1MG37PNvd6gvCQkXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="JoTeIR6/"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bzNg8GzQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733260595; a=rsa-sha256; cv=none; b=O5mE1rai2lGL3POQxbsB9Jo2hoOGQ1+XNNIYfHouEC9Iw9nrfPvUpFyWp7KCE8hgapX1xs gUu6yenhLG62PgmFrO4DntJekmbZvR2cKYBpYYRIhWxcD8eXW3lxOMvyaeGnn1CZTWa1B/ mP+L1mmpxBzs9kVV0VujJSSQSIzYqJSypK2VRYsOXa5+GqRxVpTQgBkvuvsA5Crq2AB6kB aYlDiG3B3kPz6mw1nO67jtNbz9yml4PZAZsxcZ55BRhatcelug7Uqt/43nz4wAlQsYfnSU Nqx1/CSdWA+fyLnskNlJmdzq7/2cwHh5pqB4i6ZKq4W8KlOo58IK5J/uNP53FQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AB997CB16 for ; Tue, 03 Dec 2024 22:16:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIaFm-0008AF-Mg; Tue, 03 Dec 2024 16:16:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIaFX-00085K-9k for guix-patches@gnu.org; Tue, 03 Dec 2024 16:16:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIaFX-0003vV-0n for guix-patches@gnu.org; Tue, 03 Dec 2024 16:16:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=JoTeIR6/evj6GRLg+iVutm984tAVcALY8ZXVKQSNOkEB3NzDhERR2ICJM42Ao0jRfykK4JDEuPdNACZRxRVklgOpyw5jCYUZulvgsQFYMuqCAIJRDTX62HwxZM6vc6MJ668mJHDx9CU55jDiBvnHmvTtdcXqu7Ge/oyR28mMC8lARJcSODTFbeMPSrpGFP5evQHFy5KCpzptrJK+qQlgynwVDW54snFQ19Qxv7KM6oH8gmyCndLFqA63NMtflCoa2ORFu5dZi1bndPGLLwF5cmD4rKgoUCc5LUwKL0kXX+Z2jQYf9YVRDyPJZ2qjRrXTLGBPEtcPL3zI2DS665WFFg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIaFW-0004N1-KF for guix-patches@gnu.org; Tue, 03 Dec 2024 16:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74677] [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains Resent-From: Sergei Trofimovich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Dec 2024 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74677 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74677@debbugs.gnu.org Cc: Sergei Trofimovich X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173326053016753 (code B ref -1); Tue, 03 Dec 2024 21:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2024 21:15:30 +0000 Received: from localhost ([127.0.0.1]:33158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIaEz-0004M8-HZ for submit@debbugs.gnu.org; Tue, 03 Dec 2024 16:15:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:44506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIaEx-0004Ly-5s for submit@debbugs.gnu.org; Tue, 03 Dec 2024 16:15:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIaEw-0007j9-P9 for guix-patches@gnu.org; Tue, 03 Dec 2024 16:15:26 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIaEv-0003Za-4J for guix-patches@gnu.org; Tue, 03 Dec 2024 16:15:26 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-434a1fe2b43so54354765e9.2 for ; Tue, 03 Dec 2024 13:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733260523; x=1733865323; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=bzNg8GzQwYIxw2BXHsSr+UBTvqSgc3JzyegPJ6TIPpRso+7liWCRDqThVzv5yDYu9y 3U1b0tAHfp/bDYtoQ0bPq2Q3kTzdz28z4NBGIpOxr1WW6hzBG2CcDaMvrEbKuKLTP5tS BsP62Nk5QoiDrN1CvbtpTOv5/OreTKaVROs80aa4wA1ZBK55Mn+tV9Y7gZnLmA2TfD0d TZaaPO5QaxUahcAM4NVXw448Un67KYebRcq5RPrXqwIG/IuxqQr/sAjWCNuW3L+Uo69w 80QWqkqI/8Dx3I5Xsu18f5eTiN7xRYS/JMUy2pLvSPuF+ODReVEmYBEEeUcAWramwWMI U+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733260523; x=1733865323; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=cfG47cxnO3dj1G9QClWWDOo74YrTYTCaYvizD0N8mss1xM8J0FoWGthmmEBTUCYWBu Nf3f9U4PBAjHtW33LmwVq/xPJVLATnuIxg6p2ES8R37tO1wvmyb3A7nfSCFamo7wltz8 K0nVwb2FiczveuNbPxSq9t+KU+A2YoTK1uhLq0N1U0FNLtixL/0ym4KVCb71uA2FDeWe BKrIQn0tUww+n22j+cDXEoV0wO6DInYhdI25GVU0FJ0PaLXCNRmclS5Pb1RwnOyKJ6ns 250VmN6gMdb19idgPVHebOqnu09kC23adWYco8wcUBCiCJ9UzWgO4YzfqRj+vBDzp2P8 jyqg== X-Gm-Message-State: AOJu0Ywv/FFoIaKuuns53LHxSFXrL89XC57pAj844QqzyXOddaDswdpO 3yTEqvVmHKLinyXdPcaKek046MGS7DwyT0YQRXyVjXKusNosx3qd X-Gm-Gg: ASbGncvBWiBPbHy2JtiuNBEhHs0xXWWRRvQwbDxvIoC1qbhigfsEUPg+valw+4+UpJV ttPEIa/ivO1ZgotZz7JFXA6ivyiCkg535ZO4rg6xsxfz4qmeS6hU6UQ8Um+8G68PhxslJtlWhq1 L23CyhM5U+dcRpbxA5NucRbRJSDRyjsVw2336CgnHp9Ox6yNJMAwU4BEJNZFj9my57eQ2XrOsvR bP0URiYpW7kB9zxQiTuKj7ceMyENiXSSYh139tTXg== X-Google-Smtp-Source: AGHT+IG0Im/y1b/QfKJVnt/14tQ+x/7WETaMNtCmRMzgJevuYhPncB+NmWjq4uJTivwye8JxupBFpg== X-Received: by 2002:a05:6000:2aa:b0:385:e8b0:df11 with SMTP id ffacd0b85a97d-385fd423e36mr3697249f8f.37.1733260523132; Tue, 03 Dec 2024 13:15:23 -0800 (PST) Received: from nz.home ([2a00:23c8:a613:101:8a9d:d969:1999:c879]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a4bbsm16697184f8f.48.2024.12.03.13.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 13:15:22 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 05977255A8141D; Tue, 03 Dec 2024 21:15:22 +0000 (GMT) From: Sergei Trofimovich Date: Tue, 3 Dec 2024 21:15:15 +0000 Message-ID: <20241203211515.1620700-1-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=slyich@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 2.08 X-Spam-Score: 2.08 X-Migadu-Queue-Id: 8AB997CB16 X-TUID: kW3it0smpcLG https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8a7bd211d21f06c1234fbb82bb905d202d58f598 introduced a build regression on Gentoo as: x86_64-pc-linux-gnu-g++ -Wall -std=c++11 -O2 -pipe -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,--hash-style=gnu -lgcrypt -o guix-daemon nix/nix-daemon/guix_daemon-nix-daemon.o nix/nix-daemon/guix_daemon-guix-daemon.o libstore.a libutil.a libformat.a -lz -lsqlite3 -lbz2 /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: nix/nix-daemon/guix_daemon-guix-daemon.o: in function `main': guix-daemon.cc:(.text.startup+0x62): undefined reference to `gcry_check_version' This happens because: - Gentoo linker is using --Wl,-as-needed by default - -lgcrypt is passed before actual use of it's symbols in `guix-daemon.cc` The change uses `LIBGCRYPT_LDFLAGS` as if it was `LIBGCRYPT_LIBS`. * nix/local.mk (guix_daemon_LDADD): Use LIBGCRYPT_LDFLAGS instead of unset LIBGCRYPT_LIBS. --- nix/local.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nix/local.mk b/nix/local.mk index 8a2b2b88e8..50368457dd 100644 --- a/nix/local.mk +++ b/nix/local.mk @@ -124,7 +124,7 @@ guix_daemon_CPPFLAGS = \ guix_daemon_LDADD = \ libstore.a libutil.a libformat.a -lz \ - $(SQLITE3_LIBS) $(LIBGCRYPT_LIBS) + $(SQLITE3_LIBS) $(LIBGCRYPT_LDFLAGS) guix_daemon_headers = \ %D%/nix-daemon/shared.hh -- 2.47.0