From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cEHxKuUhHWeObAEAe85BDQ:P1 (envelope-from ) for ; Sat, 26 Oct 2024 17:07:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id cEHxKuUhHWeObAEAe85BDQ (envelope-from ) for ; Sat, 26 Oct 2024 19:07:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VdtMIHDA; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b=jfsjEpM1; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729962469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=u6fHWnyMzXUH3aQr+EtwqemLF+OmlgMgek4SVaMYHEE=; b=uLQsG24Ct7ELFNPUiyyGXr3DFjpyfm432qsEDuFdES22WCA34EqIhuIhiXKi40JdXPbjM7 V7/1+B+j/Spk+/Fx96/L7lCcijFK/psL03lhahX+AYopN73fAuIAbeNKKsDgd5BnCu0Rh1 CEc5LkvDa2lpeCofYiV9Qxa0Bm5OlKEXSPdb0sxToF5Q92vrtDOyPB/IEsx3e23NGEG7IV mVRltUkbHUQOvL7n7TpaVrG3XdAxGr+DdYSWj64XFNoLwG9DkWPqb09XN58q64q0KSpZ1P km243RRQTcD9rbIekPf7eRhf372DvjJaAnfF59q98/BEjWNxYrrarhDSaxMfdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729962469; a=rsa-sha256; cv=none; b=AIXO4AIYaiSzkbLT/r8ntGkM4qiHxnvgFNsoqRRGfj+O7JSUBz5UqjFJB9rcg+2UJFJd2V wnn0YRb/jv7Bs9YSVJt0o3JcuT9W4x5+UtUMkQwZ+C7IOCGHoMzlIwTZIElBlkdGMj8esl o00qmMOkzUYZIayTf3n02bxKjRngx8r/Zr1D5OvtfeMIt5byF8pI5RlYzZQvAK/BV33Xd4 2k0mYrTgLjdxk35KTnwrWniBsS6CNM8NMnO+eZCFLql/IfvUSy0a9JgWwspij2NbG4sSvv wXLU53QLija+kIhHhbF2kTJB9CBgRBlVkqQQyHk4oMN09zKGxAneX26DDdUkwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VdtMIHDA; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b=jfsjEpM1; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 194695DB2B for ; Sat, 26 Oct 2024 19:07:49 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4kGD-0006zi-Bl; Sat, 26 Oct 2024 13:07:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4kGA-0006zY-Jk for guix-patches@gnu.org; Sat, 26 Oct 2024 13:07:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4kGA-0004Wf-AT for guix-patches@gnu.org; Sat, 26 Oct 2024 13:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=u6fHWnyMzXUH3aQr+EtwqemLF+OmlgMgek4SVaMYHEE=; b=VdtMIHDAg23uxQ5rsqRcbZc2nGAHjCx52Ni3yeSzukxNPkfBGHxbfICufXFJyjb1D/6FgWq6Xk3zOEqJ0bMXE5lGjB7Qrfm48jrDjRFoQ8u0Sm7Q8PeNInDAcVmmWBgk6y+AdWo+sx2PwuREaCgGp57dnbQ2f2P/cMvVckeBkZcz7XrsRG40mufsRYxEVggVHyKHunqBzHS1MDZwYLO1P9nZ5psk+rP6A9K6KcAWb8QHrmwd6+utVCFFFFVVFaVGcO5MIQ2/W9pXPT8H8ZWO08ONlo3z/NvYylEMSmky/uzDZAfVaEd8MFPWrFMb/s5+vgTkqKyAYYRFiFHRYhPyHw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t4kGg-0007qv-9B for guix-patches@gnu.org; Sat, 26 Oct 2024 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73918] [PATCH] gnu: yosys: Update to 0.46. References: <4da104f41f60809288973a250f258ddb724616c3.1729460353.git.jakob.kirsch@web.de> In-Reply-To: <4da104f41f60809288973a250f258ddb724616c3.1729460353.git.jakob.kirsch@web.de> Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Oct 2024 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73918 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73918@debbugs.gnu.org Received: via spool by 73918-submit@debbugs.gnu.org id=B73918.172996242730089 (code B ref 73918); Sat, 26 Oct 2024 17:08:02 +0000 Received: (at 73918) by debbugs.gnu.org; 26 Oct 2024 17:07:07 +0000 Received: from localhost ([127.0.0.1]:42404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4kFn-0007pE-Gv for submit@debbugs.gnu.org; Sat, 26 Oct 2024 13:07:07 -0400 Received: from cyberdimension.org ([79.143.250.36]:34472 helo=rockpro64.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4kFl-0007p4-1B for 73918@debbugs.gnu.org; Sat, 26 Oct 2024 13:07:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=dkim; bh=u6fHWnyMzXUH3aQ r+EtwqemLF+OmlgMgek4SVaMYHEE=; h=subject:to:from:date; d=cyberdimension.org; b=jfsjEpM1fFkRZ19NFtkBlju/VgrNHG4HqH1HmvNUiTLW7o B3z7g+NnWFd3hDVrzl8h1cXaWyAa/hvOKGir8/0VPrUKWK/gB01DGEJw68ytKL4zn/OrwF VPa+sgUcdSgMQsGDC7x4JXxZiO/EZog8+oNCg9p3KrqzHWR8puhAXRx1NRCmzUOAenQBuq 6exJdLAx67eaFw8on3MieIFQZ+BLDkFJJAR4HqGn8ScOTKNG7duGHjF72YgNJKMLzjhJ5/ mx32mdYIhUPxSbwuPBdPvd2uFG2/c1qyhPYGM0U03CV8cgY2Oa2yrgPGvnCJyRzmPrMumn H0JETp3Li4YZN4vg== Received: from primarylaptop.localdomain (localhost [127.0.0.1]) by rockpro64.cyberdimension.org (OpenSMTPD) with ESMTP id f69fbc99 for <73918@debbugs.gnu.org>; Sat, 26 Oct 2024 17:06:27 +0000 (UTC) Date: Sat, 26 Oct 2024 18:56:53 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20241026185653.45f761ee@primarylaptop.localdomain> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/S/thkLuz399o5KEpXGsdUDz"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.02 X-Spam-Score: -7.02 X-Migadu-Queue-Id: 194695DB2B X-Migadu-Scanner: mx13.migadu.com X-TUID: RFyYFeNm3cE0 --Sig_/S/thkLuz399o5KEpXGsdUDz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Thanks a lot for the patches.=20 Note that I'm not a Guix committer nor maintainer. Also I'm not familiar with best practice for commit messages within the Guix projects but other projects that care a lot about code quality tend to indicate the commit that broke something in the commit message. For instance in Linux we have commits like that: > This was broken by commit 16aac5ad1fa9 ("ovl: support encoding > non-decodable file handles"), which didn't take the lower-only > configuration into account. That would simplify the review as here a reviewer will probably need to look into what broke yosys to verify if your fix is the best possible fix (it probably is). Denis. --Sig_/S/thkLuz399o5KEpXGsdUDz Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmcdH1UACgkQX138wUF3 4mM94RAAlEZqPD8NmZjlT5cVtbukbmHp5/cbS+LWcC+MfNc80ySz87QLQUGR79df czxKKrJxZlVSmqE+9LjFGbjRevIjSV53OxvTK7WdSiLp2JE6qz3qyK927lnqYzRM 5lr4sbnboQYy9FyYmJw7sX6SGZ9Vejsfz8xWtU3IwzgetvkxSSEQkGFFwiBCNL2d WBOciiMsCLZmM2LUIPhR1/TiJlQCOLDVaIpKTw5z/fn8DXPt1TfG6OYdkiMGI9Os U1GYwGUaj0MPUDQfinVGD5nmU2i1HvU/TStv3Scp4slw5HXJn+cyJyhLFub78yeW CvwlXvzETC/60kzl/J3NSODgy3dTTq8YsMG5Sz5YBLSq8ePKaHGV8unE4LTj7M92 fCRlTIWBzavYrogqJtym2l+vOHBoML60sh4TXvqZHM8a55YZ2BKScbWLTlNXp6sW aOCLWTkGnESlCSjnXfDQRy/uQIVXq7U+wKWiEcm/TcDM/KZzIDTeVeIDG4MZZCSa dk5FsZKsJdBzt4FxCTY0m6DNoa1cpfgZHRL7sVqFSeTrfW/fv70smtuylKfUaki9 uKSHJj2iqHbFHETw1Dt6lKTf9wAdcgm88WVnryK4PAqxhGwgyZwuPE2x7FwO02xZ qG4qx/3Y8p4UYrgC6Nkmm7w92e6ec3M6hNxJXmfaeVFwYkD3Kto= =zhbT -----END PGP SIGNATURE----- --Sig_/S/thkLuz399o5KEpXGsdUDz--