unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
To: 73918@debbugs.gnu.org
Subject: [bug#73918] [PATCH] gnu: yosys: Update to 0.46.
Date: Sat, 26 Oct 2024 18:56:53 +0200	[thread overview]
Message-ID: <20241026185653.45f761ee@primarylaptop.localdomain> (raw)
In-Reply-To: <4da104f41f60809288973a250f258ddb724616c3.1729460353.git.jakob.kirsch@web.de>

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

Hi,

Thanks a lot for the patches. 

Note that I'm not a Guix committer nor maintainer.

Also I'm not familiar with best practice for commit messages within the
Guix projects but other projects that care a lot about code quality
tend to indicate the commit that broke something in the commit message.

For instance in Linux we have commits like that:
> This was broken by commit 16aac5ad1fa9 ("ovl: support encoding
> non-decodable file handles"), which didn't take the lower-only
> configuration into account.

That would simplify the review as here a reviewer will probably need to
look into what broke yosys to verify if your fix is the best possible
fix (it probably is).

Denis.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-10-26 17:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 21:39 [bug#73918] [PATCH v1 1/2] gnu: iverilog: Fix yosys tests Jakob Kirsch via Guix-patches via
2024-10-20 21:47 ` [bug#73918] [PATCH v2 " Jakob Kirsch via Guix-patches via
2024-10-20 21:48   ` [bug#73918] [PATCH v2 2/2] gnu: yosys: Update to 0.46 Jakob Kirsch via Guix-patches via
2024-10-26 16:56 ` Denis 'GNUtoo' Carikli [this message]
2024-10-31 16:38 ` [bug#73918] [PATCH] " Jakob Kirsch via Guix-patches via
2024-11-01  7:27 ` [bug#73918] (no subject) Cayetano Santos via Guix-patches via
2024-11-02  8:42 ` [bug#73918] QA review for 73918 Cayetano Santos via Guix-patches via
2024-11-03 16:27 ` [bug#73918] [PATCH] gnu: yosys: Update to 0.46 Denis 'GNUtoo' Carikli
2024-11-04 10:56   ` Cayetano Santos via Guix-patches via
2024-11-09 19:08 ` [bug#73918] [PATCH v3 0/2] Minor corrections to v2 Cayetano Santos via Guix-patches via
2024-11-09 19:08   ` [bug#73918] [PATCH v3 1/2] gnu: iverilog: Fix yosys tests Cayetano Santos via Guix-patches via
2024-11-09 19:08   ` [bug#73918] [PATCH v3 2/2] gnu: yosys: Update to 0.46 Cayetano Santos via Guix-patches via
2024-11-12 11:40     ` bug#73918: " Maxim Cournoyer
2024-11-09 19:22 ` [bug#73918] QA review for 73918 Cayetano Santos via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026185653.45f761ee@primarylaptop.localdomain \
    --to=gnutoo@cyberdimension.org \
    --cc=73918@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).