unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ian Eure <ian@retrospec.tv>
To: 73796@debbugs.gnu.org
Cc: Ian Eure <ian@retrospec.tv>
Subject: [bug#73796] [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation.
Date: Sun, 13 Oct 2024 12:00:55 -0700	[thread overview]
Message-ID: <20241013190055.14247-1-ian@retrospec.tv> (raw)

The icons and appdata.xml were getting installed into share/applications, when
they should have gone into share/icons/hicolor and share/metainfo.  Put them
in the right place, which allows DEs to find them.

*  (jellyfin-mpv-shim): Fix icon & metainfo installation.

Change-Id: Ic6cdae2fe0b348b94285bf8b39c014922baae6c1
---
 gnu/packages/video.scm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 1d2ab5fbeb..92c0acef3c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2830,16 +2830,24 @@ (define-public jellyfin-mpv-shim
              (lambda* (#:key outputs #:allow-other-keys)
                (let* ((out (assoc-ref outputs "out"))
                       (apps (string-append out "/share/applications"))
+                      (metainfo (string-append out "/share/metainfo"))
+                      (icons (string-append out "/share/icons"))
                       (desktop-base "jellyfin_mpv_shim/integration/")
                       (package-id
                        "com.github.iwalton3.jellyfin-mpv-shim"))
                  (for-each (lambda (size)
-                             (install-file (format #f
-                                                   "~ajellyfin-~a.png"
-                                                   desktop-base size) apps))
+                             (let ((dir (format
+                                         #f "~a/hicolor/~ax~a/apps/"
+                                         icons size size package-id)))
+                               (mkdir-p dir)
+                               (copy-file
+                                (format #f
+                                        "~ajellyfin-~a.png"
+                                        desktop-base size)
+                                (string-append dir package-id ".png"))))
                            '(256 128 64 48 32 16))
                  (install-file (string-append desktop-base package-id
-                                              ".appdata.xml") apps)
+                                              ".appdata.xml") metainfo)
                  (install-file (string-append desktop-base package-id
                                               ".desktop") apps)))))))
     (inputs (list `(,python "tk")
-- 
2.46.0





             reply	other threads:[~2024-10-13 19:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-13 19:00 Ian Eure [this message]
2024-10-15 16:21 ` bug#73796: [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241013190055.14247-1-ian@retrospec.tv \
    --to=ian@retrospec.tv \
    --cc=73796@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).