* [bug#73651] [PATCH] gnu: dool: Update to 1.3.3.
@ 2024-10-06 6:53 Artyom V. Poptsov
2024-10-07 20:57 ` [bug#73651] QA: review for 73651 Aaron Covrig via Guix-patches via
2024-10-13 5:10 ` [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
0 siblings, 2 replies; 3+ messages in thread
From: Artyom V. Poptsov @ 2024-10-06 6:53 UTC (permalink / raw)
To: 73651; +Cc: Artyom V. Poptsov
* gnu/packages/admin.scm (dool): Update to 1.3.3.
[arguments]<phases>: Fix "check" phase by removing "-f" option from the dool
arguments as it leads to failures during tests but works after installation.
Don't remove "examples/dstat.py" as it is already removed in the upstream.
Change-Id: I22714bc03bf248b97ba8f21835aedb213e1b281b
---
gnu/packages/admin.scm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5c1b063d26..427e2778bd 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -3544,7 +3544,7 @@ (define-public dstat
(define-public dool
(package
(name "dool")
- (version "1.3.0")
+ (version "1.3.3")
(source
(origin
(method git-fetch)
@@ -3553,7 +3553,7 @@ (define-public dool
(commit (string-append "v" version))))
(file-name (git-file-name "dool" version))
(sha256
- (base32 "1728wxy338gf2l06b0b4j9j8vihadw5whzzj7mi9p3by633h5s8m"))))
+ (base32 "0y5y5c07hgj6v2nvimnwc8myx43li8ib40hdvz7q4q1pdqx3r0jl"))))
(build-system python-build-system)
(arguments
(list
@@ -3562,7 +3562,6 @@ (define-public dool
(add-after 'unpack 'remove-symlinks-and-snap-packaging
;; Remove symlinks that make 'ensure-no-mtimes-pre-1980 fail.
(lambda _
- (delete-file "examples/dstat.py")
(delete-file-recursively "packaging/snap")))
(delete 'build)
(replace 'install
@@ -3579,7 +3578,7 @@ (define-public dool
(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "./dool" "--version")
- (invoke "./dool" "-taf" "1" "5")))))))
+ (invoke "./dool" "-ta" "1" "5")))))))
(synopsis "Command line system resource monitoring tool")
(description "Dool is a command line tool to monitor many aspects of your
system: CPU, Memory, Network, Load Average, etc. It also includes a robust
base-commit: 002df8abd2f4d7c5d23febb1459b77c880345ca7
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#73651] QA: review for 73651
2024-10-06 6:53 [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
@ 2024-10-07 20:57 ` Aaron Covrig via Guix-patches via
2024-10-13 5:10 ` [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
1 sibling, 0 replies; 3+ messages in thread
From: Aaron Covrig via Guix-patches via @ 2024-10-07 20:57 UTC (permalink / raw)
To: control, 73651
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
user guix
usertag 73651 + reviewed-looks-good
thanks
Guix QA review form submission:
Changes listed in the commit are correct, `dstat.py` was removed (the
entire examples directory was removed in commit
'dc7c1da9e1feaa98de7c70baa3b16529a8eda0ad') and something
about the '-f' or '--full' flag does cause tests to
fail in the guix build environment, but the flag does work after
building and calling in a normal shell environment.
Items marked as checked: Lint warnings, Package builds, Commit
messages, New package licenses, New package tests, New package synopsis
and descriptions
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#73651] [PATCH] gnu: dool: Update to 1.3.3.
2024-10-06 6:53 [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
2024-10-07 20:57 ` [bug#73651] QA: review for 73651 Aaron Covrig via Guix-patches via
@ 2024-10-13 5:10 ` Artyom V. Poptsov
1 sibling, 0 replies; 3+ messages in thread
From: Artyom V. Poptsov @ 2024-10-13 5:10 UTC (permalink / raw)
To: 73651-done; +Cc: 73651
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
Pushed to the "master" as e032a0f38ff3394816fdc29554933ce77c545eff.
- avp
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-13 5:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 6:53 [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
2024-10-07 20:57 ` [bug#73651] QA: review for 73651 Aaron Covrig via Guix-patches via
2024-10-13 5:10 ` [bug#73651] [PATCH] gnu: dool: Update to 1.3.3 Artyom V. Poptsov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).