unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.
@ 2024-09-24 11:12 Romain GARBAGE
  2024-09-30 19:43 ` bug#73448: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Romain GARBAGE @ 2024-09-24 11:12 UTC (permalink / raw)
  To: 73448; +Cc: ludovic.courtes, Romain GARBAGE

* gnu/packages/maths.scm (netcdf-parallel-openmpi) [arguments]: Enable
building of shared library.

Change-Id: I6e901d5939108421e041252207f10f4800890e97
---
The parallel version of the netcdf package was build without shared
libraries, which were not supported at the time the package was written
for parallel I/O. This doesn't seem to be the case anymore: the
documentation talks about both parallel and shared library support, e.g.
at
https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_pnetcdf_from_source.
---
 gnu/packages/maths.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 5f47d5e390..03fa4d2fae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2363,8 +2363,9 @@ (define-public netcdf-parallel-openmpi
        ((#:configure-flags flags)
         `(cons* "CC=mpicc" "CXX=mpicxx"
                 "--enable-parallel-tests"
-                ;; Shared libraries not supported with parallel IO.
-                "--disable-shared" "--with-pic"
+                ;; NetCDF supports both parallel and shared library building
+                ;; See https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_parallel
+                "--enable-shared" "--with-pic"
                 ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases

base-commit: 1c088531cf0be8fe6706c4624a920fca2ab2fee0
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#73448: [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.
  2024-09-24 11:12 [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library Romain GARBAGE
@ 2024-09-30 19:43 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-09-30 19:43 UTC (permalink / raw)
  To: Romain GARBAGE; +Cc: 73448-done

Romain GARBAGE <romain.garbage@inria.fr> skribis:

> * gnu/packages/maths.scm (netcdf-parallel-openmpi) [arguments]: Enable
> building of shared library.
>
> Change-Id: I6e901d5939108421e041252207f10f4800890e97

Applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-30 19:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 11:12 [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library Romain GARBAGE
2024-09-30 19:43 ` bug#73448: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).