unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Adrien 'neox' Bourmault <neox@gnu.org>
To: 73393@debbugs.gnu.org
Cc: Adrien 'neox' Bourmault <neox@gnu.org>
Subject: [bug#73393] [PATCH v2 2/2] services: sane-service-type: create lock path for plustek backend
Date: Sun, 22 Sep 2024 11:07:58 +0200	[thread overview]
Message-ID: <8604617ae2896e2d73d24958aab7ee534c656dfa.1726864525.git.neox@gnu.org> (raw)
Message-ID: <20240922090758.x2jhCKWh8d30sfet2L5AnROZJLVWpsxHvwaH2kELerM@z> (raw)
In-Reply-To: <cover.1726864525.git.neox@gnu.org>

* gnu/services/desktop.scm (sane-service-type): extend with an activation
 service to create the lockpath and give the right permissions

Change-Id: I187886d12b5f0b4fe21b03de178ea2187205387a
Signed-off-by: Adrien 'neox' Bourmault <neox@gnu.org>
---
 gnu/services/desktop.scm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 274aeeef9b..500527cb50 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2021, 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
+;;; Copyright © 2024 Adrien Bourmault <neox@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1408,6 +1409,17 @@ (define %sane-accounts
   ;; The '60-libsane.rules' udev rules refers to the "scanner" group.
   (list (user-group (name "scanner") (system? #t))))
 
+(define %sane-activation
+  #~(begin
+      (use-modules (guix build utils))
+      (let ((lockpath "/var/lock/sane")
+            (gid (vector-ref (getgrnam "scanner") 2)))
+        ;; Create the lock directory at runtime and give right perms
+        (mkdir-p lockpath)
+        (chown lockpath -1 gid)
+        (chmod lockpath #o770))
+      #t))
+
 (define sane-service-type
   (service-type
    (name 'sane)
@@ -1418,6 +1430,8 @@ (define sane-service-type
    (default-value sane-backends-minimal)
    (extensions
     (list (service-extension udev-service-type list)
+          (service-extension activation-service-type
+                             (const %sane-activation))
           (service-extension account-service-type
                              (const %sane-accounts))))))
 
-- 
2.46.0





  parent reply	other threads:[~2024-09-22  9:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 19:03 [bug#73391] [PATCH 0/2] SANE: fix a locking bug for plustek backend neox
2024-09-20 19:03 ` [bug#73392] [PATCH 1/2] gnu: sane-backends-minimal: fix lock path " neox
     [not found]   ` <handler.73392.B.172685906722683.ack@debbugs.gnu.org>
2024-09-20 19:21     ` [bug#73392] Acknowledgement ([PATCH 1/2] gnu: sane-backends-minimal: fix lock path for plustek backend) Adrien 'neox' Bourmault
2024-09-20 19:03 ` [bug#73393] [PATCH 2/2] services: sane-service-type: create lock path for plustek backend neox
2024-09-22  8:55   ` Adrien 'neox' Bourmault
2024-09-20 20:39 ` [bug#73391] [PATCH v2 0/2] SANE: fix a locking bug " neox
2024-09-20 20:39   ` [bug#73391] [PATCH v2 1/2] gnu: sane-backends-minimal: fix lock path " neox
2024-09-21  8:03     ` [bug#73406] " Adrien 'neox' Bourmault
2024-09-22  9:07     ` [bug#73393] " Adrien 'neox' Bourmault
2024-09-20 20:39   ` neox [this message]
2024-09-21  8:03     ` [bug#73406] [PATCH v2 2/2] services: sane-service-type: create " Adrien 'neox' Bourmault
2024-09-22  9:07     ` [bug#73393] " Adrien 'neox' Bourmault
2024-09-21  8:01   ` [bug#73406] [PATCH v2 0/2] SANE: fix a locking bug " Adrien 'neox' Bourmault
2024-09-22  9:07   ` [bug#73393] " Adrien 'neox' Bourmault
2024-09-24 18:51   ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8604617ae2896e2d73d24958aab7ee534c656dfa.1726864525.git.neox@gnu.org \
    --to=neox@gnu.org \
    --cc=73393@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).