unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73168] [PATCH] gnu: bash-minimal: Add package description.
@ 2024-09-10 14:13 Romain GARBAGE
  2024-09-10 16:22 ` jgart via Guix-patches via
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Romain GARBAGE @ 2024-09-10 14:13 UTC (permalink / raw)
  To: 73168; +Cc: ludovic.courtes, Romain GARBAGE

* gnu/packages/bash.scm (bash-minimal): Add package description.

Change-Id: I37da88d189f3a2d99aa8bcba5de3102909ae4761
---
 gnu/packages/bash.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 9ecec0a484..ad94c076bf 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -258,7 +258,9 @@ (define-public bash-minimal
        ((#:phases phases)
         `(modify-phases ,phases
            ;; No loadable modules.
-           (delete 'move-development-files)))))))
+           (delete 'move-development-files)))))
+    (description "This is a stripped-down version of the @code{bash} package for
+non-interactive use.")))
 
 (define-public static-bash
   ;; Statically-linked Bash that contains nothing but the 'bash' binary and

base-commit: 7f05b73d90f740c6a139f0e706b717d3174f6321
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#73168] [PATCH] gnu: bash-minimal: Add package description.
  2024-09-10 14:13 [bug#73168] [PATCH] gnu: bash-minimal: Add package description Romain GARBAGE
@ 2024-09-10 16:22 ` jgart via Guix-patches via
  2024-09-12 10:47 ` Ludovic Courtès
  2024-09-12 10:54 ` [bug#73168] [PATCH v2] gnu: bash-minimal: Add package synopsis Romain GARBAGE
  2 siblings, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2024-09-10 16:22 UTC (permalink / raw)
  To: 73168; +Cc: Romain GARBAGE


Hi,

This should go to core-updates.

-- 
all the best,
jgart




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#73168] [PATCH] gnu: bash-minimal: Add package description.
  2024-09-10 14:13 [bug#73168] [PATCH] gnu: bash-minimal: Add package description Romain GARBAGE
  2024-09-10 16:22 ` jgart via Guix-patches via
@ 2024-09-12 10:47 ` Ludovic Courtès
  2024-09-12 10:54 ` [bug#73168] [PATCH v2] gnu: bash-minimal: Add package synopsis Romain GARBAGE
  2 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2024-09-12 10:47 UTC (permalink / raw)
  To: Romain GARBAGE; +Cc: 73168

Hi Romain,

Romain GARBAGE <romain.garbage@inria.fr> skribis:

> * gnu/packages/bash.scm (bash-minimal): Add package description.
>
> Change-Id: I37da88d189f3a2d99aa8bcba5de3102909ae4761

[...]

> +    (description "This is a stripped-down version of the @code{bash} package for
> +non-interactive use.")))

Good initiative.  I would change the synopsis rather than the
description (this is what’s usually/often done for package variants),
like, say:

  (synopsis "The GNU Bourne-Again SHell, stripped down for non-interactive use")

WDYT?

Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#73168] [PATCH v2] gnu: bash-minimal: Add package synopsis.
  2024-09-10 14:13 [bug#73168] [PATCH] gnu: bash-minimal: Add package description Romain GARBAGE
  2024-09-10 16:22 ` jgart via Guix-patches via
  2024-09-12 10:47 ` Ludovic Courtès
@ 2024-09-12 10:54 ` Romain GARBAGE
  2024-09-12 15:10   ` bug#73168: " Ludovic Courtès
  2 siblings, 1 reply; 5+ messages in thread
From: Romain GARBAGE @ 2024-09-12 10:54 UTC (permalink / raw)
  To: 73168; +Cc: ludovic.courtes, Romain GARBAGE

* gnu/packages/bash.scm (bash-minimal): Add package synopsis.

Change-Id: I33f12547fca19d096712786a0c33525aa726b343
---
 gnu/packages/bash.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 9ecec0a484..93641a78d5 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -258,7 +258,8 @@ (define-public bash-minimal
        ((#:phases phases)
         `(modify-phases ,phases
            ;; No loadable modules.
-           (delete 'move-development-files)))))))
+           (delete 'move-development-files)))))
+    (synopsis "The GNU Bourne-Again SHell, stripped down for non-interactive use")))
 
 (define-public static-bash
   ;; Statically-linked Bash that contains nothing but the 'bash' binary and

base-commit: b6d5a7f5836739dab884b49a64ca354794dd845f
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#73168: [PATCH v2] gnu: bash-minimal: Add package synopsis.
  2024-09-12 10:54 ` [bug#73168] [PATCH v2] gnu: bash-minimal: Add package synopsis Romain GARBAGE
@ 2024-09-12 15:10   ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2024-09-12 15:10 UTC (permalink / raw)
  To: Romain GARBAGE; +Cc: 73168-done

Romain GARBAGE <romain.garbage@inria.fr> skribis:

> * gnu/packages/bash.scm (bash-minimal): Add package synopsis.
>
> Change-Id: I33f12547fca19d096712786a0c33525aa726b343

Applied, thanks!




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-09-12 15:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 14:13 [bug#73168] [PATCH] gnu: bash-minimal: Add package description Romain GARBAGE
2024-09-10 16:22 ` jgart via Guix-patches via
2024-09-12 10:47 ` Ludovic Courtès
2024-09-12 10:54 ` [bug#73168] [PATCH v2] gnu: bash-minimal: Add package synopsis Romain GARBAGE
2024-09-12 15:10   ` bug#73168: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).