From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id YFISHbMKPWb2DgAAe85BDQ:P1 (envelope-from ) for ; Thu, 09 May 2024 19:41:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id YFISHbMKPWb2DgAAe85BDQ (envelope-from ) for ; Thu, 09 May 2024 19:41:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b=OcF8h4BD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715276467; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5MKbaQ/M+Jgy9y26W8mdtwGFymLF6VqyGS912rY/97c=; b=Onbsc1dNmRNLcez4gaHA0P7zA6aq6DA/H5pGzw6sdtUFgH7XeX0fdW94meJN9mAXIoiXtf GFONDfiXxf5hkeLZdTo+dJlH7Wm7hFuSX+pGfEl+UInOQI1IR9t7fW/IsANS6LkJxrTBpF yvsehKMJNOlDAXTL6J73D07Yi9GKZ25ZN97He1H6SCtBytsp6AWidsJa435x9/Zu/Nts2I YtOcTL8nSxlHgrQkerglFfLoU6EKXbImalSyOX4jHamfRt5Dsse7T8/YUl2ns8cTOYS32g dFJNSuSyS3oZJzJf5L2qeI2GYLwKdH1mc6FAn5DzaD+lAuw8brh6QAfHcDlWSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b=OcF8h4BD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715276467; a=rsa-sha256; cv=none; b=t/a+VlYd2JXA8ZjgmLd/XrYL8LQGWgTmxMQstMqaXFXeNWlulTuiXdx3g0TjgVm4etl0YD FfItBS9mtupKlgQuvrYU5gKCKrCQ8ikYPbDie7vRGOVqh2gFJlwgxk0zvwx1m1zPGY43kL UWDzcct94Pji/05JltdecF9bvcFyda508SWpumHkNlRLgYv3jZXobzAcJtx+ni59GeHAr7 p2BZfmjICKPeQjsfIbcfgN+RgItcvH7BL+L0Ll2OwhQj6lsB0zcgwqrqjoqoC9XUDhl+Pp FDfc9AT6lPHrbKxQEYXt6chpFMZlGi0VE4ZqCBTiMhk8SaknVZdx3JB7Qk2HIQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B62050B0F for ; Thu, 9 May 2024 19:41:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s57l4-00080Q-P0; Thu, 09 May 2024 13:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s57kz-000809-1P for guix-patches@gnu.org; Thu, 09 May 2024 13:40:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s57ky-0008H0-DC for guix-patches@gnu.org; Thu, 09 May 2024 13:40:36 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s57lO-0000Gj-Fp for guix-patches@gnu.org; Thu, 09 May 2024 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70845] [PATCH] services: Add fancontrol-service-type References: <20240509154032.5047-1-neox@gnu.org> In-Reply-To: <20240509154032.5047-1-neox@gnu.org> Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2024 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70845@debbugs.gnu.org Received: via spool by 70845-submit@debbugs.gnu.org id=B70845.17152764301016 (code B ref 70845); Thu, 09 May 2024 17:41:02 +0000 Received: (at 70845) by debbugs.gnu.org; 9 May 2024 17:40:30 +0000 Received: from localhost ([127.0.0.1]:56474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s57ks-0000GK-IA for submit@debbugs.gnu.org; Thu, 09 May 2024 13:40:30 -0400 Received: from cyberdimension.org ([79.143.250.36]:49136 helo=rockpro64.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s57kp-0000GC-6v for 70845@debbugs.gnu.org; Thu, 09 May 2024 13:40:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=dkim; bh=5MKbaQ/M+Jgy9y2 6W8mdtwGFymLF6VqyGS912rY/97c=; h=subject:to:from:date; d=cyberdimension.org; b=OcF8h4BDUANRHpuVNHwRiuhcarGR3aEwKvHgjoaL+uKBsC datZ9pvPOsDWxkkbJq89/FoTWb6HzN/TUF1IIQ+vgp/xnw8Rm4cPAeEoc2ngBIpZ9AA/hM eScOj0OXwGmZ/QjFnJlusByMN5mSBwt7lpQ4lIMmrQAHOrc4mjPkhopP8zZkWNdyFd60wx AD8mpR9cym4ZN80+A037v5R5pcLXsmVIKKzfuGr/hbAf5D8evFT8xOasiO7TN1OdB/SJkN KF1HwPoQ3CqnSXgcxRtAsu0XaePwrIUkD3fW7uYPzohMt0qaiQr2TqonmIDh9hZtUT4BmA CROPiu8AqRaMG1HQ== Received: from primary_laptop (localhost [127.0.0.1]) by rockpro64.cyberdimension.org (OpenSMTPD) with ESMTP id 054a9da3 for <70845@debbugs.gnu.org>; Thu, 9 May 2024 17:39:58 +0000 (UTC) Date: Thu, 9 May 2024 19:39:56 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20240509193942.20e6ec8e@primary_laptop> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uP=3_L6HHKkZBlroZNp3DU9"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.99 X-Spam-Score: -0.99 X-Migadu-Queue-Id: 3B62050B0F X-Migadu-Scanner: mx13.migadu.com X-TUID: PpHiXaK4Ltno --Sig_/uP=3_L6HHKkZBlroZNp3DU9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Thanks a lot for the patch. For the record I'm not a Guix maintainer / committer, and that I didn't look at everything but I spotted something that could be improved: the user has no way to override the lm-sensors package being used. Most services provide a way to do that kind of override, so it would make sense to add that at some point. Denis. --Sig_/uP=3_L6HHKkZBlroZNp3DU9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmY9CmwACgkQX138wUF3 4mNhFA/7BI7Ov0pp9eAdAJ/Vd/6ulxUFrqRrpuJI5pPNBKl+9sA7NA88MCET6ERh ZKLy4liq25djLrAbWuKGOU5QAuz6+/2gvasKlGifFfQqSgI0MisOTOEXpyvrXdyA QyPEL3Etcccb4ZzRAIUZTMKbcYX9NYp2xwhYpOM0ewae5MTpHYLHxsnDbefwo8xJ 8dgUeqM4lc1xIfrgbTVM0yIFJbfA3vTNGCb/ufqx3hH5fiy3gU/Xki/zWwzIhRhJ qxMMqXSmGTWAhHLSJJ8SLa64UDb5mfK1rVeXkFztaLJXm63Yov370b+zBTMk9W/T iMWVf38mJurgwFx2rB1tZMU9Q6vLzC/xf+eYkHH0YFyoYtI53aLsiKfiUWUYigzC qadluO65cmhRZWMl/u91KZo80dGY51jFSPMagE9vAjN3PPceV2vIEfaFEjBq48F1 P1xGTdO1jreY2M6ynphLro1VgxZgkYTp8OU/oA4VAyOqih5GqA6Ms+6+ZzpWiNJg Fqg5ah8SQHkwzW5qfclh2f8czXHWGsEDrwqGXhDBMwNKa6hvrqfnUM1zpJ1XcGk2 g+0XGBONp8dJv2615mhRRBpnGwq6t18i78zMaogsbiLh3gfd4jOCO6FKv388OkrP KtemqUtwxHWHH8B4dLd5QaZiBuL3wvLxnvWaEGy3U2iwAHZ+bho= =3FAO -----END PGP SIGNATURE----- --Sig_/uP=3_L6HHKkZBlroZNp3DU9--