unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: David Elsing <david.elsing@posteo.net>
To: 69591@debbugs.gnu.org
Cc: David Elsing <david.elsing@posteo.net>
Subject: [bug#69591] [PATCH v3 15/32] gnu: clog: Add "-DUSE_SYSTEM_LIBS=ON" configure flag.
Date: Wed, 20 Mar 2024 22:38:40 +0000	[thread overview]
Message-ID: <20240320223906.13214-15-david.elsing@posteo.net> (raw)
In-Reply-To: <20240320223737.12883-1-david.elsing@posteo.net>

* gnu/packages/parallel.scm (clog)[arguments]: Add "-DUSE_SYSTEM_LIBS=ON"
to #:configure-flags.
* gnu/packages/patches/clog-fix-shared-build.patch: Adjust patch.
---
 gnu/packages/parallel.scm                     | 13 ++++---
 .../patches/clog-fix-shared-build.patch       | 39 ++-----------------
 2 files changed, 12 insertions(+), 40 deletions(-)

diff --git a/gnu/packages/parallel.scm b/gnu/packages/parallel.scm
index 4238312367..f591834047 100644
--- a/gnu/packages/parallel.scm
+++ b/gnu/packages/parallel.scm
@@ -527,11 +527,14 @@ (define-public clog
               (inherit (package-source cpuinfo))
               (patches (search-patches "clog-fix-shared-build.patch"))))
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON")
-           #:phases #~(modify-phases %standard-phases
-                        (add-after 'unpack 'chdir
-                          (lambda _
-                            (chdir "deps/clog"))))))
+     (list
+      #:configure-flags
+      ''("-DBUILD_SHARED_LIBS=ON"
+         "-DUSE_SYSTEM_LIBS=ON")
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'chdir
+                     (lambda _
+                       (chdir "deps/clog"))))))
     (native-inputs (list googletest))
     (inputs '())
     (synopsis "C-style logging library based on printf")
diff --git a/gnu/packages/patches/clog-fix-shared-build.patch b/gnu/packages/patches/clog-fix-shared-build.patch
index bf80544b90..eb305339f5 100644
--- a/gnu/packages/patches/clog-fix-shared-build.patch
+++ b/gnu/packages/patches/clog-fix-shared-build.patch
@@ -1,50 +1,19 @@
 Author: Antero Mejr <antero@mailbox.org>
-Notes: Disabled function visibility hacks and googletest download. Enabled
-non-static builds.
+Notes: Disabled function visibility hacks. Enabled non-static builds.
 
 diff --git a/deps/clog/CMakeLists.txt b/deps/clog/CMakeLists.txt
-index 083f519..b7b225a 100644
+index 6e50c41..db02e95 100644
 --- a/deps/clog/CMakeLists.txt
 +++ b/deps/clog/CMakeLists.txt
-@@ -38,20 +38,8 @@ SET(CONFU_DEPENDENCIES_SOURCE_DIR ${CMAKE_SOURCE_DIR}/deps
- SET(CONFU_DEPENDENCIES_BINARY_DIR ${CMAKE_BINARY_DIR}/deps
-   CACHE PATH "Confu-style dependencies binary directory")
+@@ -55,7 +55,7 @@ IF(CLOG_BUILD_TESTS)
+ ENDIF()
  
--IF(CLOG_BUILD_TESTS)
--  IF(NOT DEFINED GOOGLETEST_SOURCE_DIR)
--    MESSAGE(STATUS "Downloading Google Test to ${CONFU_DEPENDENCIES_SOURCE_DIR}/googletest (define GOOGLETEST_SOURCE_DIR to avoid it)")
--    CONFIGURE_FILE(cmake/DownloadGoogleTest.cmake "${CONFU_DEPENDENCIES_BINARY_DIR}/googletest-download/CMakeLists.txt")
--    EXECUTE_PROCESS(COMMAND "${CMAKE_COMMAND}" -G "${CMAKE_GENERATOR}" .
--      WORKING_DIRECTORY "${CONFU_DEPENDENCIES_BINARY_DIR}/googletest-download")
--    EXECUTE_PROCESS(COMMAND "${CMAKE_COMMAND}" --build .
--      WORKING_DIRECTORY "${CONFU_DEPENDENCIES_BINARY_DIR}/googletest-download")
--    SET(GOOGLETEST_SOURCE_DIR "${CONFU_DEPENDENCIES_SOURCE_DIR}/googletest" CACHE STRING "Google Test source directory")
--  ENDIF()
--ENDIF()
--
  # ---[ clog library
 -ADD_LIBRARY(clog STATIC src/clog.c)
 +ADD_LIBRARY(clog src/clog.c)
  SET_TARGET_PROPERTIES(clog PROPERTIES
    C_STANDARD 99
    C_EXTENSIONS NO)
-@@ -74,16 +62,6 @@ INSTALL(TARGETS clog
- 
- # ---[ clog tests
- IF(CLOG_BUILD_TESTS)
--  # ---[ Build google test
--  IF(NOT TARGET gtest)
--    IF(MSVC AND NOT CLOG_RUNTIME_TYPE STREQUAL "static")
--      SET(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
--    ENDIF()
--    ADD_SUBDIRECTORY(
--      "${GOOGLETEST_SOURCE_DIR}"
--      "${CONFU_DEPENDENCIES_BINARY_DIR}/googletest")
--  ENDIF()
--
-   ADD_EXECUTABLE(clog-test test/clog.cc)
-   SET_TARGET_PROPERTIES(clog-test PROPERTIES
-     CXX_STANDARD 11
 diff --git a/deps/clog/include/clog.h b/deps/clog/include/clog.h
 index 4143761..aa9000f 100644
 --- a/deps/clog/include/clog.h
-- 
2.41.0





  parent reply	other threads:[~2024-03-20 23:19 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 19:37 [bug#69591] [PATCH 00/31] Unbundle and update python-pytorch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 01/31] gnu: asmjit: Update to commit 3ca5c18 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 02/31] gnu: Add python-typing-extensions-4.10 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 03/31] gnu: Add python-optree David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 04/31] gnu: Add python-pytest-flakefinder David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 05/31] gnu: Add python-pytest-shard David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 06/31] gnu: Add python-expecttest David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 07/31] gnu: Add python-pytest-rerunfailures-13 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 08/31] gnu: Add miniz David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 09/31] gnu: Add miniz-for-pytorch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 10/31] gnu: Add libnop David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 11/31] gnu: Remove flatbuffers-next-shared David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 12/31] gnu: python-flatbuffers-next: Update to 23.5.26 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 13/31] gnu: pthreadpool: Update to commit 178e3e0 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 14/31] gnu: cpuinfo: Update to commit aa4b216 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 15/31] gnu: clog: Add "-DUSE_SYSTEM_LIBS=ON" configure flag David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 16/31] gnu: nnpack: Update to commit 70a77f4 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 17/31] gnu: oneapi-dnnl: Update to 3.3.5 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 18/31] gnu: Add tensorpipe David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 19/31] gnu: Add fbgemm David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 20/31] gnu: Add qnnpack David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 21/31] gnu: Add foxi David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 22/31] gnu: Add ideep-pytorch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 23/31] gnu: xnnpack: Update to commit 51a9875 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 24/31] gnu: Remove xnnpack-for-torch2 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 25/31] gnu: Add qnnpack-pytorch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 26/31] gnu: python-pytorch: Update to 2.2.1 and unbundle dependencies David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 27/31] gnu: python-torchvision: Update to 0.17.1 David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 28/31] gnu: Add ideep-pytorch-for-r-torch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 29/31] gnu: Add oneapi-dnnl-for-r-torch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 30/31] gnu: Add qnnpack-pytorch-for-r-torch David Elsing
2024-03-06 19:40 ` [bug#69591] [PATCH 31/31] gnu: python-pytorch-for-r-torch: Adjust to new python-pytorch David Elsing
2024-03-12 22:46 ` [bug#69591] [PATCH v2 00/31] Unbundle and update python-pytorch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 01/31] gnu: asmjit: Update to commit 3ca5c18 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 02/31] gnu: Add python-typing-extensions-4.10 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 03/31] gnu: Add python-optree David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 04/31] gnu: Add python-pytest-flakefinder David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 05/31] gnu: Add python-pytest-shard David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 06/31] gnu: Add python-expecttest David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 07/31] gnu: Add python-pytest-rerunfailures-13 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 08/31] gnu: Add miniz David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 09/31] gnu: Add miniz-for-pytorch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 10/31] gnu: Add libnop David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 11/31] gnu: Remove flatbuffers-next-shared David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 12/31] gnu: python-flatbuffers-next: Update to 23.5.26 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 13/31] gnu: pthreadpool: Update to commit 178e3e0 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 14/31] gnu: cpuinfo: Update to commit aa4b216 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 15/31] gnu: clog: Add "-DUSE_SYSTEM_LIBS=ON" configure flag David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 16/31] gnu: nnpack: Update to commit 70a77f4 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 17/31] gnu: oneapi-dnnl: Update to 3.3.5 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 18/31] gnu: Add tensorpipe David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 19/31] gnu: Add fbgemm David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 20/31] gnu: Add qnnpack David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 21/31] gnu: Add foxi David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 22/31] gnu: Add ideep-pytorch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 23/31] gnu: xnnpack: Update to commit 51a9875 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 24/31] gnu: Remove xnnpack-for-torch2 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 25/31] gnu: Add qnnpack-pytorch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 26/31] gnu: python-pytorch: Update to 2.2.1 and unbundle dependencies David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 27/31] gnu: python-torchvision: Update to 0.17.1 David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 28/31] gnu: Add ideep-pytorch-for-r-torch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 29/31] gnu: Add oneapi-dnnl-for-r-torch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 30/31] gnu: Add qnnpack-pytorch-for-r-torch David Elsing
2024-03-12 22:51   ` [bug#69591] [PATCH v2 31/31] gnu: python-pytorch-for-r-torch: Adjust to new python-pytorch David Elsing
2024-03-20 22:37   ` [bug#69591] [PATCH v3 00/32] Unbundle and update python-pytorch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 01/32] gnu: asmjit: Update to commit 3ca5c18 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 02/32] gnu: Add python-typing-extensions-4.10 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 03/32] gnu: Add python-optree David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 04/32] gnu: Add python-pytest-flakefinder David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 05/32] gnu: Add python-pytest-shard David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 06/32] gnu: Add python-expecttest David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 07/32] gnu: Add python-pytest-rerunfailures-13 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 08/32] gnu: Add miniz David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 09/32] gnu: Add miniz-for-pytorch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 10/32] gnu: Add libnop David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 11/32] gnu: Remove flatbuffers-next-shared David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 12/32] gnu: python-flatbuffers-next: Update to 23.5.26 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 13/32] gnu: pthreadpool: Update to commit 178e3e0 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 14/32] gnu: cpuinfo: Update to commit aa4b216 David Elsing
2024-03-20 22:38     ` David Elsing [this message]
2024-03-20 22:38     ` [bug#69591] [PATCH v3 16/32] gnu: nnpack: Update to commit 70a77f4 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 17/32] gnu: oneapi-dnnl: Update to 3.3.5 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 18/32] gnu: Add tensorpipe David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 19/32] gnu: Add fbgemm David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 20/32] gnu: Add qnnpack David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 21/32] gnu: Add foxi David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 22/32] gnu: Add ideep-pytorch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 23/32] gnu: xnnpack: Update to commit 51a9875 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 24/32] gnu: Remove xnnpack-for-torch2 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 25/32] gnu: Add qnnpack-pytorch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 26/32] gnu: python-pytorch: Update to 2.2.1 and unbundle dependencies David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 27/32] gnu: Add python-pytorch-avx David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 28/32] gnu: python-torchvision: Update to 0.17.1 David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 29/32] gnu: Add ideep-pytorch-for-r-torch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 30/32] gnu: Add oneapi-dnnl-for-r-torch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 31/32] gnu: Add qnnpack-pytorch-for-r-torch David Elsing
2024-03-20 22:38     ` [bug#69591] [PATCH v3 32/32] gnu: python-pytorch-for-r-torch: Adjust to new python-pytorch David Elsing
2024-03-23 21:40     ` [bug#69591] [PATCH v4 00/32] Unbundle and update python-pytorch David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 01/32] gnu: asmjit: Update to commit 3ca5c18 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 02/32] gnu: Add python-typing-extensions-4.10 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 03/32] gnu: Add python-optree David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 04/32] gnu: Add python-pytest-flakefinder David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 05/32] gnu: Add python-pytest-shard David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 06/32] gnu: Add python-expecttest David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 07/32] gnu: Add python-pytest-rerunfailures-13 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 08/32] gnu: Add miniz David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 09/32] gnu: Add miniz-for-pytorch David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 10/32] gnu: Add libnop David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 11/32] gnu: Remove flatbuffers-next-shared David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 12/32] gnu: python-flatbuffers-next: Update to 23.5.26 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 13/32] gnu: pthreadpool: Update to commit 178e3e0 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 14/32] gnu: cpuinfo: Update to commit aa4b216 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 15/32] gnu: clog: Add "-DUSE_SYSTEM_LIBS=ON" configure flag David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 16/32] gnu: nnpack: Update to commit 70a77f4 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 17/32] gnu: oneapi-dnnl: Update to 3.3.5 David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 18/32] gnu: Add tensorpipe David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 19/32] gnu: Add fbgemm David Elsing
2024-03-23 22:04       ` [bug#69591] [PATCH v4 20/32] gnu: Add qnnpack David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 21/32] gnu: Add foxi David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 22/32] gnu: Add ideep-pytorch David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 23/32] gnu: xnnpack: Update to commit 51a9875 David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 24/32] gnu: Remove xnnpack-for-torch2 David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 25/32] gnu: Add qnnpack-pytorch David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 26/32] gnu: python-pytorch: Update to 2.2.1 and unbundle dependencies David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 27/32] gnu: Add python-pytorch-avx David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 28/32] gnu: python-torchvision: Update to 0.17.1 David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 29/32] gnu: Add ideep-pytorch-for-r-torch David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 30/32] gnu: Add oneapi-dnnl-for-r-torch David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 31/32] gnu: Add qnnpack-pytorch-for-r-torch David Elsing
2024-03-23 22:05       ` [bug#69591] [PATCH v4 32/32] gnu: python-pytorch-for-r-torch: Adjust to new python-pytorch David Elsing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240320223906.13214-15-david.elsing@posteo.net \
    --to=david.elsing@posteo.net \
    --cc=69591@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).