unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: 68024@debbugs.gnu.org
Subject: [bug#68024] [PATCH] Remove ocaml4.07 packages
Date: Mon, 25 Dec 2023 12:18:21 +0100	[thread overview]
Message-ID: <20231225121821.009eda51@tachikoma.lepiller.eu> (raw)

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi Guix!

I created a long patch series (67 patches) to remove ocaml 4.07
packages. The series keeps ocaml@4.07 itself, as well as findlib and
dune, so we can always build ocaml4.07 packages later if we want to (we
might need to build at least menhir, that will be required to build
ocaml>4.07)

I don't think it requires QA, since we're only removing packages.
Patches look like the attached patch. If you agree with this in
principle, I'll push the series this week.

I checked that each intermediate commit builds (no unbound variable),
used guix refresh to discover a proper order (removing leaf packages).
If you prefer, I can send the whole series.

[-- Attachment #2: 0033-gnu-Remove-ocaml4.07-ppx-hash.patch --]
[-- Type: text/x-patch, Size: 2317 bytes --]

From b5a46ee697742820e68a4689c20e419b74b60cc4 Mon Sep 17 00:00:00 2001
Message-ID: <b5a46ee697742820e68a4689c20e419b74b60cc4.1703502940.git.julien@lepiller.eu>
In-Reply-To: <42ca866dca866a942d641f3d369ad9657b92294f.1703502940.git.julien@lepiller.eu>
References: <42ca866dca866a942d641f3d369ad9657b92294f.1703502940.git.julien@lepiller.eu>
From: Julien Lepiller <julien@lepiller.eu>
Date: Mon, 25 Dec 2023 11:04:29 +0100
Subject: [PATCH 33/67] gnu: Remove ocaml4.07-ppx-hash.

* gnu/packages/ocaml.scm (ocaml4.07-ppx-hash): Remove variable.
(ocaml-ppx-hash)[properties]: Remove variant.

Change-Id: I38a4e5a4deb88398ae714b0671c9477551e7b6d9
---
 gnu/packages/ocaml.scm | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index ac2da9cead..bbcf97ccb0 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -6897,32 +6897,13 @@ (define-public ocaml-ppx-hash
     (propagated-inputs
      (list ocaml-base ocaml-ppx-compare ocaml-ppx-sexp-conv
            ocaml-migrate-parsetree ocaml-ppxlib))
-    (properties `((upstream-name . "ppx_hash")
-                  (ocaml4.07-variant . ,(delay ocaml4.07-ppx-hash))))
+    (properties `((upstream-name . "ppx_hash")))
     (home-page "https://github.com/janestreet/ppx_hash")
     (synopsis "Generation of hash functions from type expressions and definitions")
     (description "This package is a collection of ppx rewriters that generate
 hash functions from type exrpessions and definitions.")
     (license license:asl2.0)))
 
-(define-public ocaml4.07-ppx-hash
-  (package-with-ocaml4.07
-   (package
-     (inherit ocaml-ppx-hash)
-     (name "ocaml-ppx-hash")
-     (home-page "https://github.com/janestreet/ppx_hash")
-     (version "0.11.1")
-     (source (origin
-               (method git-fetch)
-               (uri (git-reference
-                     (url home-page)
-                     (commit (string-append "v" version))))
-               (file-name (git-file-name name version))
-               (sha256
-                (base32
-                 "1p0ic6aijxlrdggpmycj12q3cy9xksbq2vq727215maz4snvlf5p"))))
-     (properties `((upstream-name . "ppx_hash"))))))
-
 (define-public ocaml-ppx-enumerate
   (package
     (name "ocaml-ppx-enumerate")
-- 
2.41.0


             reply	other threads:[~2023-12-25 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-25 11:18 Julien Lepiller [this message]
2023-12-25 18:58 ` [bug#68024] [PATCH] Remove ocaml4.07 packages pukkamustard
2023-12-30 21:20   ` bug#68024: " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231225121821.009eda51@tachikoma.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=68024@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).