From: Arun Isaac <arunisaac@systemreboot.net>
To: 63802@debbugs.gnu.org
Cc: Arun Isaac <arunisaac@systemreboot.net>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#63802] [mumi PATCH 1/3] client: Do not pass --add-header to git send-email.
Date: Tue, 30 May 2023 13:14:45 +0100 [thread overview]
Message-ID: <20230530121447.26236-1-arunisaac@systemreboot.net> (raw)
In-Reply-To: <20230530121132.26057-1-arunisaac@systemreboot.net>
git send-email accepts --add-header only when passed a git
format-patch style revision list.
* mumi/client.scm (send-email): Do not pass --add-header to
git-send-email.
* tests/client.scm ("send patch to existing issue and Cc other
participants"): Do not expect --add-header.
---
mumi/client.scm | 5 +----
tests/client.scm | 6 +-----
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/mumi/client.scm b/mumi/client.scm
index b575daa..5befd42 100644
--- a/mumi/client.scm
+++ b/mumi/client.scm
@@ -287,10 +287,7 @@ ISSUE-NUMBER."
(git-send-email (string-append (number->string issue-number)
"@"
(client-config 'debbugs-host))
- patches
- (map (cut string-append "--add-header=X-Debbugs-Cc: " <>)
- (assq-ref (reply-email-headers issue-number)
- 'cc))))
+ patches))
(match patches
;; If it's a single patch, send it to the patch email address
;; and be done with it
diff --git a/tests/client.scm b/tests/client.scm
index 5729521..5352b08 100644
--- a/tests/client.scm
+++ b/tests/client.scm
@@ -126,11 +126,7 @@ called with."
(list "foo.patch")))))))
(test-equal "send patch to existing issue and Cc other participants"
- '(("git" "send-email"
- "--to=12345@example.com"
- "--add-header=X-Debbugs-Cc: John Doe <jdoe@machine.example>"
- "--add-header=X-Debbugs-Cc: Mary Smith <mary@example.net>"
- "foo.patch"))
+ '(("git" "send-email" "--to=12345@example.com" "foo.patch"))
(map (match-lambda
((command _) command))
(trace-calls (var@@ (mumi client) call-with-input-pipe*)
--
2.39.2
next prev parent reply other threads:[~2023-05-30 12:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:11 [bug#63802] [mumi PATCH 0/3] Use consolidated X-Debbugs-Cc header Arun Isaac
2023-05-30 12:14 ` Arun Isaac [this message]
2023-05-30 12:14 ` [bug#63802] [mumi PATCH 2/3] client: Add git-send-email-headers subcommand Arun Isaac
2023-06-05 2:31 ` Maxim Cournoyer
2023-06-08 17:09 ` Arun Isaac
2023-06-08 17:29 ` Arun Isaac
2023-05-30 12:14 ` [bug#63802] [mumi PATCH 3/3] client: Use mumi " Arun Isaac
2023-06-05 2:36 ` Maxim Cournoyer
2023-06-05 2:21 ` [bug#63802] [mumi PATCH 1/3] client: Do not pass --add-header to git send-email Maxim Cournoyer
2023-06-08 17:14 ` [bug#63802] [PATCH 1/3] client: Separate serialize-email-address into a function Arun Isaac
2023-06-08 17:14 ` [bug#63802] [PATCH 2/3] client: Add git-send-email-headers subcommand Arun Isaac
2023-07-16 3:39 ` [bug#63802] [mumi PATCH 0/3] Use consolidated X-Debbugs-Cc header Maxim Cournoyer
2023-07-17 22:14 ` Arun Isaac
2023-07-18 15:32 ` Maxim Cournoyer
2023-07-19 16:49 ` bug#63802: " Arun Isaac
2023-06-08 17:14 ` [bug#63802] [PATCH 3/3] client: Use mumi git-send-email-headers subcommand Arun Isaac
2023-07-16 4:01 ` [bug#63802] [mumi PATCH 0/3] Use consolidated X-Debbugs-Cc header Maxim Cournoyer
2023-07-17 22:14 ` Arun Isaac
2023-07-16 3:14 ` Maxim Cournoyer
2023-07-17 22:19 ` [bug#63802] [PATCH 1/3] client: Separate serialize-email-address into a procedure Arun Isaac
2023-07-17 22:19 ` [bug#63802] [PATCH 2/3] client: Add git-send-email-headers subcommand Arun Isaac
2023-07-17 22:19 ` [bug#63802] [PATCH 3/3] client: Use mumi " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530121447.26236-1-arunisaac@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=63802@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).