From: Saku Laesvuori via Guix-patches via <guix-patches@gnu.org>
To: Bruno Victal <mirai@makinata.eu>
Cc: 62642@debbugs.gnu.org
Subject: [bug#62642] [PATCH] services: certbot: Fix nginx crash when certbot is used without domains
Date: Mon, 3 Apr 2023 21:06:59 +0300 [thread overview]
Message-ID: <20230403180659.zhbtbfnn2uhgplgc@X-kone> (raw)
In-Reply-To: <66755b58-1cb1-eae6-a4ac-69c174ed58aa@makinata.eu>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
Hi,
> Is there a use-case for certbot without any certificate configurations provided?
I was writing a service that extends certbot if a configuration option
for it is set to #t. To me it seems that it is currently impossible to
view the configuration in the service type definition, so I worked
around it by extending certbot-service-type with an empty list if the
option is set to #f.
> IMO it looks to me that the 'certificates' field shouldn't have a default value
> configured instead?
Wouldn't that mean that users who use certbot only via services that
extend it would have to configure 'certificates' to () manually and have
their nginx configuration crash if they remove the extending services
and forget to remove the certbot service?
- Saku
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-03 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 13:32 [bug#62642] [PATCH] services: certbot: Fix nginx crash when certbot is used without domains Saku Laesvuori via Guix-patches via
2023-04-03 14:28 ` Bruno Victal
2023-04-03 18:06 ` Saku Laesvuori via Guix-patches via [this message]
2023-04-04 13:21 ` Bruno Victal
2023-04-04 20:43 ` [bug#62642] [PATCH v2] " Saku Laesvuori via Guix-patches via
2023-06-18 21:11 ` bug#62642: [PATCH] " Ludovic Courtès
2023-04-13 9:00 ` [bug#62642] " Saku Laesvuori via Guix-patches via
2023-05-22 11:34 ` Saku Laesvuori via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403180659.zhbtbfnn2uhgplgc@X-kone \
--to=guix-patches@gnu.org \
--cc=62642@debbugs.gnu.org \
--cc=mirai@makinata.eu \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).