unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests
@ 2023-03-26 19:13 ROCKTAKEY
  2023-03-27  8:18 ` [bug#62472] [PATCH 1/2] gnu: conan: Remove some tests about git submodule ROCKTAKEY
  0 siblings, 1 reply; 7+ messages in thread
From: ROCKTAKEY @ 2023-03-26 19:13 UTC (permalink / raw)
  To: 62472; +Cc: ROCKTAKEY

Some tests of conan is failed, so I fixed the package definition not to run these tests.

ROCKTAKEY (2):
  gnu: conan: Remove some tests about git submodule.
  gnu: conan: Remove test_token_expired test.

 gnu/packages/package-management.scm | 6 ++++++
 1 file changed, 6 insertions(+)


base-commit: 34f2d3aad7009955bd426b0dfd6ce62c64fff458
-- 
2.39.2





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#62472] [PATCH 1/2] gnu: conan: Remove some tests about git submodule.
  2023-03-26 19:13 [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests ROCKTAKEY
@ 2023-03-27  8:18 ` ROCKTAKEY
  2023-03-27  8:18   ` [bug#62472] [PATCH 2/2] gnu: conan: Remove test_token_expired test ROCKTAKEY
  0 siblings, 1 reply; 7+ messages in thread
From: ROCKTAKEY @ 2023-03-27  8:18 UTC (permalink / raw)
  To: 62472; +Cc: ROCKTAKEY

* gnu/packages/package-management.scm (conan): Remove some tests about git submodule.
Due to CVE-2022-39253, transport "file://" is not allowed by Git.
---
 gnu/packages/package-management.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 562d228cf4..e5048c95d6 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -1215,6 +1215,10 @@ (define system ,(or (%current-target-system)
                         ;; These tests expect the 'apt' command to be available.
                         "and not test_apt_check "
                         "and not test_apt_install_substitutes "
+                        ;; Due to CVE-2022-39253, transport "file://" is not allowed by Git.
+                        ;; https://lore.kernel.org/git/xmqq4jw1uku5.fsf@gitster.g/T/#u
+                        "and not test_submodule "
+                        "and not test_clone_submodule_git "
                         (if (not (string-prefix? "x86_64" system))
                             ;; These tests either assume the machine is
                             ;; x86_64, or require a cross-compiler to target
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#62472] [PATCH 2/2] gnu: conan: Remove test_token_expired test.
  2023-03-27  8:18 ` [bug#62472] [PATCH 1/2] gnu: conan: Remove some tests about git submodule ROCKTAKEY
@ 2023-03-27  8:18   ` ROCKTAKEY
  2023-03-30 20:13     ` bug#62472: [PATCH 0/2] gnu: conan: Remove some failed tests Maxim Cournoyer
  0 siblings, 1 reply; 7+ messages in thread
From: ROCKTAKEY @ 2023-03-27  8:18 UTC (permalink / raw)
  To: 62472; +Cc: ROCKTAKEY

* gnu/packages/package-management.scm (conan): Remove test_token_expired test.
---
 gnu/packages/package-management.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index e5048c95d6..bcd072a442 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -1219,6 +1219,8 @@ (define system ,(or (%current-target-system)
                         ;; https://lore.kernel.org/git/xmqq4jw1uku5.fsf@gitster.g/T/#u
                         "and not test_submodule "
                         "and not test_clone_submodule_git "
+                        ;; FIXME: Sometimes failed due to logging in problem on "conan upload"
+                        "and not test_token_expired "
                         (if (not (string-prefix? "x86_64" system))
                             ;; These tests either assume the machine is
                             ;; x86_64, or require a cross-compiler to target
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* bug#62472: [PATCH 0/2] gnu: conan: Remove some failed tests
  2023-03-27  8:18   ` [bug#62472] [PATCH 2/2] gnu: conan: Remove test_token_expired test ROCKTAKEY
@ 2023-03-30 20:13     ` Maxim Cournoyer
  2023-03-31 10:25       ` [bug#62472] " ROCKTAKEY
  0 siblings, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2023-03-30 20:13 UTC (permalink / raw)
  To: ROCKTAKEY; +Cc: 62472-done

Hello!

ROCKTAKEY <rocktakey@gmail.com> writes:

> * gnu/packages/package-management.scm (conan): Remove test_token_expired test.

Thanks for the submission.  I ended up attempting to update the package;
it was more work than I had hoped, but it works and reduced the number
of disabled tests.  See commit 7ceedc7df7d6f0d1209dee1eaa9c1dfe772ca0dd
("gnu: conan: Update to 2.0.2.").

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests
  2023-03-30 20:13     ` bug#62472: [PATCH 0/2] gnu: conan: Remove some failed tests Maxim Cournoyer
@ 2023-03-31 10:25       ` ROCKTAKEY
  2023-03-31 14:30         ` Maxim Cournoyer
  0 siblings, 1 reply; 7+ messages in thread
From: ROCKTAKEY @ 2023-03-31 10:25 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 62472-done

Hi!

Thanks for your work. Updating to 2.0.2 is better.

But in my environment, some other tests are failed:

=========================== short test summary info 
============================
FAILED 
conans/test/functional/toolchains/cmake/test_cmake.py::LinuxTest::test_toolchain_linux_0_Debug
FAILED 
conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids[True]
FAILED 
conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids_all_rrevs[True]
FAILED 
conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_latest_prevs[True]
FAILED 
conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_all_prevs[True]
= 5 failed, 3016 passed, 321 skipped, 165 xfailed, 9 xpassed, 12 
warnings in 510.98s (0:08:30) =

--

ROCKTAKEY

On 2023/03/31 5:13, Maxim Cournoyer wrote:
> Hello!
>
> ROCKTAKEY <rocktakey@gmail.com> writes:
>
>> * gnu/packages/package-management.scm (conan): Remove test_token_expired test.
> Thanks for the submission.  I ended up attempting to update the package;
> it was more work than I had hoped, but it works and reduced the number
> of disabled tests.  See commit 7ceedc7df7d6f0d1209dee1eaa9c1dfe772ca0dd
> ("gnu: conan: Update to 2.0.2.").
>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests
  2023-03-31 10:25       ` [bug#62472] " ROCKTAKEY
@ 2023-03-31 14:30         ` Maxim Cournoyer
  2023-03-31 16:57           ` ROCKTAKEY
  0 siblings, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2023-03-31 14:30 UTC (permalink / raw)
  To: ROCKTAKEY; +Cc: 62472-done

Hello,

ROCKTAKEY <rocktakey@gmail.com> writes:

> Hi!
>
> Thanks for your work. Updating to 2.0.2 is better.
>
> But in my environment, some other tests are failed:
>
> =========================== short test summary info
> ============================
> FAILED
> conans/test/functional/toolchains/cmake/test_cmake.py::LinuxTest::test_toolchain_linux_0_Debug
> FAILED
> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids[True]
> FAILED
> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids_all_rrevs[True]
> FAILED
> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_latest_prevs[True]
> FAILED
> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_all_prevs[True]
> = 5 failed, 3016 passed, 321 skipped, 165 xfailed, 9 xpassed, 12
> warnings in 510.98s (0:08:30) =

I was able to reproduce it for test_toolchain_linux_0_Debug, which I've
now skipped, but not for the other tests.  The build farm reproduced
them though [0]:

=========================== short test summary info ============================
FAILED conans/test/functional/toolchains/cmake/test_cmake.py::LinuxTest::test_toolchain_linux_0_Debug
FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids[True]
FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids_all_rrevs[True]
FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_latest_prevs[True]
FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_all_prevs[True]

[0]  https://ci.guix.gnu.org/build/666884/log/raw

I've reported the failure upstream and disabled these as well:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/package-management.scm
@@ -1209,7 +1209,7 @@ (define system #$(or (%current-target-system)
                 (setenv "CONFIG_SHELL" (which "sh"))
                 (setenv "PATH" (string-append (getenv "PATH") ":"
                                               #$output "/bin"))
-                (invoke "python" "-m" "pytest"
+                (invoke "python" "-m" "pytest" "-vv"
                         "-n" (number->string (parallel-job-count))
                         "-m" "not slow"
                         ;; Disable problematic tests.
@@ -1222,6 +1222,12 @@ (define system #$(or (%current-target-system)
                          ;; expected by the following test.
                          "and not pkg_config_path "
                          "and not compare " ;caused by newer node-semver?
+                         ;; This test hard-codes a compiler version.
+                         "and not test_toolchain "
+                         ;; The 'test_list' tests may fail
+                         ;; non-deterministically (see:
+                         ;; https://github.com/conan-io/conan/issues/13583).
+                         "and not test_list "
                          ;; These tests fail when Autoconf attempt to load a
                          ;; shared library in the same directory (see:
                          ;; https://github.com/conan-io/conan/issues/13577).
--8<---------------cut here---------------end--------------->8---

Hopefully it now builds on your side as well.  Thanks for the report!

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests
  2023-03-31 14:30         ` Maxim Cournoyer
@ 2023-03-31 16:57           ` ROCKTAKEY
  0 siblings, 0 replies; 7+ messages in thread
From: ROCKTAKEY @ 2023-03-31 16:57 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 62472-done

It works well. Thanks!

On 2023/03/31 23:30, Maxim Cournoyer wrote:
> Hello,
>
> ROCKTAKEY <rocktakey@gmail.com> writes:
>
>> Hi!
>>
>> Thanks for your work. Updating to 2.0.2 is better.
>>
>> But in my environment, some other tests are failed:
>>
>> =========================== short test summary info
>> ============================
>> FAILED
>> conans/test/functional/toolchains/cmake/test_cmake.py::LinuxTest::test_toolchain_linux_0_Debug
>> FAILED
>> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids[True]
>> FAILED
>> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids_all_rrevs[True]
>> FAILED
>> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_latest_prevs[True]
>> FAILED
>> conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_all_prevs[True]
>> = 5 failed, 3016 passed, 321 skipped, 165 xfailed, 9 xpassed, 12
>> warnings in 510.98s (0:08:30) =
> I was able to reproduce it for test_toolchain_linux_0_Debug, which I've
> now skipped, but not for the other tests.  The build farm reproduced
> them though [0]:
>
> =========================== short test summary info ============================
> FAILED conans/test/functional/toolchains/cmake/test_cmake.py::LinuxTest::test_toolchain_linux_0_Debug
> FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids[True]
> FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_pkg_ids_all_rrevs[True]
> FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_latest_prevs[True]
> FAILED conans/test/integration/command_v2/list_test.py::TestListPrefs::test_list_all_prevs[True]
>
> [0]  https://ci.guix.gnu.org/build/666884/log/raw
>
> I've reported the failure upstream and disabled these as well:
>
> --8<---------------cut here---------------start------------->8---
> modified   gnu/packages/package-management.scm
> @@ -1209,7 +1209,7 @@ (define system #$(or (%current-target-system)
>                   (setenv "CONFIG_SHELL" (which "sh"))
>                   (setenv "PATH" (string-append (getenv "PATH") ":"
>                                                 #$output "/bin"))
> -                (invoke "python" "-m" "pytest"
> +                (invoke "python" "-m" "pytest" "-vv"
>                           "-n" (number->string (parallel-job-count))
>                           "-m" "not slow"
>                           ;; Disable problematic tests.
> @@ -1222,6 +1222,12 @@ (define system #$(or (%current-target-system)
>                            ;; expected by the following test.
>                            "and not pkg_config_path "
>                            "and not compare " ;caused by newer node-semver?
> +                         ;; This test hard-codes a compiler version.
> +                         "and not test_toolchain "
> +                         ;; The 'test_list' tests may fail
> +                         ;; non-deterministically (see:
> +                         ;; https://github.com/conan-io/conan/issues/13583).
> +                         "and not test_list "
>                            ;; These tests fail when Autoconf attempt to load a
>                            ;; shared library in the same directory (see:
>                            ;; https://github.com/conan-io/conan/issues/13577).
> --8<---------------cut here---------------end--------------->8---
>
> Hopefully it now builds on your side as well.  Thanks for the report!
>




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-03-31 16:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 19:13 [bug#62472] [PATCH 0/2] gnu: conan: Remove some failed tests ROCKTAKEY
2023-03-27  8:18 ` [bug#62472] [PATCH 1/2] gnu: conan: Remove some tests about git submodule ROCKTAKEY
2023-03-27  8:18   ` [bug#62472] [PATCH 2/2] gnu: conan: Remove test_token_expired test ROCKTAKEY
2023-03-30 20:13     ` bug#62472: [PATCH 0/2] gnu: conan: Remove some failed tests Maxim Cournoyer
2023-03-31 10:25       ` [bug#62472] " ROCKTAKEY
2023-03-31 14:30         ` Maxim Cournoyer
2023-03-31 16:57           ` ROCKTAKEY

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).