unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#62100] [PATCH] gnu: Remove python-pre-commit.
@ 2023-03-10 17:17 Antero Mejr via Guix-patches via
  2023-03-10 17:21 ` [bug#62100] [PATCH 01/13] gnu: python-jupytext: " Antero Mejr via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 50+ messages in thread
From: Antero Mejr via Guix-patches via @ 2023-03-10 17:17 UTC (permalink / raw)
  To: 62100; +Cc: Antero Mejr, lars

* gnu/packages/python-xyz.scm (python-pre-commit): Delete variable.
* gnu/packages/version-control.scm (pre-commit): Add comment referencing
python-pre-commit.
---
Please apply this patch last, after the rest of the series.
Will cause ~70-80 rebuilds from what I can see.

pre-commit and python-pre-commit are duplicates, but pre-commit is better
packaged and newer. pre-commit should never be a native-input of python
packages: it's a package manager for commit linting, which is completely
irrelevant to builds.

Resolves 53502:
https://issues.guix.gnu.org/53502

 gnu/packages/python-xyz.scm      | 30 ------------------------------
 gnu/packages/version-control.scm |  2 +-
 2 files changed, 1 insertion(+), 31 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8243bb9fd3..b2fb60f322 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -24284,36 +24284,6 @@ (define-public python-retrying
 @end itemize")
     (license license:asl2.0)))
 
-(define-public python-pre-commit
-  (package
-    (name "python-pre-commit")
-    (version "2.10.0")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (pypi-uri "pre_commit" version))
-       (sha256
-        (base32 "1ycf6wpxrhxhdzz0vpryhbdxlwik5khgcvp3hxwvfr447a6k84zl"))))
-    (build-system python-build-system)
-    (arguments
-     ;; Tests fail with "AttributeError: module 'pre_commit.resources' has no
-     ;; attribute 'empty_template_setup'".
-     `(#:tests? #false))
-    (propagated-inputs
-     (list python-cfgv
-           python-identify
-           python-importlib-metadata
-           python-nodeenv
-           python-pyyaml
-           python-toml
-           python-virtualenv))
-    (home-page "https://github.com/pre-commit/pre-commit")
-    (synopsis "Framework for managing multi-language pre-commit hooks")
-    (description
-     "This package provides a framework for managing and maintaining
-multi-language pre-commit hooks.")
-    (license license:expat)))
-
 (define-public python-precis-i18n
   (package
     (name "python-precis-i18n")
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 8b0997768d..96378a73d3 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1667,7 +1667,7 @@ (define-public gitile
 
 (define-public pre-commit
   (package
-    (name "pre-commit")
+    (name "pre-commit") ;formerly known as python-pre-commit
     (version "2.20.0")
     (source
      (origin
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 50+ messages in thread

end of thread, other threads:[~2023-03-12 11:15 UTC | newest]

Thread overview: 50+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 17:17 [bug#62100] [PATCH] gnu: Remove python-pre-commit Antero Mejr via Guix-patches via
2023-03-10 17:21 ` [bug#62100] [PATCH 01/13] gnu: python-jupytext: " Antero Mejr via Guix-patches via
2023-03-10 17:21   ` [bug#62100] [PATCH 02/13] gnu: python-bidict: " Antero Mejr via Guix-patches via
2023-03-10 17:21   ` [bug#62100] [PATCH 03/13] gnu: python-pyjwt: " Antero Mejr via Guix-patches via
2023-03-10 17:21   ` [bug#62100] [PATCH 04/13] gnu: python-marshmallow: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 05/13] gnu: python-marshmallow-jsonapi: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 06/13] gnu: python-apispec: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 07/13] gnu: python-apispec-webframeworks: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 08/13] gnu: python-minikanren: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 09/13] gnu: python-doubletdetection: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 10/13] gnu: scvelo: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 11/13] gnu: python-pytest-regressions: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 12/13] gnu: mdpo: " Antero Mejr via Guix-patches via
2023-03-10 17:22   ` [bug#62100] [PATCH 13/13] gnu: python-sphinxcontrib-apidoc: " Antero Mejr via Guix-patches via
2023-03-11  1:31 ` [bug#62100] [PATCH v2 01/15] gnu: pre-commit: Update to 3.1.1 Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 02/15] gnu: python-jupytext: Remove python-pre-commit Antero Mejr via Guix-patches via
2023-03-11  7:52     ` Liliana Marie Prikler
2023-03-11 13:44       ` Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 03/15] gnu: python-bidict: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 04/15] gnu: python-pyjwt: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 05/15] gnu: python-marshmallow: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 06/15] gnu: python-marshmallow-jsonapi: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 07/15] gnu: python-apispec: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 08/15] gnu: python-apispec-webframeworks: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 09/15] gnu: python-minikanren: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 10/15] gnu: python-doubletdetection: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 11/15] gnu: scvelo: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 12/15] gnu: python-pytest-regressions: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 13/15] gnu: mdpo: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 14/15] gnu: python-sphinxcontrib-apidoc: " Antero Mejr via Guix-patches via
2023-03-11  1:31   ` [bug#62100] [PATCH v2 15/15] gnu: " Antero Mejr via Guix-patches via
2023-03-11  7:56 ` [bug#62100] [PATCH] " Lars-Dominik Braun
2023-03-11 13:41   ` Antero Mejr via Guix-patches via
2023-03-12 11:14     ` bug#62100: " Lars-Dominik Braun
2023-03-11 13:39 ` [bug#62100] [PATCH v3 01/16] gnu: pre-commit: Update to 3.1.1 Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 02/16] gnu: python-jupytext: Replace python-pre-commit with pre-commit Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 03/16] gnu: python-bidict: Remove python-pre-commit Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 04/16] gnu: python-pyjwt: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 05/16] gnu: python-marshmallow: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 06/16] gnu: python-marshmallow-jsonapi: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 07/16] gnu: python-apispec: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 08/16] gnu: python-apispec-webframeworks: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 09/16] gnu: python-minikanren: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 10/16] gnu: python-doubletdetection: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 11/16] gnu: scvelo: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 12/16] gnu: python-pytest-regressions: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 13/16] gnu: mdpo: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 14/16] gnu: python-sphinxcontrib-apidoc: " Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 15/16] gnu: python-pre-commit: Replace with pre-commit Antero Mejr via Guix-patches via
2023-03-11 13:39   ` [bug#62100] [PATCH v3 16/16] lint: Check that python-pre-commit is not an input Antero Mejr via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).