[bug#61042] [PATCH 0/6] Upgrade spice packages

[bug#61042] [PATCH 0/6] Upgrade spice packages

[Simon Streit]

I've prepared a patch series to upgrade most of the packages that belong to
spice family.

There could be more details that I've missed while upgrading.  I temporarily
disabled tests in spice-gtk.  So far 'disable-session-test fails to succeed
after changing the build system to meson.

I will happily accept any suggestions for improvement and provide a second
batch of patches.


Kind regards

Simon Streit (6):
  gnu: usbredir: Update to 0.13.0.
  gnu: virglrenderer: Update to 0.10.4.
  gnu: spice-protocol: Update to 0.14.4.
  gnu: spice-gtk: Update to 0.41.
  gnu: spice: Update to 0.15.1.
  gnu: spice-vdagent: Update to 0.22.0.

 gnu/packages/spice.scm | 112 ++++++++++++++++++++---------------------
 1 file changed, 56 insertions(+), 56 deletions(-)

--
2.39.1

[bug#61042] [PATCH 1/6] gnu: usbredir: Update to 0.13.0.

[Simon Streit]

* gnu/packages/spice.scm (usbredir): Update to 0.1.30.
  [build-system]: Change to meson-build-system.
  [inputs]: Add glib.
---
 gnu/packages/spice.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 2be724c455..fd0ac077ed 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2019, 2020, 2022 Marius Bakke <marius@gnu.org>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2023 Simon Streit <simon@netpanic.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -60,19 +61,20 @@ (define-public usbredir
   (package
     (name "usbredir")
     (home-page "https://spice-space.org")
-    (version "0.9.0")
+    (version "0.13.0")
     (source (origin
               (method url-fetch)
               (uri (string-append home-page "/download/" name "/" name "-"
                                   version ".tar.xz"))
               (sha256
                (base32
-                "19jnpzlanq0a1m5lmlcsp50wxf7icxvpvclx7hnf0zxw8azngqd3"))))
-    (build-system gnu-build-system)
+                "0vn4gnd8nmnrvvj2rm7akf4sbcslmdk3v22k9kmxxrha5jhgm9jb"))))
+    (build-system meson-build-system)
     (propagated-inputs
      (list libusb))
     (native-inputs
      (list autoconf automake libtool pkg-config))
+    (inputs (list glib))
     (synopsis "Tools for sending USB device traffic over a network")
     (description
      "Usbredir is a network protocol for sending USB device traffic over a
-- 
2.39.1

[bug#61042] [PATCH 2/6] gnu: virglrenderer: Update to 0.10.4.

[Simon Streit]

* gnu/packages/spice.scm (virglrenderer): Update to 0.10.4.
  [uri]: Update source uri.
  [build-system] Change to meson-build-system.
  [inputs]: Add python; remove eudev.
  [home-page]: Update url.
---
 gnu/packages/spice.scm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index fd0ac077ed..6eb8a4bfc7 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -85,25 +85,24 @@ (define-public usbredir
 (define-public virglrenderer
   (package
     (name "virglrenderer")
-    (version "0.6.0")
+    (version "0.10.4")
     (source (origin
               (method url-fetch)
-              (uri (string-append
-                "https://www.freedesktop.org/software/virgl/"
-                "virglrenderer-" version ".tar.bz2"))
-              (patches (search-patches "virglrenderer-CVE-2017-6386.patch"))
+              (uri (string-append "https://gitlab.freedesktop.org/virgl/"
+                    name "/-/archive/" version "/" name "-" version
+                    ".tar.gz"))
               (sha256
                (base32
-                "06kf0q4l52gzx5p63l8850hff8pmhp7xv1hk8zgx2apbw18y6jd5"))))
-    (build-system gnu-build-system)
+                "0522czb3nixkpwjknw3w1ifaj50686a2aj46v4r5cr0zh9cxqgys"))))
+    (build-system meson-build-system)
     (inputs
-      (list libepoxy mesa eudev))
+      (list libepoxy mesa python))
     (native-inputs
       (list pkg-config))
     (synopsis "Virtual 3D GPU library")
     (description "A virtual 3D GPU library that enables a virtualized operating
 system to use the host GPU to accelerate 3D rendering.")
-    (home-page "https://virgil3d.github.io")
+    (home-page "https://gitlab.freedesktop.org/virgl/virglrenderer")
     (license (list license:expat license:bsd-3))))
 
 (define-public spice-protocol
-- 
2.39.1

[bug#61042] [PATCH 3/6] gnu: spice-protocol: Update to 0.14.4.

[Simon Streit]

* gnu/packages/spice.scm (spice-protocol): Update to 0.14.4.
---
 gnu/packages/spice.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 6eb8a4bfc7..cfcae44b91 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -108,7 +108,7 @@ (define-public virglrenderer
 (define-public spice-protocol
   (package
     (name "spice-protocol")
-    (version "0.14.3")
+    (version "0.14.4")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -116,7 +116,7 @@ (define-public spice-protocol
                 "spice-protocol-" version ".tar.xz"))
               (sha256
                (base32
-                "0yj8k7gcirrsf21w0q6146n5g4nzn2pqky4p90n5760m5ayfb1pr"))))
+                "04nr2w6ymy5jinfi3lj6205yd5h0swss3ykxqk7l3m4z1mhvmzq4"))))
     (build-system meson-build-system)
     (arguments
      `(#:phases
-- 
2.39.1

[bug#61042] [PATCH 4/6] gnu: spice-gtk: Update to 0.41.

[Simon Streit]

* gnu/packages/spice.scm (spice-gtk): Update to 0.41.
  [source]: Modify uri scheme.
  [build-system]: Change to meson-build-system.
  [inputs]: Remove labels.
  [native-inputs]: Remove labels.
  [arguments]: Disable tests temporarily.
---
 gnu/packages/spice.scm | 68 ++++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index cfcae44b91..1f68b1309d 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -42,6 +42,8 @@ (define-module (gnu packages spice)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-build)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages security-token)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages virtualization)
@@ -138,16 +140,16 @@ (define-public spice-protocol
 (define-public spice-gtk
   (package
     (name "spice-gtk")
-    (version "0.37")
+    (version "0.41")
     (source (origin
               (method url-fetch)
               (uri (string-append
                 "https://spice-space.org/download/gtk/"
-                "spice-gtk-" version ".tar.bz2"))
+                name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1drvj8y35gnxbnrxsipwi15yh0vs9ixzv4wslz6r3lra8w3bfa0z"))))
-    (build-system gnu-build-system)
+                "17wnl2yfaic4zd4k7iz76rpdpb3jgnk7dhlcxcp7114ixb5vby6q"))))
+    (build-system meson-build-system)
     (propagated-inputs
       (list gstreamer
             gst-plugins-base
@@ -158,39 +160,39 @@ (define-public spice-gtk
             pixman
             openssl-1.1))
     (inputs
-      `(("glib-networking" ,glib-networking)
-        ("gobject-introspection" ,gobject-introspection)
-        ("json-glib" ,json-glib)
-        ("libepoxy" ,libepoxy)
-        ("libjpeg" ,libjpeg-turbo)
-        ("libxcb" ,libxcb)
-        ("lz4" ,lz4)
-        ("mesa" ,mesa)
-        ("pulseaudio" ,pulseaudio)
-        ("python" ,python)
-        ("opus" ,opus)
-        ("usbredir" ,usbredir)))
+      (list bash-minimal
+            glib-networking
+            json-glib
+            libepoxy
+            libjpeg-turbo
+            libxcb
+            lz4
+            mesa
+            opus
+            pulseaudio
+            python
+            python-pyparsing
+            python-six
+            usbredir))
     (native-inputs
-      `(("glib:bin" ,glib "bin")
-        ("intltool" ,intltool)
-        ("pkg-config" ,pkg-config)
-        ("vala" ,vala)))
+      (list `(,glib "bin")
+            gobject-introspection
+            intltool
+            pkg-config
+            python
+            vala))
     (arguments
-      `(#:configure-flags
-        '("--enable-gstaudio"
-          "--enable-gstvideo"
-          "--enable-pulse"
-          "--enable-vala"
-          "--enable-introspection")
+      `(#:tests? #f
         #:phases
          (modify-phases %standard-phases
-           (add-before 'check 'disable-session-test
-             (lambda _
-               ;; XXX: Disable session tests, because they require USB support,
-               ;; which is not available in the build container.
-               (substitute* "tests/Makefile"
-                 (("test-session\\$\\(EXEEXT\\) ") ""))
-               #t))
+           ;; (add-before 'check 'disable-session-test
+           ;;   (lambda _
+           ;;     ;; XXX: Disable session tests, because they require USB
+           ;;     ;; support, which is not available in the build container.
+           ;;     (substitute* "tests/meson.build"
+           ;;       (("[ \t]*.*session.*$") ""))
+           ;;     #t
+           ;;     ))
            (add-after 'install 'patch-la-files
              (lambda* (#:key inputs outputs #:allow-other-keys)
                (let ((out (assoc-ref outputs "out"))
-- 
2.39.1

[bug#61042] [PATCH 5/6] gnu: spice: Update to 0.15.1.

[Simon Streit]

* gnu/packages/spice.scm (spice): Update to 0.15.1.
  [inputs]: Add bash-minimal.
---
 gnu/packages/spice.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 1f68b1309d..44080049c5 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -219,7 +219,7 @@ (define-public spice-gtk
 (define-public spice
   (package
     (name "spice")
-    (version "0.15.0")
+    (version "0.15.1")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -227,12 +227,13 @@ (define-public spice
                 "spice-server/spice-" version ".tar.bz2"))
               (sha256
                (base32
-                "1xd0xffw0g5vvwbq4ksmm3jjfq45f9dw20xpmi82g1fj9f7wy85k"))))
+                "0ym3n60gq0kzzknk5ir8ib09cxsak9hkv7mmgsyic69jmdkszadd"))))
     (build-system gnu-build-system)
     (propagated-inputs
       (list openssl-1.1 pixman spice-protocol))
     (inputs
-      (list cyrus-sasl
+      (list bash-minimal
+            cyrus-sasl
             glib
             libjpeg-turbo
             libcacard ; smartcard support
@@ -251,7 +252,6 @@ (define-public spice
       `(#:configure-flags
         '("--enable-lz4"
           "--enable-automated-tests")
-
         #:phases
         (modify-phases %standard-phases
           ;; XXX: Otherwise the server listen tests fails with
@@ -259,7 +259,6 @@ (define-public spice
           (add-before 'check 'set-XDG_CONFIG_HOME
             (lambda _
               (setenv "XDG_CONFIG_HOME" "/tmp"))))
-
         ;; Several tests appear to be opening the same sockets concurrently.
         #:parallel-tests? #f))
     (synopsis "Server implementation of the SPICE protocol")
-- 
2.39.1

[bug#61042] [PATCH 6/6] gnu: spice-vdagent: Update to 0.22.0.

[Simon Streit]

* gnu/packages/spice.scm (spice-vdagent): Update to 0.22.0.
  [patches]: Remove spice-vdagent-glib-2.68.patch.
---
 gnu/packages/spice.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 44080049c5..bf44d05e10 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -272,7 +272,7 @@ (define-public spice
 (define-public spice-vdagent
   (package
     (name "spice-vdagent")
-    (version "0.21.0")
+    (version "0.22.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -280,9 +280,7 @@ (define-public spice-vdagent
                 "spice-vdagent-" version ".tar.bz2"))
               (sha256
                (base32
-                "0n8jlc1pv6mkry161y656b1nk9hhhminjq6nymzmmyjl7k95ymzx"))
-              (patches
-               (search-patches "spice-vdagent-glib-2.68.patch"))))
+                "14zvm20ww6cnmqadjy9qlmh04imvnv395zdkgmlcvkixxsi9fdam"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
-- 
2.39.1

[bug#61042] [v2 0/6] Upgrade spice packages

[Simon Streit]

Second version.  Gnome-boxes had to be modified too, as it would otherwise
fail to build after upgrading the other packages.

Simon Streit (6):
  gnu: usbredir: Update to 0.13.0.
  gnu: virglrenderer: Update to 0.10.4.
  gnu: spice-protocol: Update to 0.14.4.
  gnu: spice-gtk: Update to 0.41.
  gnu: spice: Update to 0.15.1.
  gnu: spice-vdagent: Update to 0.22.0.

 gnu/packages/spice.scm | 112 ++++++++++++++++++++---------------------
 1 file changed, 56 insertions(+), 56 deletions(-)

--
2.39.1

[bug#61042] [v2 1/6] gnu: usbredir: Update to 0.13.0.

[Simon Streit]

* gnu/packages/spice.scm (usbredir): Update to 0.1.30.
  [build-system]: Change to meson-build-system.
  [inputs]: Add glib.
---
 gnu/packages/spice.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 2be724c455..fd0ac077ed 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2019, 2020, 2022 Marius Bakke <marius@gnu.org>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2023 Simon Streit <simon@netpanic.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -60,19 +61,20 @@ (define-public usbredir
   (package
     (name "usbredir")
     (home-page "https://spice-space.org")
-    (version "0.9.0")
+    (version "0.13.0")
     (source (origin
               (method url-fetch)
               (uri (string-append home-page "/download/" name "/" name "-"
                                   version ".tar.xz"))
               (sha256
                (base32
-                "19jnpzlanq0a1m5lmlcsp50wxf7icxvpvclx7hnf0zxw8azngqd3"))))
-    (build-system gnu-build-system)
+                "0vn4gnd8nmnrvvj2rm7akf4sbcslmdk3v22k9kmxxrha5jhgm9jb"))))
+    (build-system meson-build-system)
     (propagated-inputs
      (list libusb))
     (native-inputs
      (list autoconf automake libtool pkg-config))
+    (inputs (list glib))
     (synopsis "Tools for sending USB device traffic over a network")
     (description
      "Usbredir is a network protocol for sending USB device traffic over a
-- 
2.39.1

[bug#61042] [v2 2/6] gnu: virglrenderer: Update to 0.10.4.

[Simon Streit]

* gnu/packages/spice.scm (virglrenderer): Update to 0.10.4.
  [uri]: Update source uri.
  [build-system] Change to meson-build-system.
  [inputs]: Add python; remove eudev.
  [home-page]: Update url.
---
 gnu/packages/spice.scm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index fd0ac077ed..6eb8a4bfc7 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -85,25 +85,24 @@ (define-public usbredir
 (define-public virglrenderer
   (package
     (name "virglrenderer")
-    (version "0.6.0")
+    (version "0.10.4")
     (source (origin
               (method url-fetch)
-              (uri (string-append
-                "https://www.freedesktop.org/software/virgl/"
-                "virglrenderer-" version ".tar.bz2"))
-              (patches (search-patches "virglrenderer-CVE-2017-6386.patch"))
+              (uri (string-append "https://gitlab.freedesktop.org/virgl/"
+                    name "/-/archive/" version "/" name "-" version
+                    ".tar.gz"))
               (sha256
                (base32
-                "06kf0q4l52gzx5p63l8850hff8pmhp7xv1hk8zgx2apbw18y6jd5"))))
-    (build-system gnu-build-system)
+                "0522czb3nixkpwjknw3w1ifaj50686a2aj46v4r5cr0zh9cxqgys"))))
+    (build-system meson-build-system)
     (inputs
-      (list libepoxy mesa eudev))
+      (list libepoxy mesa python))
     (native-inputs
       (list pkg-config))
     (synopsis "Virtual 3D GPU library")
     (description "A virtual 3D GPU library that enables a virtualized operating
 system to use the host GPU to accelerate 3D rendering.")
-    (home-page "https://virgil3d.github.io")
+    (home-page "https://gitlab.freedesktop.org/virgl/virglrenderer")
     (license (list license:expat license:bsd-3))))
 
 (define-public spice-protocol
-- 
2.39.1

[bug#61042] [v2 3/6] gnu: spice-protocol: Update to 0.14.4.

[Simon Streit]

* gnu/packages/spice.scm (spice-protocol): Update to 0.14.4.
---
 gnu/packages/spice.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 6eb8a4bfc7..cfcae44b91 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -108,7 +108,7 @@ (define-public virglrenderer
 (define-public spice-protocol
   (package
     (name "spice-protocol")
-    (version "0.14.3")
+    (version "0.14.4")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -116,7 +116,7 @@ (define-public spice-protocol
                 "spice-protocol-" version ".tar.xz"))
               (sha256
                (base32
-                "0yj8k7gcirrsf21w0q6146n5g4nzn2pqky4p90n5760m5ayfb1pr"))))
+                "04nr2w6ymy5jinfi3lj6205yd5h0swss3ykxqk7l3m4z1mhvmzq4"))))
     (build-system meson-build-system)
     (arguments
      `(#:phases
-- 
2.39.1

[bug#61042] [v2 4/6] gnu: spice-gtk: Update to 0.41.

[Simon Streit]

* gnu/packages/spice.scm (spice-gtk): Update to 0.41.
  [source]: Modify uri scheme.
  [build-system]: Change to meson-build-system.
  [inputs]: Remove labels.
  [native-inputs]: Remove labels.
  [arguments]: Disable tests temporarily.
---
 gnu/packages/spice.scm | 68 ++++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index cfcae44b91..1f68b1309d 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -42,6 +42,8 @@ (define-module (gnu packages spice)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-build)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages security-token)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages virtualization)
@@ -138,16 +140,16 @@ (define-public spice-protocol
 (define-public spice-gtk
   (package
     (name "spice-gtk")
-    (version "0.37")
+    (version "0.41")
     (source (origin
               (method url-fetch)
               (uri (string-append
                 "https://spice-space.org/download/gtk/"
-                "spice-gtk-" version ".tar.bz2"))
+                name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1drvj8y35gnxbnrxsipwi15yh0vs9ixzv4wslz6r3lra8w3bfa0z"))))
-    (build-system gnu-build-system)
+                "17wnl2yfaic4zd4k7iz76rpdpb3jgnk7dhlcxcp7114ixb5vby6q"))))
+    (build-system meson-build-system)
     (propagated-inputs
       (list gstreamer
             gst-plugins-base
@@ -158,39 +160,39 @@ (define-public spice-gtk
             pixman
             openssl-1.1))
     (inputs
-      `(("glib-networking" ,glib-networking)
-        ("gobject-introspection" ,gobject-introspection)
-        ("json-glib" ,json-glib)
-        ("libepoxy" ,libepoxy)
-        ("libjpeg" ,libjpeg-turbo)
-        ("libxcb" ,libxcb)
-        ("lz4" ,lz4)
-        ("mesa" ,mesa)
-        ("pulseaudio" ,pulseaudio)
-        ("python" ,python)
-        ("opus" ,opus)
-        ("usbredir" ,usbredir)))
+      (list bash-minimal
+            glib-networking
+            json-glib
+            libepoxy
+            libjpeg-turbo
+            libxcb
+            lz4
+            mesa
+            opus
+            pulseaudio
+            python
+            python-pyparsing
+            python-six
+            usbredir))
     (native-inputs
-      `(("glib:bin" ,glib "bin")
-        ("intltool" ,intltool)
-        ("pkg-config" ,pkg-config)
-        ("vala" ,vala)))
+      (list `(,glib "bin")
+            gobject-introspection
+            intltool
+            pkg-config
+            python
+            vala))
     (arguments
-      `(#:configure-flags
-        '("--enable-gstaudio"
-          "--enable-gstvideo"
-          "--enable-pulse"
-          "--enable-vala"
-          "--enable-introspection")
+      `(#:tests? #f
         #:phases
          (modify-phases %standard-phases
-           (add-before 'check 'disable-session-test
-             (lambda _
-               ;; XXX: Disable session tests, because they require USB support,
-               ;; which is not available in the build container.
-               (substitute* "tests/Makefile"
-                 (("test-session\\$\\(EXEEXT\\) ") ""))
-               #t))
+           ;; (add-before 'check 'disable-session-test
+           ;;   (lambda _
+           ;;     ;; XXX: Disable session tests, because they require USB
+           ;;     ;; support, which is not available in the build container.
+           ;;     (substitute* "tests/meson.build"
+           ;;       (("[ \t]*.*session.*$") ""))
+           ;;     #t
+           ;;     ))
            (add-after 'install 'patch-la-files
              (lambda* (#:key inputs outputs #:allow-other-keys)
                (let ((out (assoc-ref outputs "out"))
-- 
2.39.1

[bug#61042] [v2 5/6] gnu: spice: Update to 0.15.1.

[Simon Streit]

* gnu/packages/spice.scm (spice): Update to 0.15.1.
  [inputs]: Add bash-minimal.
---
 gnu/packages/spice.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 1f68b1309d..44080049c5 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -219,7 +219,7 @@ (define-public spice-gtk
 (define-public spice
   (package
     (name "spice")
-    (version "0.15.0")
+    (version "0.15.1")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -227,12 +227,13 @@ (define-public spice
                 "spice-server/spice-" version ".tar.bz2"))
               (sha256
                (base32
-                "1xd0xffw0g5vvwbq4ksmm3jjfq45f9dw20xpmi82g1fj9f7wy85k"))))
+                "0ym3n60gq0kzzknk5ir8ib09cxsak9hkv7mmgsyic69jmdkszadd"))))
     (build-system gnu-build-system)
     (propagated-inputs
       (list openssl-1.1 pixman spice-protocol))
     (inputs
-      (list cyrus-sasl
+      (list bash-minimal
+            cyrus-sasl
             glib
             libjpeg-turbo
             libcacard ; smartcard support
@@ -251,7 +252,6 @@ (define-public spice
       `(#:configure-flags
         '("--enable-lz4"
           "--enable-automated-tests")
-
         #:phases
         (modify-phases %standard-phases
           ;; XXX: Otherwise the server listen tests fails with
@@ -259,7 +259,6 @@ (define-public spice
           (add-before 'check 'set-XDG_CONFIG_HOME
             (lambda _
               (setenv "XDG_CONFIG_HOME" "/tmp"))))
-
         ;; Several tests appear to be opening the same sockets concurrently.
         #:parallel-tests? #f))
     (synopsis "Server implementation of the SPICE protocol")
-- 
2.39.1

[bug#61042] [v2 6/6] gnu: spice-vdagent: Update to 0.22.0.

[Simon Streit]

* gnu/packages/spice.scm (spice-vdagent): Update to 0.22.0.
  [patches]: Remove spice-vdagent-glib-2.68.patch.
---
 gnu/packages/spice.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
index 44080049c5..bf44d05e10 100644
--- a/gnu/packages/spice.scm
+++ b/gnu/packages/spice.scm
@@ -272,7 +272,7 @@ (define-public spice
 (define-public spice-vdagent
   (package
     (name "spice-vdagent")
-    (version "0.21.0")
+    (version "0.22.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -280,9 +280,7 @@ (define-public spice-vdagent
                 "spice-vdagent-" version ".tar.bz2"))
               (sha256
                (base32
-                "0n8jlc1pv6mkry161y656b1nk9hhhminjq6nymzmmyjl7k95ymzx"))
-              (patches
-               (search-patches "spice-vdagent-glib-2.68.patch"))))
+                "14zvm20ww6cnmqadjy9qlmh04imvnv395zdkgmlcvkixxsi9fdam"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
-- 
2.39.1

bug#61042: [PATCH 0/6] Upgrade spice packages

[Maxim Cournoyer]

Hi Simon,

Simon Streit <simon@netpanic.org> writes:

> * gnu/packages/spice.scm (virglrenderer): Update to 0.10.4.
>   [uri]: Update source uri.
>   [build-system] Change to meson-build-system.
>   [inputs]: Add python; remove eudev.
>   [home-page]: Update url.
> ---
>  gnu/packages/spice.scm | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm
> index fd0ac077ed..6eb8a4bfc7 100644
> --- a/gnu/packages/spice.scm
> +++ b/gnu/packages/spice.scm
> @@ -85,25 +85,24 @@ (define-public usbredir
>  (define-public virglrenderer
>    (package
>      (name "virglrenderer")
> -    (version "0.6.0")
> +    (version "0.10.4")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append
> -                "https://www.freedesktop.org/software/virgl/"
> -                "virglrenderer-" version ".tar.bz2"))
> -              (patches (search-patches "virglrenderer-CVE-2017-6386.patch"))
> +              (uri (string-append "https://gitlab.freedesktop.org/virgl/"
> +                    name "/-/archive/" version "/" name "-" version
> +                    ".tar.gz"))

We don't use any of the 'archive' github/gitlab links as they point to
tarballs generated on the fly, which may change subtly and invalidate
the hash.  I've used git-fetch instead.

>                (sha256
>                 (base32
> -                "06kf0q4l52gzx5p63l8850hff8pmhp7xv1hk8zgx2apbw18y6jd5"))))
> -    (build-system gnu-build-system)
> +                "0522czb3nixkpwjknw3w1ifaj50686a2aj46v4r5cr0zh9cxqgys"))))
> +    (build-system meson-build-system)
>      (inputs
> -      (list libepoxy mesa eudev))
> +      (list libepoxy mesa python))

I move python to native-inputs, since no reference to it is kept.

>      (native-inputs
>        (list pkg-config))
>      (synopsis "Virtual 3D GPU library")
>      (description "A virtual 3D GPU library that enables a virtualized operating
>  system to use the host GPU to accelerate 3D rendering.")
> -    (home-page "https://virgil3d.github.io")
> +    (home-page "https://gitlab.freedesktop.org/virgl/virglrenderer")
>      (license (list license:expat license:bsd-3))))

Thanks for spotting the change of URI, I had missed it in my other
submission also updating spice and friends (sorry for missing that older
submission in the first place!).

Closing.

-- 
Thanks,
Maxim