From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MAukNB/ExGOvOQAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 04:27:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oI2tMx/ExGO7EgEAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 04:27:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 97A91390F8 for ; Mon, 16 Jan 2023 04:27:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHG9M-0000Hp-CU; Sun, 15 Jan 2023 22:27:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHG9K-0000Gg-PG for guix-patches@gnu.org; Sun, 15 Jan 2023 22:27:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHG9K-0005pq-HL for guix-patches@gnu.org; Sun, 15 Jan 2023 22:27:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHG9K-0007tr-DU for guix-patches@gnu.org; Sun, 15 Jan 2023 22:27:06 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60224] [PATCH v5 11/13] gnu: u-boot-rockpro64-rk3399: Use gexps and fix build. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 03:27:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60224 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60224@debbugs.gnu.org Cc: rekado@elephly.net, Maxim Cournoyer , vagrant@reproducible-builds.org Received: via spool by 60224-submit@debbugs.gnu.org id=B60224.167383958330214 (code B ref 60224); Mon, 16 Jan 2023 03:27:06 +0000 Received: (at 60224) by debbugs.gnu.org; 16 Jan 2023 03:26:23 +0000 Received: from localhost ([127.0.0.1]:60074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHG8c-0007r9-Lu for submit@debbugs.gnu.org; Sun, 15 Jan 2023 22:26:23 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:40926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHG8R-0007pV-Sm for 60224@debbugs.gnu.org; Sun, 15 Jan 2023 22:26:12 -0500 Received: by mail-qt1-f181.google.com with SMTP id jr10so16467155qtb.7 for <60224@debbugs.gnu.org>; Sun, 15 Jan 2023 19:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0vMnnyqvc1WmPs7eKBIh9WVuvVcTB+tCa/NVI9WymVU=; b=H83keKuAa2FPPWfrbAc1skM2WrNQw4IhLvJ8FWIfXTC+A8VGS5fdjDI4tpV9jjeOiU Ol0JPThdel8KgZ8OCf5NlrqXUxOzQVJ24wt6EsxQQTXFxxyi3ycz4VFNj4E8HxA7aso3 P+uHt5LJrDCnY1j+jxIQAjsufSO6e1BHxRpYFmzld6s9MSOfAx9QLZUzLIqxHUGDQ8xw eMbAFteUEueDu7ZTq2fvdEpnacLGV2pLTLDYNchsxsbsI3WQmf+J4iLlso0udH/VC2rj bTK3q7vivQOz7NQdsF6Z1MeHw1p/erNpxDfya0hc9ime6LPHrToMH0ZihCS4uB9hbBSw AjUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0vMnnyqvc1WmPs7eKBIh9WVuvVcTB+tCa/NVI9WymVU=; b=BdPKKJIJLM0XcDbvv59H7Dq/D0Tx1iz6W48zvZvijMqvYrsOAcGwVZzuG0NCzQGN0+ l9PYkhntEdI1oLZJ2Rf/NRtD9U75hmyWVVK6OPg49W+MRASbGphXXMAfvdUwPImdWIwN 92omqTkPfO9RdT5q+qWjLaEH/z54rwBJg5ouDLD1NZ/Q8K6JRdDuQ1/9bqnXZLayms/6 ePQU5rkjFWIO7oJmAHfkbig87Yv0xJrMGQgA4JqZTnIC8UMvpRjNzTIcQZlgP04uqFWj F5E7GS8inpHM9IBDw1CdWEkCn3QBHsQN3jg5BU7qzXRRxi5HCdewMqSiVwmj73mW/9mG lVJQ== X-Gm-Message-State: AFqh2kpdrLDal8X5DR4Bv6l3AgZ5KsOmchhFJU3H1GV+ptug++5PKDvF u76fh5WlepZUPEOJBXtTqwsZDNkpSib61NPz X-Google-Smtp-Source: AMrXdXsePiM4Qim3RNDO8xjTSytg37d9YpC6qMlNUn6cSdU2v1ni3guU1vgQ3bUrsZOtwVY6R/L0NQ== X-Received: by 2002:ac8:73da:0:b0:3b6:2f46:937c with SMTP id v26-20020ac873da000000b003b62f46937cmr4858298qtp.37.1673839566192; Sun, 15 Jan 2023 19:26:06 -0800 (PST) Received: from localhost.localdomain (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id bi1-20020a05620a318100b006fb0e638f12sm17474636qkb.4.2023.01.15.19.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jan 2023 19:26:05 -0800 (PST) From: Maxim Cournoyer Date: Sun, 15 Jan 2023 22:25:42 -0500 Message-Id: <20230116032544.1378-11-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230116032544.1378-1-maxim.cournoyer@gmail.com> References: <20230116032544.1378-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H83keKuA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673839647; a=rsa-sha256; cv=none; b=UjHz7SwPeNfF2bwRgbVWT6rgQejtD8vNpRLeEAis5L0TqiXEt7FjAQJm2ZQrH+Muo83Zlq mvsgUMUzv/CWcLubhLbTKOK7inyzJfpoZ+kx2GV8/HPeFy1fyY+f8a2gxU+djOcj+FqnZp toDwLyuqnjUbKquX8ZPsnMI0ahGdUgB8J5ewlqnUW08TVgF6wYfT0eKU/pt1o9sU6NoWXp ybFcJF+CCcYPNY/iFxTVLr3OrYQcppDUuYYXmalZC8Le7myqvEhFCqeo2b9ETz8VjzvszR gnb0psQDG6Pr8gfyghiWYqH6r0Zodd8ZIHxa9Be0E112FiiUMGIHeNS2sPoUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673839647; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0vMnnyqvc1WmPs7eKBIh9WVuvVcTB+tCa/NVI9WymVU=; b=Ijq30vOXw1yFI77RFMGlgQJu2Qj0USokfsIhWhxGQC2Zhh4358jo9u9zCuEaLuc91K55eL mpwhhV6hAdxpcFd17Fi4B16HYoZulTTJ4qFIVJy4LGuauG35fVVjZ+dshkZaPp7QmrjOeA XVoTBdq1G5QataseOBF7NfmOSh3MkYMN1hHnKAJOCiyYAibsItFN2ZHy6LLlcRrmCPhCvI B2uQp1wWmTgx4d8W/whgNDW+z7L2Jmm9vH333y4C4sSkWjwBmrlfwe0Pqr7CuZlPyAefQf 2cNvt6RPS0AQ1Lx4lvBgjc/Mlo0LFE/kn3Ul8ZcdS+QP0dJzPiOGOcKP91CesA== X-Migadu-Queue-Id: 97A91390F8 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H83keKuA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -0.82 X-Spam-Score: -0.82 X-TUID: T8PtasUN+Kna * gnu/packages/bootloaders.scm (u-boot-rockpro64-rk3399) [phases]: Use gexps. [native-inputs]: Use modify-inputs and turn into... [inputs]: ... this. --- (no changes since v4) Changes in v4: - Make the arm-trusted-firmware-rk3399 a regular input gnu/packages/bootloaders.scm | 45 ++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index d9f9672f77..9da97232ea 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -1176,37 +1176,36 @@ (define-public u-boot-rockpro64-rk3399 (arguments (substitute-keyword-arguments (package-arguments base) ((#:phases phases) - `(modify-phases ,phases - (add-after 'unpack 'set-environment - (lambda* (#:key inputs #:allow-other-keys) - (setenv "BL31" - (search-input-file inputs "/bl31.elf")))) - (add-after 'unpack 'patch-header - (lambda _ - (substitute* "include/config_distro_bootcmd.h" - (("\"scsi_need_init=false") - "\"setenv scsi_need_init false") - (("#define BOOTENV_SET_SCSI_NEED_INIT \"scsi_need_init=;") - "#define BOOTENV_SET_SCSI_NEED_INIT \"setenv scsi_need_init;")) - (substitute* "include/configs/rockchip-common.h" - (("#define BOOT_TARGET_DEVICES\\(func\\)") - " + #~(modify-phases #$phases + (add-after 'unpack 'set-environment + (lambda* (#:key inputs #:allow-other-keys) + (setenv "BL31" (search-input-file inputs "/bl31.elf")))) + (add-after 'unpack 'patch-header + (lambda _ + (substitute* "include/config_distro_bootcmd.h" + (("\"scsi_need_init=false") + "\"setenv scsi_need_init false") + (("#define BOOTENV_SET_SCSI_NEED_INIT \"scsi_need_init=;") + "#define BOOTENV_SET_SCSI_NEED_INIT \"setenv scsi_need_init;")) + (substitute* "include/configs/rockchip-common.h" + (("#define BOOT_TARGET_DEVICES\\(func\\)") + " #if CONFIG_IS_ENABLED(CMD_SCSI) #define BOOT_TARGET_SCSI(func) func(SCSI, scsi, 0) #else #define BOOT_TARGET_SCSI(func) #endif #define BOOT_TARGET_DEVICES(func)") - (("BOOT_TARGET_NVME\\(func\\) \\\\") - "\ + (("BOOT_TARGET_NVME\\(func\\) \\\\") + "\ BOOT_TARGET_NVME(func) \\ BOOT_TARGET_SCSI(func) \\")))) - ;; Phases do not succeed on the bl31 ELF. - (delete 'strip) - (delete 'validate-runpath))))) - (native-inputs - `(("firmware" ,arm-trusted-firmware-rk3399) - ,@(package-native-inputs base)))))) + ;; Phases do not succeed on the bl31 ELF. + (delete 'strip) + (delete 'validate-runpath))))) + (inputs + (modify-inputs (package-inputs base) + (append arm-trusted-firmware-rk3399)))))) (define-public u-boot-pinebook-pro-rk3399 (let ((base (make-u-boot-package "pinebook-pro-rk3399" "aarch64-linux-gnu"))) -- 2.38.1