unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: pukkamustard <pukkamustard@posteo.net>
Cc: 60120-done@debbugs.gnu.org
Subject: bug#60120: [PATCH 01/28] gnu: Add ocaml-5.0.
Date: Wed, 21 Dec 2022 22:11:53 +0100	[thread overview]
Message-ID: <20221221221153.7915a496@sybil.lepiller.eu> (raw)
In-Reply-To: <20221216132527.2539-1-pukkamustard@posteo.net>

Hi!

Thanks for the patch series. Pushed to master with the following fixes:

[01/28]
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ocaml/ocaml")
> +                    (commit version)))

is missing a file-name field (guix lint complains about it), like this:
(file-name (git-file-name name version))

[04/28]
> +(define-public ocaml5.0-result
but this was not added to the properties of ocaml-result.

[06/28]
0.2.1 is the latest version.

[07/28]
> "https://gitlab.inria.fr/fpottier/monolith/-/archive/20210525/archive.tar.gz"

I think this might not be a stable archive, and guix lint complains
about the name, so I used git-fetch instead.

[08/28]
0.3.0 is the latest version.

[09/28]
There was a space at the end of description, and it contained typos.
You should use https instead of http when available. There was a tab in
the patch.

[20/28]
Description does not match our usual style. It seems you didn't define
ocaml-eio as public, because it fails to build. Would be great to fix,
wdyt?

[21/28]
Missing synopsis and description.

[22/28]
Description does not match our usual style.

[23/28]
Missing synopsis and description.

[24/28]
Missing synopsis and description.





  parent reply	other threads:[~2022-12-21 21:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16 13:22 [bug#60120] [PATCH 00/28] gnu: Add ocaml-5.0 pukkamustard
2022-12-16 13:25 ` [bug#60120] [PATCH 01/28] " pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 02/28] gnu: ocaml-findlib: Update to 1.9.5 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 03/28] gnu: Add ocaml5.0-findlib pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 04/28] guix: ocaml: Add package-with-ocaml5.0 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 05/28] gnu: opam: Use OCaml 4.14 compiled version when building OCaml 5.0 packages pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 06/28] gnu: Add ocaml-psq pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 07/28] gnu: Add ocaml-monolith pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 08/28] gnu: Add ocaml-optint pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 09/28] gnu: Add ocaml-hmap pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 10/28] gnu: Add ocaml5.0-base pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 11/28] gnu: Update ocaml-ppxlib to 0.25.1 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 12/28] gnu: Update ocaml-qcheck to 0.20 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 13/28] gnu: Add ocaml5.0-ppx-expect pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 14/28] gnu: Update ocaml-odoc to 2.2.0 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 15/28] gnu: Add ocaml5.0-crowbar pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 16/28] gnu: Add ocaml-lwt-dllist pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 17/28] gnu: Add ocaml5.0-ctypes pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 18/28] gnu: Add ocaml-bechamel pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 19/28] gnu: ocaml-mdx: Move inputs to propagated-inputs pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 20/28] gnu: Add ocaml5.0-eio pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 21/28] gnu: Add ocaml5.0-eio-luv pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 22/28] gnu: Add ocaml-uring pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 23/28] gnu: Add ocaml5.0-eio-linux pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 24/28] gnu: Add ocaml5.0-eio-main pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 25/28] gnu: Update ocaml-merlin-lib to 4.7-414 pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 26/28] gnu: Add ocaml5.0-merlin-lib pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 27/28] gnu: Add ocaml5.0-dot-merlin-reader pukkamustard
2022-12-16 13:25   ` [bug#60120] [PATCH 28/28] gnu: Add ocaml5.0-merlin pukkamustard
2022-12-21 21:11   ` Julien Lepiller [this message]
2022-12-22  7:08     ` [bug#60120] [PATCH 01/28] gnu: Add ocaml-5.0 pukkamustard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221221153.7915a496@sybil.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=60120-done@debbugs.gnu.org \
    --cc=pukkamustard@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).