[bug#59418] [PATCH] gnu: add raider

unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed

* [bug#59418] [PATCH] gnu: add raider
@ 2022-11-20 19:05 Ahriman via Guix-patches via
  2022-11-24  6:26 ` 宋文武 via Guix-patches via
  2022-11-24 15:15 ` [bug#59418] [PATCH] " Ahriman via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: Ahriman via Guix-patches via @ 2022-11-20 19:05 UTC (permalink / raw)
  To: 59418; +Cc: Ahriman

* gnu/packages/gnome.scm (raider): New variable.
---
 gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3d942635a2..08b6c4263a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4956,6 +4956,46 @@ (define-public glib-networking
 from the GSettings schemas in gsettings-desktop-schemas.")
     (license license:lgpl2.1+)))
 
+(define-public raider
+  (package
+    (name "raider")
+    (version "1.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ADBeveridge/raider/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ll9220d6qf9m7wdi5xhq69p8h8whs7l5h5nzdhlbn99qh5388bz"))))
+    (build-system meson-build-system)
+    (arguments
+     (list #:meson meson-0.63
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'patch-paths
+                          (lambda* (#:key inputs #:allow-other-keys)
+                            (substitute* "data/com.github.ADBeveridge.Raider.gschema.xml"
+                              (("/usr/bin/shred")
+                               (which "shred"))))))))
+    (native-inputs (list gettext-minimal
+                         pkg-config
+                         cmake
+                         `(,glib "bin")
+                         desktop-file-utils
+                         itstool
+                         gobject-introspection
+                         blueprint-compiler
+                         libadwaita
+                         gtk
+                         `(,gtk "bin")))
+    (home-page "https://github.com/ADBeveridge/raider")
+    (synopsis "File shredder for GNOME")
+    (description
+     "Raider is a simple shredding program built for GNOME.  Also known as File
+Shredder, it uses the GNU Core Utility called shred.")
+    (license license:gpl3)))
+
 (define-public rest
   (package
     (name "rest")

base-commit: 347733bcde2edb60bc831d363971c488eb74e3f8
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#59418] [PATCH] gnu: add raider
  2022-11-20 19:05 [bug#59418] [PATCH] gnu: add raider Ahriman via Guix-patches via
@ 2022-11-24  6:26 ` 宋文武 via Guix-patches via
  2022-11-24 15:15 ` [bug#59418] [PATCH] " Ahriman via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: 宋文武 via Guix-patches via @ 2022-11-24  6:26 UTC (permalink / raw)
  To: Ahriman; +Cc: 59418

Ahriman <ahriman@fedora.email> writes:

Hello,
> * gnu/packages/gnome.scm (raider): New variable.
> ---
>  gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3d942635a2..08b6c4263a 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -4956,6 +4956,46 @@ (define-public glib-networking
>  from the GSettings schemas in gsettings-desktop-schemas.")
>      (license license:lgpl2.1+)))
>  
> +(define-public raider
> +  (package
> +    (name "raider")
> +    (version "1.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ADBeveridge/raider/")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0ll9220d6qf9m7wdi5xhq69p8h8whs7l5h5nzdhlbn99qh5388bz"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list #:meson meson-0.63
Does the default meson-0.60 not works?

> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'patch-paths
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (substitute* "data/com.github.ADBeveridge.Raider.gschema.xml"
> +                              (("/usr/bin/shred")
> +                               (which "shred"))))))))
> +    (native-inputs (list gettext-minimal
> +                         pkg-config
> +                         cmake
> +                         `(,glib "bin")
> +                         desktop-file-utils
> +                         itstool
> +                         gobject-introspection
> +                         blueprint-compiler
> +                         libadwaita
> +                         gtk

I think libadwaita and gtk should go into inputs, native-inputs are for
binaries needed at build time, while inputs are dependencies of runtime.
> +                         `(,gtk "bin")))
> +    (home-page "https://github.com/ADBeveridge/raider")
> +    (synopsis "File shredder for GNOME")

Maybe "Securely delete your files" as in the shortdesc of raider.doap.
As "shredder" is not a very clear word...

> +    (description
> +     "Raider is a simple shredding program built for GNOME.  Also known as File
> +Shredder, it uses the GNU Core Utility called shred.")
> +    (license license:gpl3)))

According to the source, it should gpl3+.
> +
>  (define-public rest
>    (package
>      (name "rest")
>
> base-commit: 347733bcde2edb60bc831d363971c488eb74e3f8

Could you send an update patch, thank you!




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#59418] [PATCH] add raider
  2022-11-20 19:05 [bug#59418] [PATCH] gnu: add raider Ahriman via Guix-patches via
  2022-11-24  6:26 ` 宋文武 via Guix-patches via
@ 2022-11-24 15:15 ` Ahriman via Guix-patches via
  2022-11-25 10:53   ` Christopher Baines
  1 sibling, 1 reply; 4+ messages in thread
From: Ahriman via Guix-patches via @ 2022-11-24 15:15 UTC (permalink / raw)
  To: 59418; +Cc: Ahriman

Hi,
https://github.com/ADBeveridge/raider/blob/develop/meson.build has meson_version: '>= 0.61.0'

* gnu/packages/gnome.scm (raider): New variable.
---
 gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3d942635a2..882196a488 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4956,6 +4956,46 @@ (define-public glib-networking
 from the GSettings schemas in gsettings-desktop-schemas.")
     (license license:lgpl2.1+)))
 
+(define-public raider
+  (package
+    (name "raider")
+    (version "1.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ADBeveridge/raider/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ll9220d6qf9m7wdi5xhq69p8h8whs7l5h5nzdhlbn99qh5388bz"))))
+    (build-system meson-build-system)
+    (arguments
+     (list #:meson meson-0.63
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'patch-paths
+                          (lambda* (#:key inputs #:allow-other-keys)
+                            (substitute* "data/com.github.ADBeveridge.Raider.gschema.xml"
+                              (("/usr/bin/shred")
+                               (which "shred"))))))))
+    (native-inputs (list gettext-minimal
+                         pkg-config
+                         cmake
+                         `(,glib "bin")
+                         desktop-file-utils
+                         itstool
+                         gobject-introspection
+                         blueprint-compiler
+                         `(,gtk "bin")))
+    (inputs (list libadwaita
+                  gtk))
+    (home-page "https://github.com/ADBeveridge/raider")
+    (synopsis "Securely delete your files")
+    (description
+     "Raider is a simple shredding program built for GNOME.  Also known as File
+Shredder, it uses the GNU Core Utility called shred to securely delete files.")
+    (license license:gpl3+)))
+
 (define-public rest
   (package
     (name "rest")

base-commit: 347733bcde2edb60bc831d363971c488eb74e3f8
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#59418] [PATCH] add raider
  2022-11-24 15:15 ` [bug#59418] [PATCH] " Ahriman via Guix-patches via
@ 2022-11-25 10:53   ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2022-11-25 10:53 UTC (permalink / raw)
  To: Ahriman; +Cc: 59418, 59418-done

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]


Ahriman via Guix-patches via <guix-patches@gnu.org> writes:

> Hi,
> https://github.com/ADBeveridge/raider/blob/develop/meson.build has meson_version: '>= 0.61.0'
>
> * gnu/packages/gnome.scm (raider): New variable.
> ---
>  gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)

Thanks for the updated patch, I made some minor tweaks, in particular
wrapping with GSETTINGS_SCHEMA_DIR so that it starts when run directly
from the store (like /gnu/store/.../bin/raider) and pushed to master as
123e6f5f2422f573673a5fdce88d88014bcbe0f1.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-25 10:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-20 19:05 [bug#59418] [PATCH] gnu: add raider Ahriman via Guix-patches via
2022-11-24  6:26 ` 宋文武 via Guix-patches via
2022-11-24 15:15 ` [bug#59418] [PATCH] " Ahriman via Guix-patches via
2022-11-25 10:53   ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).